diff mbox

PR/50076 make c-c++-common/cxxbitfields-3.c work in Darwin

Message ID 17DD310E-00A7-4CDD-800F-619B90CC1F7B@sandoe-acoustics.co.uk
State New
Headers show

Commit Message

Iain Sandoe Dec. 12, 2011, 4:18 p.m. UTC 
On 12 Dec 2011, at 15:47, Jakub Jelinek wrote:

> On Mon, Dec 12, 2011 at 04:20:57PM +0100, Dominique Dhumieres wrote:
>>>> I'm fine with whatever you guys come up with...
>>>
>>> Likewise.  I have no preference.  Whatever gets approved is ok  
>>> with me.
>>
>> So let's pick the Iain's proposal:
>>
>> Index: gcc/testsuite/c-c++-common/cxxbitfields-3.c
>> ===================================================================
>> --- gcc/testsuite/c-c++-common/cxxbitfields-3.c (revision 182177)
>> +++ gcc/testsuite/c-c++-common/cxxbitfields-3.c (working copy)
>> @@ -18,4 +18,5 @@ void setit()
>>   var.j = 5;
>> }
>>
>> -/* { dg-final { scan-assembler "movl.*, var" } } */
>> +/* { dg-final { scan-assembler "movl.*, _?var" { target { ! *-*- 
>> darwin* } } } } */
>> +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" { target *-*- 
>> darwin* } } } */
>
> Only if *-*-darwin* is replaced with !nonpic, otherwise it will fail
> say on x86_64-linux if people test with
> RUNTESTFLAGS=--target_board=unix/-fpic


thus is everyone reasonably happy with?

nonpic } } } } */

Comments

Jakub Jelinek Dec. 12, 2011, 4:20 p.m. UTC | #1 
On Mon, Dec 12, 2011 at 04:18:29PM +0000, Iain Sandoe wrote:
> thus is everyone reasonably happy with?
> 
> Index: gcc/testsuite/c-c++-common/cxxbitfields-3.c
> ===================================================================
> --- gcc/testsuite/c-c++-common/cxxbitfields-3.c	(revision 182219)
> +++ gcc/testsuite/c-c++-common/cxxbitfields-3.c	(working copy)
> @@ -18,4 +18,5 @@ void setit()
>    var.j = 5;
>  }
> 
> -/* { dg-final { scan-assembler "movl.*, var" } } */
> +/* { dg-final { scan-assembler "movl.*, _?var" { target nonpic } } } */
> +/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" { target { ! nonpic } } } } */
> 

Yes, this is ok for the trunk with proper ChangeLog entry.

	Jakub
diff mbox

Patch

Index: gcc/testsuite/c-c++-common/cxxbitfields-3.c
===================================================================
--- gcc/testsuite/c-c++-common/cxxbitfields-3.c	(revision 182219)
+++ gcc/testsuite/c-c++-common/cxxbitfields-3.c	(working copy)
@@ -18,4 +18,5 @@  void setit()
    var.j = 5;
  }

-/* { dg-final { scan-assembler "movl.*, var" } } */
+/* { dg-final { scan-assembler "movl.*, _?var" { target nonpic } } } */
+/* { dg-final { scan-assembler "movl.*, (_?var|\\(%)" { target { !