From patchwork Wed Jul 31 09:09:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kewen.Lin" X-Patchwork-Id: 1966970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=ZjPecXVN; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WYmWr0r5jz1ybV for ; Wed, 31 Jul 2024 19:10:00 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D1A2385DDD8 for ; Wed, 31 Jul 2024 09:09:58 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 383B63857022 for ; Wed, 31 Jul 2024 09:09:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 383B63857022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 383B63857022 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722416969; cv=none; b=cMXGZlNoS7CkjyHIs8A9RagM3twz5MPyyJGxYeQOwatbSHsMx8LbSVHtoVW16jBJLZIKYb+IxfSl/ylay9qWlaNV36L/Dhnvm0SdorWKrFjdWP3AvusWIo+erff3llBc4o9aMrHB/OdMJ+/5uvvoxs7OrsVNzb3Mfo/MMLO0rSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722416969; c=relaxed/simple; bh=5XEG4WV/+QBeK3FNbVJPvObAPvH4yPegYaWsAa6zGx0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=sPIAUxOriHQ7gWlgNHWt8Yu1jwrAnkYzghuT18mszQiIiJc6EyCTRhgHfqpyhhmKFPq2moPXEO9w6Vq/UqRfzBWr0AFVtWi+QrZPgMoQpwZQsx4bXLPaFe8yEOXWdOLOcyUez6L90WV35yME76nmXd1yjr9yF0GAL9NaPJNOgw0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46V5wOb3001260; Wed, 31 Jul 2024 09:09:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:to:cc:from:subject:content-type :content-transfer-encoding; s=pp1; bh=w47NrEltvnfgv4/BMFBLDbyrHg pO1+dXvfVh/LtkS3o=; b=ZjPecXVN+HKZyuskay2gGPfyPlZwQBEJxU2q3wsTdx I4pzC22w2GzvUf+X5Bj8zUeQN0NeVoT1LsT4kmUmQasrTVUdozoMxOtWUbMWZC7K EzUNkgwYoQh6rDxTvcx9/8RA4/UsIjJdR1kW4DQwEINMqEMJPP0Mz+6GWwOHFsZD BSZvHyP2eSoEqsfxXgMdl90pylajcTEi3x06MAopn533MSW4ZuuLamaGJDBseg/O AbzHsAi6jbzjSMKHaayr12yWW9kGht++RkR2nHM64mlURokvSaF0EqO6IrZvLe5G k8C8u1D5yRIn7bJ6AouU3xCm6ohHtR14+AAJa/saF2ew== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40qfkb0gv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jul 2024 09:09:25 +0000 (GMT) Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 46V99POh029715; Wed, 31 Jul 2024 09:09:25 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40qfkb0gux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jul 2024 09:09:25 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 46V8U0ok018928; Wed, 31 Jul 2024 09:09:24 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 40nc7ptmj1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jul 2024 09:09:24 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 46V99KNZ47972646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jul 2024 09:09:22 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 285232006A; Wed, 31 Jul 2024 09:09:20 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDFA920040; Wed, 31 Jul 2024 09:09:18 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 31 Jul 2024 09:09:18 +0000 (GMT) Message-ID: <164b39c2-e4b5-6ada-946b-92905c03300d@linux.ibm.com> Date: Wed, 31 Jul 2024 17:09:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: GCC Patches Cc: Segher Boessenkool , David Edelsohn , Peter Bergner From: "Kewen.Lin" Subject: [PATCH] testsuite, rs6000: Adjust pr78056-[1357].c and remove pr78056-[246].c X-TM-AS-GCONF: 00 X-Proofpoint-GUID: V6D528kW-E-P5pP3MV8VvO2NqMh3icqq X-Proofpoint-ORIG-GUID: L4q5-iBDeOL28zmRA-f2YAE0aohWFCY9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-31_06,2024-07-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 clxscore=1015 adultscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=818 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407310066 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Hi, When cleaning up the remaining powerpc_{vsx,altivec}_ok test cases, I found some issues are related to pr78056-*.c. Firstly, the test points of pr78056-[246].c are no longer available since r9-3164 drops many HAVE_AS_* and the expected warning are dropped together, so this patch is to remove them. Secondly, pr78056-1.c and pr78056-3.c include altivec.h but don't use any builtins, checking powerpc_altivec is enough (don't need to check powerpc_vsx). And pr78056-5.c doesn't require any altivec/vsx feature, so powerpc_vsx_ok can be removed. Lastly, pr78056-7.c should just use powerpc_fprs instead of dfp_hw as it only cares about insn fcpsgn. Bootstrapped and regtested on powerpc64-linux-gnu P8/P9 and powerpc64le-linux-gnu P9 and P10. I'm going to push this next week if no objections. BR, Kewen ---- gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr78056-1.c: Check for powerpc_altivec rather than powerpc_vsx. * gcc.target/powerpc/pr78056-3.c: Likewise. * gcc.target/powerpc/pr78056-5.c: Drop powerpc_vsx_ok check. * gcc.target/powerpc/pr78056-7.c: Check for powerpc_fprs rather than dfp_hw. * gcc.target/powerpc/pr78056-2.c: Remove. * gcc.target/powerpc/pr78056-4.c: Remove. * gcc.target/powerpc/pr78056-6.c: Remove. --- gcc/testsuite/gcc.target/powerpc/pr78056-1.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/pr78056-2.c | 18 -------------- gcc/testsuite/gcc.target/powerpc/pr78056-3.c | 4 ++-- gcc/testsuite/gcc.target/powerpc/pr78056-4.c | 19 --------------- gcc/testsuite/gcc.target/powerpc/pr78056-5.c | 2 -- gcc/testsuite/gcc.target/powerpc/pr78056-6.c | 25 -------------------- gcc/testsuite/gcc.target/powerpc/pr78056-7.c | 2 -- 7 files changed, 4 insertions(+), 70 deletions(-) delete mode 100644 gcc/testsuite/gcc.target/powerpc/pr78056-2.c delete mode 100644 gcc/testsuite/gcc.target/powerpc/pr78056-4.c delete mode 100644 gcc/testsuite/gcc.target/powerpc/pr78056-6.c -- 2.43.5 diff --git a/gcc/testsuite/gcc.target/powerpc/pr78056-1.c b/gcc/testsuite/gcc.target/powerpc/pr78056-1.c index 72640007dbb..49ebafe39b6 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr78056-1.c +++ b/gcc/testsuite/gcc.target/powerpc/pr78056-1.c @@ -1,7 +1,7 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ /* { dg-skip-if "" { powerpc*-*-aix* } } */ -/* { dg-options "-mdejagnu-cpu=power8 -mvsx" } */ -/* { dg-require-effective-target powerpc_vsx } */ +/* { dg-options "-mdejagnu-cpu=power8" } */ +/* { dg-require-effective-target powerpc_altivec } */ /* This test should succeed on both 32- and 64-bit configurations. */ #include diff --git a/gcc/testsuite/gcc.target/powerpc/pr78056-2.c b/gcc/testsuite/gcc.target/powerpc/pr78056-2.c deleted file mode 100644 index 5cda9d6193b..00000000000 --- a/gcc/testsuite/gcc.target/powerpc/pr78056-2.c +++ /dev/null @@ -1,18 +0,0 @@ -/* { dg-do compile { target { powerpc*-*-* } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ -/* { dg-skip-if "" { powerpc_vsx_ok } } */ -/* { dg-skip-if "" { powerpc*-*-aix* } } */ -/* { dg-options "-mdejagnu-cpu=power8 -mvsx" } */ - -/* This test should succeed on both 32- and 64-bit configurations. */ -#include - -/* Though the command line specifies power8 target, this function is - to support power9. Expect an error message here because this target - does not support power9. */ -__attribute__((target("cpu=power9"))) -int get_random () -{ /* { dg-warning "lacks power9 support" } */ - return __builtin_darn_32 (); /* { dg-warning "implicit declaration" } */ -} - diff --git a/gcc/testsuite/gcc.target/powerpc/pr78056-3.c b/gcc/testsuite/gcc.target/powerpc/pr78056-3.c index cf57d058e8b..745552b244d 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr78056-3.c +++ b/gcc/testsuite/gcc.target/powerpc/pr78056-3.c @@ -1,7 +1,7 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ -/* { dg-options "-mdejagnu-cpu=power7" } */ -/* { dg-require-effective-target powerpc_vsx } */ /* { dg-skip-if "" { powerpc*-*-aix* } } */ +/* { dg-options "-mdejagnu-cpu=power7" } */ +/* { dg-require-effective-target powerpc_altivec } */ /* This test should succeed on both 32- and 64-bit configurations. */ #include diff --git a/gcc/testsuite/gcc.target/powerpc/pr78056-4.c b/gcc/testsuite/gcc.target/powerpc/pr78056-4.c deleted file mode 100644 index 0bea0f895fa..00000000000 --- a/gcc/testsuite/gcc.target/powerpc/pr78056-4.c +++ /dev/null @@ -1,19 +0,0 @@ -/* { dg-do compile { target { powerpc*-*-* } } } */ -/* powerpc_vsx_ok represents power7 */ -/* { dg-require-effective-target powerpc_vsx_ok } */ -/* { dg-skip-if "" { powerpc_vsx_ok } } */ -/* { dg-skip-if "" { powerpc*-*-aix* } } */ -/* { dg-options "-mdejagnu-cpu=power7" } */ - -/* This test should succeed on both 32- and 64-bit configurations. */ -#include - -/* Though the command line specifies power7 target, this function is - to support power8, which will fail because this platform does not - support power8. */ -__attribute__((target("cpu=power8"))) -char -char_fetch_add_relaxed (char *ptr, int value) -{ /* { dg-warning "lacks power8 support" } */ - return __atomic_fetch_add (ptr, value, __ATOMIC_RELAXED); -} diff --git a/gcc/testsuite/gcc.target/powerpc/pr78056-5.c b/gcc/testsuite/gcc.target/powerpc/pr78056-5.c index d012a9fc955..1a62b029fda 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr78056-5.c +++ b/gcc/testsuite/gcc.target/powerpc/pr78056-5.c @@ -1,6 +1,4 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ -/* powerpc_vsx_ok represents power7 */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-skip-if "" { powerpc*-*-aix* } } */ /* { dg-options "-mdejagnu-cpu=power5" } */ diff --git a/gcc/testsuite/gcc.target/powerpc/pr78056-6.c b/gcc/testsuite/gcc.target/powerpc/pr78056-6.c deleted file mode 100644 index 2b26eebbc8d..00000000000 --- a/gcc/testsuite/gcc.target/powerpc/pr78056-6.c +++ /dev/null @@ -1,25 +0,0 @@ -/* { dg-do compile { target { powerpc*-*-* } } } */ -/* dfp_hw represents power 6 */ -/* { dg-require-effective-target dfp_hw } */ -/* powerpc_vsx_ok represents power7 */ -/* { dg-skip-if "" { powerpc_vsx_ok } } */ -/* { dg-skip-if "" { powerpc*-*-aix* } } */ -/* { dg-options "-mdejagnu-cpu=power6" } */ - -/* This test should succeed on both 32- and 64-bit configurations. */ -#include - -/* This test follows the pattern of pr78056-2.c, which has been - * exercised with binutils 2.25. This test, however, has not - * been exercised because the author of the test does not have access - * to a development environment that succesfully bootstraps gcc - * while at the same lacking assembler support for power 7. */ - -/* Though the command line specifies power6 target, this function is - to support power7. */ -__attribute__((target("cpu=power7"))) -int -div_we (int a, int b) -{ /* { dg-warning "lacks power7 support" } */ - return __builtin_divwe (a, b); /* { dg-warning "implicit declaration" } */ -} diff --git a/gcc/testsuite/gcc.target/powerpc/pr78056-7.c b/gcc/testsuite/gcc.target/powerpc/pr78056-7.c index 90452588fc8..e3df19aadc7 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr78056-7.c +++ b/gcc/testsuite/gcc.target/powerpc/pr78056-7.c @@ -1,6 +1,4 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ -/* dfp_hw represents power 6 */ -/* { dg-require-effective-target dfp_hw } */ /* { dg-skip-if "" { powerpc*-*-aix* } } */ /* { dg-options "-mdejagnu-cpu=power5" } */