From patchwork Mon Apr 25 14:09:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Schmidt X-Patchwork-Id: 614489 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qtp4d4MH6z9s0k for ; Tue, 26 Apr 2016 00:09:21 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=QsIVam6d; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:content-transfer-encoding; q=dns; s= default; b=Avliy1vGHb2iFXidsymEQZ84airQ3KIBGxfc+L+PPagRvutzsBzn9 07mr/mqly9jiiuuplZgdLPnCkebPI/GIK2DR07x8b8IwGwVBx6dP/eaUTWcV/tjM BoAKpmwXkaNjr/+ktRFC19P2sZMfaFTPy3R+Rbe8krZcbmuCmBeSxI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:content-transfer-encoding; s=default; bh=+kcEYfFI6cxtgjQkGAkzeKW794o=; b=QsIVam6ddcNTi4AG7N6C637CZUL5 +7UpxTGT4YYn2U44zvNCkMw+yCyOxbBwGSIfmr3msm0jPgYcgRYj40RxliCSA0XA b5W2RrX1suSKgU9QCuNiZDx3Ao6K+Atri/5GJ/4VPsRpmqvvJg21pR2Pxya6Hu0k podyzD2BKIPNsyc= Received: (qmail 86227 invoked by alias); 25 Apr 2016 14:09:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 86191 invoked by uid 89); 25 Apr 2016 14:09:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=opportunity X-HELO: e36.co.us.ibm.com Received: from e36.co.us.ibm.com (HELO e36.co.us.ibm.com) (32.97.110.154) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 25 Apr 2016 14:09:12 +0000 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Apr 2016 08:09:09 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 25 Apr 2016 08:09:07 -0600 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: wschmidt@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id CC1ED3E4007C for ; Mon, 25 Apr 2016 08:09:05 -0600 (MDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3PE952f36700406 for ; Mon, 25 Apr 2016 14:09:05 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3PE95wi024652 for ; Mon, 25 Apr 2016 10:09:05 -0400 Received: from [9.77.138.211] (sig-9-77-138-211.ibm.com [9.77.138.211]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u3PE94tj024563; Mon, 25 Apr 2016 10:09:04 -0400 Subject: Re: [PATCH, rs6000] Add support for vector element-reversal built-ins From: Bill Schmidt To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, richard.guenther@gmail.com, jakub@redhat.com In-Reply-To: <20160424205221.GA2935@gate.crashing.org> References: <1461524807.29088.12.camel@oc8801110288.ibm.com> <20160424205221.GA2935@gate.crashing.org> Date: Mon, 25 Apr 2016 09:09:03 -0500 Message-ID: <1461593344.29088.25.camel@oc8801110288.ibm.com> Mime-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042514-0021-0000-0000-0000449D19E3 X-IsSubscribed: yes Hi Segher, Here's the fix for the obvious pasto separated out. CCing Richi and Jakub as I'd appreciate release manager approval to include this in gcc-6-branch. This fixes some cases where built-in functions are connected to the wrong expanders because of copy-paste issues. These tend not to be used anyway because the vec_st interface is friendlier, but we should clean this up. Is that ok? Thanks, Bill 2016-04-25 Bill Schmidt * rs6000-builtin.def: Correct pasto error for stxvd2x and stxvw4x built-in functions. On Sun, 2016-04-24 at 15:52 -0500, Segher Boessenkool wrote: > On Sun, Apr 24, 2016 at 02:06:47PM -0500, Bill Schmidt wrote: > > ISA 3.0 adds the lvxh8x, lvxb16x, stvxh8x, and stvxb16x instructions, > > lxvh8x etc. It looks like you only swapped things in this message, > not in the actual patch :-) > > > (While working on this patch, I happened to notice that the existing > > entries in rs6000-builtin.def for STXVD2X_ and STXVW4X_ are > > mapped to stxsdx instead of stxvd2x/stxvw4x. I took the opportunity to > > correct that as an obvious bug.) > > Does that part need backporting? > > Should the new builtins be documented? > > Looks fine otherwise. > > > Segher > Index: gcc/config/rs6000/rs6000-builtin.def =================================================================== --- gcc/config/rs6000/rs6000-builtin.def (revision 235411) +++ gcc/config/rs6000/rs6000-builtin.def (working copy) @@ -1391,13 +1391,13 @@ BU_VSX_X (LXVW4X_V4SI, "lxvw4x_v4si", MEM) BU_VSX_X (LXVW4X_V8HI, "lxvw4x_v8hi", MEM) BU_VSX_X (LXVW4X_V16QI, "lxvw4x_v16qi", MEM) BU_VSX_X (STXSDX, "stxsdx", MEM) -BU_VSX_X (STXVD2X_V1TI, "stxsdx_v1ti", MEM) -BU_VSX_X (STXVD2X_V2DF, "stxsdx_v2df", MEM) -BU_VSX_X (STXVD2X_V2DI, "stxsdx_v2di", MEM) -BU_VSX_X (STXVW4X_V4SF, "stxsdx_v4sf", MEM) -BU_VSX_X (STXVW4X_V4SI, "stxsdx_v4si", MEM) -BU_VSX_X (STXVW4X_V8HI, "stxsdx_v8hi", MEM) -BU_VSX_X (STXVW4X_V16QI, "stxsdx_v16qi", MEM) +BU_VSX_X (STXVD2X_V1TI, "stxvd2x_v1ti", MEM) +BU_VSX_X (STXVD2X_V2DF, "stxvd2x_v2df", MEM) +BU_VSX_X (STXVD2X_V2DI, "stxvd2x_v2di", MEM) +BU_VSX_X (STXVW4X_V4SF, "stxvw4x_v4sf", MEM) +BU_VSX_X (STXVW4X_V4SI, "stxvw4x_v4si", MEM) +BU_VSX_X (STXVW4X_V8HI, "stxvw4x_v8hi", MEM) +BU_VSX_X (STXVW4X_V16QI, "stxvw4x_v16qi", MEM) BU_VSX_X (XSABSDP, "xsabsdp", CONST) BU_VSX_X (XSADDDP, "xsadddp", FP) BU_VSX_X (XSCMPODP, "xscmpodp", FP)