From patchwork Fri Apr 1 15:22:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Krebbel X-Patchwork-Id: 604888 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qc4rr5TC2z9sC3 for ; Sat, 2 Apr 2016 02:23:07 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=ypC+zfaa; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id; q=dns; s=default; b=aiwzCZP78iN2MlP NubrjWirDi3zxrilvxBkIKHhsib22nMmh0WGnVTqueALhuy7lQjviJHiqHEsm+vh ukFfQ8Pv2Li+EP6Y94VVe9NLQomdl9gUMWqtIBxecsEUaX5TDZeY2P51YtqF9ACq WvY3VRK69ml5iT0TKzqcRecRaBrk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id; s=default; bh=tdQoAHamIEtffggPRStHh 24NtkM=; b=ypC+zfaa4L3vPO83f999PjAZa2GC2C4DXXLecKxnpghxCABlvk8g1 FWqTwsPDY3a3C+IxB6i4S1BLjj7pDYq/6ofA0SLHiTFVeyPJpqU3WZdW4bz/8IVV 6lx/TMOJG06c2mrQmWNNMZHv2Pbc21owpEXMIe29RDQsxNaVOo6tn8= Received: (qmail 106081 invoked by alias); 1 Apr 2016 15:22:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 106069 invoked by uid 89); 1 Apr 2016 15:22:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=z10 X-HELO: e06smtp09.uk.ibm.com Received: from e06smtp09.uk.ibm.com (HELO e06smtp09.uk.ibm.com) (195.75.94.105) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 01 Apr 2016 15:22:57 +0000 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Apr 2016 16:22:54 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp09.uk.ibm.com (192.168.101.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 1 Apr 2016 16:22:52 +0100 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: krebbel@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 328221B0804B for ; Fri, 1 Apr 2016 16:23:28 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u31FMpJj50135164 for ; Fri, 1 Apr 2016 15:22:52 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u31FMp5J025959 for ; Fri, 1 Apr 2016 09:22:51 -0600 Received: from maggie.ibm.com (icon-9-164-135-194.megacenter.de.ibm.com [9.164.135.194]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u31FMpnU025926 (version=TLSv1/SSLv3 cipher=AES256-SHA256 bits=256 verify=NO) for ; Fri, 1 Apr 2016 09:22:51 -0600 From: Andreas Krebbel To: gcc-patches@gcc.gnu.org Subject: [Committed] PR70404 S/390: Fix insv expansion. Date: Fri, 1 Apr 2016 17:22:50 +0200 Message-Id: <1459524170-6626-1-git-send-email-krebbel@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040115-0037-0000-0000-000009A01485 X-IsSubscribed: yes While the expander accepts general_operand as src operand the risbg pattern only immediate_operand. Unfortunately the expander called force_reg only for VOIDmode constants missing things like e.g. symbol_refs. Fixed with the attached patch. Bootstrapped on s390 and s390x. This fixes the pr70174.c testcase on s390x (-march=z10). Applied to mainline. Bye, -Andreas- gcc/ChangeLog: 2016-04-01 Andreas Krebbel PR target/70404 * config/s390/s390.c (s390_expand_insv): Check for everything constant instead of just VOIDmode stuff. --- gcc/config/s390/s390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c index 4f219be..1134d0f 100644 --- a/gcc/config/s390/s390.c +++ b/gcc/config/s390/s390.c @@ -6063,7 +6063,7 @@ s390_expand_insv (rtx dest, rtx op1, rtx op2, rtx src) { machine_mode mode_s = GET_MODE (src); - if (mode_s == VOIDmode) + if (CONSTANT_P (src)) { /* For constant zero values the representation with AND appears to be folded in more situations than the (set