From patchwork Thu Dec 10 10:31:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Lawrence X-Patchwork-Id: 555102 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 15AE1140CCB for ; Thu, 10 Dec 2015 21:31:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=n5zyy+fI; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:content-type :content-transfer-encoding; q=dns; s=default; b=GDTEKk1G/3aCIRGg 9EAntF0RoJK5isRyDWDlQG5i26SxWGVlEu9RXJGqXGmugDR/oDS3X5fhsdQuxeS8 zwbnAG5VtyxI512iWpfz+iFp2fBxBhAWoujVYP2vQbDeSBa8teiqCep5iCvGJ2DM wO3Ejyy+Z44KrdLKvw+289+EsA0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:content-type :content-transfer-encoding; s=default; bh=SyALHtmmhzaeyLz59QsY3w uHu1s=; b=n5zyy+fIW0gPVRtQOC6P/wWp9hsdKGrGmx1iWC+ifzqRbdQvnxgOcX jSTuxx62FxfjoP3HFs7oiu1GK6vQ906OTyvJJ/kizGK1KqK0Tywos4Qs4PcnGIAs RlPUISOI1FTujbvP9rcQbehRkdD/5ZlkhJkYgPBpImVhG1hQG9biE= Received: (qmail 27658 invoked by alias); 10 Dec 2015 10:31:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27631 invoked by uid 89); 10 Dec 2015 10:31:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Dec 2015 10:31:43 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-5-HPRuIisWTc2GJhTJG8W-yg-1; Thu, 10 Dec 2015 10:31:37 +0000 Received: from arm.com ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 10 Dec 2015 10:31:36 +0000 From: Alan Lawrence To: gcc-patches@gcc.gnu.org Subject: [PATCH][Testsuite]Cleanup logs from gdb tests by adding newlines Date: Thu, 10 Dec 2015 10:31:32 +0000 Message-Id: <1449743492-11732-1-git-send-email-alan.lawrence@arm.com> X-MC-Unique: HPRuIisWTc2GJhTJG8W-yg-1 X-IsSubscribed: yes Runs of the guality testsuite can sometimes end up with gcc.log containing malformed lines like: A debugging session is active.PASS: gcc.dg/guality/pr36728-1.c -O2 line 18 arg4 == 4 A debugging session is active.PASS: gcc.dg/guality/restrict.c -O2 line 30 type:ip == int * Inferior 1 [process 27054] will be killed.PASS: gcc.dg/guality/restrict.c -O2 line 30 type:cicrp == const int * const restrict Inferior 1 [process 27160] will be killed.PASS: gcc.dg/guality/restrict.c -O2 line 30 type:cvirp == int * const volatile restrict This patch just makes sure the PASS/FAIL comes at the beginning of a line. (At the slight cost of adding some extra newlines not in the actual test output.) I moved the remote_close target calls earlier, to avoid any possible race condition of extra output being generated after the newline - this may not be strictly necessary. Tested on aarch64-none-linux-gnu and x86_64-none-linux-gnu. I think this is reasonable for stage 3 - OK for trunk? gcc/testsuite/ChangeLog: * lib/gcc-gdb-test.exp (gdb-test): call remote_close earlier, and send newline to log, before calling pass/fail/unsupported. * lib/gcc-simulate-thread.exp (simulate-thread): Likewise. --- gcc/testsuite/lib/gcc-gdb-test.exp | 15 ++++++++++----- gcc/testsuite/lib/gcc-simulate-thread.exp | 10 +++++++--- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/gcc/testsuite/lib/gcc-gdb-test.exp b/gcc/testsuite/lib/gcc-gdb-test.exp index d3ba6e4..f60cabf 100644 --- a/gcc/testsuite/lib/gcc-gdb-test.exp +++ b/gcc/testsuite/lib/gcc-gdb-test.exp @@ -84,8 +84,9 @@ proc gdb-test { args } { remote_expect target [timeout_value] { # Too old GDB -re "Unhandled dwarf expression|Error in sourced command file|