From patchwork Wed Oct 21 15:52:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Lawrence X-Patchwork-Id: 533910 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 276F4141346 for ; Thu, 22 Oct 2015 02:52:55 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=viy9R854; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding; q=dns; s=default; b=sYa30xpmE1AI6zEd Hnl4qNPG4Dhh0Xqwvk+ZKdF2iZnfWHERSXN/G5ybnYx2+pYJZklfpuoTSmiwxVVb V3ZK9ey2b1ExmPKkQCuuYabS+vplFWJdrtUBdJ6joGKw8q6kmF91NRmzSXSJ14Vk LmS8781c2yvm/jrCDasQH+LPhhg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding; s=default; bh=Gzdye3yftVXMHlj3oH21tT u4FPA=; b=viy9R8545a5HLY8I0v1hoT0VxzJHMxdfrIXEzFTlQ8GabNLgBmQwLC iCi4Xs9XPcWeES2QI3ij76hhUZrslb/Zlsw/dVT7CC824Pf8RKWGX4VtHyYkOy63 HWT+BCy0ldZm6XM6Pr6UitaD2Kep8SHzhChTH+OvH21fBZwqBHen0= Received: (qmail 125928 invoked by alias); 21 Oct 2015 15:52:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 125872 invoked by uid 89); 21 Oct 2015 15:52:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Oct 2015 15:52:25 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-30-ZZK_IWg8RI-2fgAM9q2YHw-1; Wed, 21 Oct 2015 16:52:20 +0100 Received: from arm.com ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 21 Oct 2015 16:52:20 +0100 From: Alan Lawrence To: gcc-patches@gcc.gnu.org Cc: kyrylo.tkachov@arm.com, ramana.radhakrishnan@arm.com, mikestump@comcast.net, ro@CeBiTec.Uni-Bielefeld.DE Subject: [PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c Date: Wed, 21 Oct 2015 16:52:07 +0100 Message-Id: <1445442727-9557-1-git-send-email-alan.lawrence@arm.com> X-MC-Unique: ZZK_IWg8RI-2fgAM9q2YHw-1 X-IsSubscribed: yes gcc.dg/tree-ssa/sra-12.c is skipped on a bunch of targets, including AArch64, because the default max-scalarization-size depends on MOVE_RATIO, and on those targets thus ends up being too small for SRA to optimize the testcase. Recently I noticed that the test has been failing for some time on ARM too. This patch fixes the test on ARM, AArch64, avr, and sh, and by extension I believe also on nds32, although I haven't managed to build a nds32 compiler to check. There is an argument that instead we should skip the test on ARM too; or rather, since at least ARM and AArch64 would like the test to pass, we should xfail it on those platforms until we have time to experiment with the threshold/param for SRA. I hope to do some more investigation on that front as part of (or followup to) PR/63679. Is this OK for trunk? Cheers, Alan gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/sra-12.c: Enable test on all targets; add --param sra-max-scalarization-size-Ospeed. --- gcc/testsuite/gcc.dg/tree-ssa/sra-12.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/sra-12.c b/gcc/testsuite/gcc.dg/tree-ssa/sra-12.c index 427f7af..139c7d1 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/sra-12.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/sra-12.c @@ -1,7 +1,6 @@ /* Verify that SRA total scalarization will not be confused by padding. */ -/* Test skipped for targets with small (often default) MOVE_RATIO. */ /* { dg-do compile } */ -/* { dg-options "-O1 -fdump-tree-release_ssa" } */ +/* { dg-options "-O1 --param sra-max-scalarization-size-Ospeed=16 -fdump-tree-release_ssa" } */ struct S { @@ -21,4 +20,4 @@ int foo (struct S *p) *p = l; } -/* { dg-final { scan-tree-dump-times "l;" 0 "release_ssa" { target { ! "aarch64*-*-* avr*-*-* nds32*-*-* sh*-*-*" } } } } */ +/* { dg-final { scan-tree-dump-times "l;" 0 "release_ssa" } } */