diff mbox

[v2,09/13] Fix PR 66768

Message ID 1445376433-14658-10-git-send-email-rth@redhat.com
State New
Headers show

Commit Message

Richard Henderson Oct. 20, 2015, 9:27 p.m. UTC 
---
 gcc/tree-ssa-address.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Law Oct. 21, 2015, 1:55 p.m. UTC | #1 
On 10/20/2015 03:27 PM, Richard Henderson wrote:
> ---
>   gcc/tree-ssa-address.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
I think this change is fine.  Needs a testcase though.

I'll also note you need ChangeLogs for all these patches.  I know you 
know that, so it's just a reminder that they're often helpful for reviewers.

Jeff
Richard Henderson Oct. 21, 2015, 5:51 p.m. UTC | #2 
On 10/21/2015 03:55 AM, Jeff Law wrote:
> On 10/20/2015 03:27 PM, Richard Henderson wrote:
>> ---
>>   gcc/tree-ssa-address.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> I think this change is fine.  Needs a testcase though.
>
> I'll also note you need ChangeLogs for all these patches.  I know you know
> that, so it's just a reminder that they're often helpful for reviewers.

I wrote them for v1, but then failed to copy them over into the messages for 
v2.  Sorry about that.  Certainly they'll be present in the actual commit.


r~
diff mbox

Patch

diff --git a/gcc/tree-ssa-address.c b/gcc/tree-ssa-address.c
index 042f9c9..bd10ae7 100644
--- a/gcc/tree-ssa-address.c
+++ b/gcc/tree-ssa-address.c
@@ -388,7 +388,7 @@  create_mem_ref_raw (tree type, tree alias_ptr_type, struct mem_address *addr,
     }
   else
     {
-      base = build_int_cst (ptr_type_node, 0);
+      base = build_int_cst (build_pointer_type (type), 0);
       index2 = addr->base;
     }