From patchwork Tue Aug 25 11:06:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Lawrence X-Patchwork-Id: 510464 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3B39E1401F6 for ; Tue, 25 Aug 2015 21:27:45 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=OGlf6dkn; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references; q=dns; s= default; b=j1HMI1MaA0bzzHphrMaFSd5BjUV22X9Ti65x2QydRYcxvOxxx3+5u Gaz6hEpYXdnOFYWp7nHLLP9LTqfTeDY3w8RJ5WkOtO/e1nIw9EQkQSFINfjHLRfa hb2VFD4DAogh/ilfiQXKQ+tJQgAmy4i404tRWOYP7rQbxQ6uSPAftc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references; s= default; bh=WTmkX+OYR0awiE0rglVRdLaL/wQ=; b=OGlf6dknOjRhyI8vdGrs jlWP9UW/cLWDKZF/X+uI/rvuJi7kbtu77ErmGubgVxyHpQ+pq8+34HVvVLiEiKk6 OzcAJm6XXBf+WBo5FIfc1N4jCZT9cGLyZOVxcFdKNd0aHJmN90lKmxm3BJqbreER dt5Wa3vg3pd7KLJd30GLd9E= Received: (qmail 15454 invoked by alias); 25 Aug 2015 11:27:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 15441 invoked by uid 89); 25 Aug 2015 11:27:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, NO_DNS_FOR_FROM, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 25 Aug 2015 11:27:36 +0000 Received: from e104536-lin.cambridge.arm.com (e104536-lin.cambridge.arm.com [10.2.207.65]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t7PB6Vof009944; Tue, 25 Aug 2015 12:06:31 +0100 Received: from e104536-lin.cambridge.arm.com (localhost [127.0.0.1]) by e104536-lin.cambridge.arm.com (8.13.8/8.11.6) with ESMTP id t7PB6Veg026011; Tue, 25 Aug 2015 12:06:31 +0100 Received: (from alalaw01@localhost) by e104536-lin.cambridge.arm.com (8.13.8/8.13.8/Submit) id t7PB6VEH026010; Tue, 25 Aug 2015 12:06:31 +0100 From: Alan Lawrence To: gcc-patches@gcc.gnu.org Cc: rguenther@suse.de, mjambor@suse.cz, Alan Lawrence Subject: [PATCH 1/5] Refactor completely_scalarize_var Date: Tue, 25 Aug 2015 12:06:13 +0100 Message-Id: <1440500777-25966-2-git-send-email-alan.lawrence@arm.com> In-Reply-To: <1440500777-25966-1-git-send-email-alan.lawrence@arm.com> References: <1440500777-25966-1-git-send-email-alan.lawrence@arm.com> X-IsSubscribed: yes This is a small refactoring/renaming patch, it just moves the call to "completely_scalarize_record" out from completely_scalarize_var, and renames the latter to create_total_scalarization_access. This is because the next patch needs to drop the "_record" suffix and I felt it would be confusing to have both completely_scalarize and completely_scalarize_var. However, it also makes the new function name (create_total_scalarization_access) consistent with the existing code & comment. Bootstrapped + check-gcc on x86_64. gcc/ChangeLog: * tree-sra.c (completely_scalarize_var): Rename to... (create_total_scalarization_access): ... Here. Drop call to completely_scalarize_record. (analyze_all_variable_accesses): Replace completely_scalarize_var with create_total_scalarization_access and completely_scalarize_record. --- gcc/tree-sra.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index 818c290..a0c92b0 100644 --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -985,7 +985,7 @@ completely_scalarize_record (tree base, tree decl, HOST_WIDE_INT offset, type_consists_of_records_p. */ static void -completely_scalarize_var (tree var) +create_total_scalarization_access (tree var) { HOST_WIDE_INT size = tree_to_uhwi (DECL_SIZE (var)); struct access *access; @@ -994,8 +994,6 @@ completely_scalarize_var (tree var) access->expr = var; access->type = TREE_TYPE (var); access->grp_total_scalarization = 1; - - completely_scalarize_record (var, var, 0, var); } /* Return true if REF has an VIEW_CONVERT_EXPR somewhere in it. */ @@ -2529,7 +2527,8 @@ analyze_all_variable_accesses (void) if (tree_to_uhwi (TYPE_SIZE (TREE_TYPE (var))) <= max_scalarization_size) { - completely_scalarize_var (var); + create_total_scalarization_access (var); + completely_scalarize_record (var, var, 0, var); if (dump_file && (dump_flags & TDF_DETAILS)) { fprintf (dump_file, "Will attempt to totally scalarize ");