From patchwork Wed Jul 2 10:05:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Wielaard X-Patchwork-Id: 366315 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 93A87140092 for ; Wed, 2 Jul 2014 20:06:30 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; q=dns; s=default; b=xXqp6tjFZFNc fYhCotbV2BYU8W7s52HzBU6DwpyN5Yyb7VdEGylWBA/ohCJccFfxTl2kywNNTtjg VrFDQfEfGgUk4v8NGMYZ9BAMFhw8rwI69rxoZWzRTF4CWGATcw/nvoHMSEiBlxyb k7mwL790lkZAbNHjOy8oC9++Tho8p8Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; s=default; bh=A7gYpJdepDTQBzP0H6 h/rY7hJPE=; b=huy/CgeSEVRUZjHN5afJizlLSD5qvTsl3GjR6ZaDH7tvjWl4O0 9IqLszKULUg9gked4206BTXQ5Po4uSWG7BAcWnmgyy1QPnZ+almZ54sgNZ6c63M3 y3sjia3Si62eA1mDhKgw1hEc3fJCV4vIQll7R4FvdMO0VQy6KFqcZlRvQ= Received: (qmail 449 invoked by alias); 2 Jul 2014 10:06:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32714 invoked by uid 89); 2 Jul 2014 10:06:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 02 Jul 2014 10:06:15 +0000 From: Mark Wielaard To: gcc-patches@gcc.gnu.org Cc: Jason Merrill , Cary Coutant , Alexandre Oliva , Diego Novillo , Richard Biener , Mark Wielaard Subject: [PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS. Date: Wed, 2 Jul 2014 12:05:45 +0200 Message-Id: <1404295545-17107-1-git-send-email-mjw@redhat.com> X-Spam-Score: -2.9 (--) Hi, While writing new guality.exp tests I noticed they often just fail when ran with -flto, even though they PASS in all other cases. When I asked on irc about this I was told that LTO was known to not play well with DWARF debuginfo anyway. If that is the case, it seems better to disable -flto for guality.exp for now since it just adds noise (and unfortunately guality.exp already has lots of FAILs). The attached patch does this. It changes the make check-c RUNTESTFLAGS=guality.exp results (against gdb git master) from: # of expected passes 3121 # of unexpected failures 180 # of unexpected successes 33 # of expected failures 15 # of unsupported tests 78 to: # of expected passes 2389 # of unexpected failures 110 # of unexpected successes 26 # of expected failures 10 # of unsupported tests 54 That looks like an improvement to me, even though the number of FAILs is still a bit high. Does this look a good thing to apply? Or are people actively working on reducing the number of LTO guality.exp failures and can we expect them to turn into PASSes soon anyway? Thanks, Mark gcc/testsuite/ChangeLog * gcc.dg/guality/guality.exp: Remove LTO_TORTURE_OPTIONS from set-torture-options. Only use DG_TORTURE_OPTIONS. --- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/guality/guality.exp | 6 ++++++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b364f40..421e006 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-07-02 Mark Wielaard + + * gcc.dg/guality/guality.exp: Remove LTO_TORTURE_OPTIONS from + set-torture-options. Only use DG_TORTURE_OPTIONS. + 2014-07-02 Uros Bizjak * gfortran.dg/ieee/ieee_1.F90 (dg-additional-options): Remove -O0. diff --git a/gcc/testsuite/gcc.dg/guality/guality.exp b/gcc/testsuite/gcc.dg/guality/guality.exp index 5e714dd..7991661 100644 --- a/gcc/testsuite/gcc.dg/guality/guality.exp +++ b/gcc/testsuite/gcc.dg/guality/guality.exp @@ -47,6 +47,12 @@ if {[check_guality " return 0; } "]} { + # Override default torture-options which include LTO_TORTURE_OPTIONS + # Currently LTO and the guality tests that depend on debuginfo don't mix. + global DG_TORTURE_OPTIONS + torture-init + set-torture-options $DG_TORTURE_OPTIONS + gcc-dg-runtest [lsort [glob $srcdir/$subdir/*.c]] "" gcc-dg-runtest [lsort [glob $srcdir/c-c++-common/guality/*.c]] "-Wc++-compat" }