From patchwork Wed May 7 08:18:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Svante Signell X-Patchwork-Id: 346423 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id ED71014017A for ; Wed, 7 May 2014 18:18:29 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:reply-to:to:cc:date:in-reply-to :references:content-type:mime-version; q=dns; s=default; b=UsfKx uv2wdL/ArI8P7HTyWRcCqMB9BtQo025cQbEjvCJXYJ93lsDIakbLEssq14+daXz5 GWLn+ID58pE9Eii31AWbixo6mYuvWxwLJn2oxI0LVrUMYhBcB7fQDFqh33YrIgki h8ApKbg1yA9+SmABzpr2L/HaNWw+WkYQbvu9ik= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:reply-to:to:cc:date:in-reply-to :references:content-type:mime-version; s=default; bh=fWtx/kNQc3K Ugf5GYF5UsOE10JA=; b=D6iwI89O5RFwMZCBNa5urdYG2HSXfsAvt8qKoeoRMnw oRfroCRF4JrZzhdftThXrJmHu7qMJS2SvY1cWv6yMcY8ILceIRJkIcodJQdtfh6Z qTpCP6cMoIvsvl0qxk4rEFjKww4X+Hn/s312/T/8gqcK1pnoha8g7K7BZ/pkpZ2U = Received: (qmail 27451 invoked by alias); 7 May 2014 08:18:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27440 invoked by uid 89); 7 May 2014 08:18:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f170.google.com Received: from mail-lb0-f170.google.com (HELO mail-lb0-f170.google.com) (209.85.217.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 07 May 2014 08:18:19 +0000 Received: by mail-lb0-f170.google.com with SMTP id w7so830778lbi.29 for ; Wed, 07 May 2014 01:18:15 -0700 (PDT) X-Received: by 10.112.118.20 with SMTP id ki20mr1790645lbb.45.1399450695621; Wed, 07 May 2014 01:18:15 -0700 (PDT) Received: from [192.168.1.4] (178-78-231-178.customers.ownit.se. [178.78.231.178]) by mx.google.com with ESMTPSA id eo12sm16354295lbb.13.2014.05.07.01.18.14 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 07 May 2014 01:18:14 -0700 (PDT) Message-ID: <1399450727.13092.106.camel@G3620.my.own.domain> Subject: patch1.diff updated + test results Was: Re: GCC's -fsplit-stack disturbing Mach's vm_allocate From: Svante Signell Reply-To: svante.signell@gmail.com To: Samuel Thibault Cc: Thomas Schwinge , Ian Lance Taylor , gcc-patches@gcc.gnu.org, bug-hurd@gnu.org, Roland McGrath Date: Wed, 07 May 2014 10:18:47 +0200 In-Reply-To: <20140506132605.GD1010@type.bordeaux.inria.fr> References: <1399018692.8487.7.camel@PackardBell-PC> <20140502095753.GC6577@type> <20140502100027.GD6577@type> <1399027556.8487.12.camel@PackardBell-PC> <20140502105234.GM6577@type> <1399363609.13092.29.camel@G3620.my.own.domain> <20140506125157.GH5788@type.bordeaux.inria.fr> <1399381520.13092.67.camel@G3620.my.own.domain> <20140506130755.GL5788@type.bordeaux.inria.fr> <1399382738.13092.70.camel@G3620.my.own.domain> <20140506132605.GD1010@type.bordeaux.inria.fr> Mime-Version: 1.0 On Tue, 2014-05-06 at 15:26 +0200, Samuel Thibault wrote: > Svante Signell, le Tue 06 May 2014 15:25:38 +0200, a écrit : > > On Tue, 2014-05-06 at 15:07 +0200, Samuel Thibault wrote: > > > Svante Signell, le Tue 06 May 2014 15:05:20 +0200, a écrit : > > > > On Tue, 2014-05-06 at 14:51 +0200, Samuel Thibault wrote: > > > > > Just to explicitly ask for it: > > > > > > > > > > Svante Signell, le Tue 06 May 2014 10:06:49 +0200, a écrit : > > > > > > For some (yet) unknown reason all libgo tests fails with a segfault when > > > > > > run in the build tree: make, sh or something else, the test commands are > > > > > > rather hard to track. > > > > > > > > > > Doesn't that dump a core? Do you have /servers/crash properly pointing > > > > > to /servers/crash-dump-core and ulimit -u set to unlimited? More good news: - Installing the modified libpthread.so.0.3 made the segfault go away. I could now run the check from the build tree :-) - Adding #define TARGET_THREAD_SSP_OFFSET 0x14 to patch1.diff and building gcc-4.9.0-2 the test results are summarised as follows :-) === libgo Summary === # of expected passes 101 # of unexpected failures 21 I think some of the remaining failures are rather easy to fix. Attached is an updated patch1.diff. Remains to solve the problem with patch8.diff: Adding arch specific code to: src/libgo/mksysinfo.sh --- a/src/gcc/config/i386/gnu.h +++ b/src/gcc/config/i386/gnu.h @@ -37,11 +37,14 @@ #ifdef TARGET_LIBC_PROVIDES_SSP -/* Not supported yet. */ -# undef TARGET_THREAD_SSP_OFFSET - -/* Not supported yet. */ -# undef TARGET_CAN_SPLIT_STACK -# undef TARGET_THREAD_SPLIT_STACK_OFFSET +/* i386 glibc provides __stack_chk_guard in %gs:0x14. */ +#define TARGET_THREAD_SSP_OFFSET 0x14 +/* We only build the -fsplit-stack support in libgcc if the + assembler has full support for the CFI directives. */ +#if HAVE_GAS_CFI_PERSONALITY_DIRECTIVE +#define TARGET_CAN_SPLIT_STACK +#endif +/* We steal the last transactional memory word. */ +#define TARGET_THREAD_SPLIT_STACK_OFFSET 0x30 #endif