From patchwork Thu May 10 17:20:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Schmidt X-Patchwork-Id: 158349 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 1157EB6EE7 for ; Fri, 11 May 2012 03:21:07 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1337275269; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:Message-ID:Subject:From:To: Cc:Date:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:Mime-Version:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=AtqUSVVTBIm7BGwL6Dzh6LJnvik=; b=FecN5Ubx8KA+Aex D2sGwn27byP098xpYNmEL+Lav1gOB5B5QXHRVd2xpsq5s8Olhgz230HcmjYg3bfd R1bibIuxPpgtTZVMU4K0dS+B8PGjsWEplvlqw5GP6QT1uBE82xKWFnTxeHU0cP5v jlV37nCGmA8lhlLxVzZ3S/PIAadc= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:Received:Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Mime-Version:X-Content-Scanned:x-cbid:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=QS9frkOEsh5PLpsVGpEBXb8WxuVwi3ONDodjPVxCq/5BlWWV6NHiPzR+T75tis 4qNGIn+erOtsiDuBD+6TwodtTCErGXor6KuDboJIHV+IFi/ziDHW3JQfoecaxn6V 7ZVGh24NWZCdx3NJqh0ap3OFhrs0WiGH/FV1zjkZhMTIk=; Received: (qmail 9596 invoked by alias); 10 May 2012 17:21:00 -0000 Received: (qmail 9555 invoked by uid 22791); 10 May 2012 17:20:59 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e9.ny.us.ibm.com (HELO e9.ny.us.ibm.com) (32.97.182.139) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 May 2012 17:20:46 +0000 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 May 2012 13:20:44 -0400 Received: from d01dlp02.pok.ibm.com (9.56.224.85) by e9.ny.us.ibm.com (192.168.1.109) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 10 May 2012 13:20:41 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id BE3866E805F for ; Thu, 10 May 2012 13:20:40 -0400 (EDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4AHKdUf085540 for ; Thu, 10 May 2012 13:20:39 -0400 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4AHKZGt032573 for ; Thu, 10 May 2012 11:20:36 -0600 Received: from [9.80.52.106] ([9.80.52.106]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q4AHKWVE032468; Thu, 10 May 2012 11:20:33 -0600 Message-ID: <1336670437.11473.38.camel@gnopaine> Subject: Re: [PATCH, 4.7] Backport fix to [un]signed_type_for From: "William J. Schmidt" To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de, bergner@vnet.ibm.com Date: Thu, 10 May 2012 12:20:37 -0500 In-Reply-To: <20120510164952.GW16117@tyan-ft48-01.lab.bos.redhat.com> References: <1336668267.4707.6.camel@oc2474580526.ibm.com> <20120510164952.GW16117@tyan-ft48-01.lab.bos.redhat.com> Mime-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12051017-7182-0000-0000-0000017BCE8D Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, 2012-05-10 at 18:49 +0200, Jakub Jelinek wrote: > On Thu, May 10, 2012 at 11:44:27AM -0500, William J. Schmidt wrote: > > Backporting this patch to 4.7 fixes a problem building Fedora 17. > > Bootstrapped and regression tested on powerpc64-unknown-linux-gnu. Is > > the backport OK? > > For 4.7 I'd very much prefer a less intrusive change (i.e. change > the java langhook) instead, but I'll defer to Richard if he prefers > this over that. OK. If that's desired, this is the possible change to the langhook: which also fixed the problem and bootstraps without regressions. Whichever you guys prefer is fine with me. Thanks, Bill > > > 2012-05-10 Bill Schmidt > > > > Backport from trunk: > > 2012-03-12 Richard Guenther > > > > * tree.c (signed_or_unsigned_type_for): Use > > build_nonstandard_integer_type. > > (signed_type_for): Adjust documentation. > > (unsigned_type_for): Likewise. > > * tree-pretty-print.c (dump_generic_node): Use standard names > > for non-standard integer types if available. > > Jakub > Index: gcc/java/typeck.c =================================================================== --- gcc/java/typeck.c (revision 187158) +++ gcc/java/typeck.c (working copy) @@ -189,6 +189,12 @@ java_type_for_size (unsigned bits, int unsignedp) return unsignedp ? unsigned_int_type_node : int_type_node; if (bits <= TYPE_PRECISION (long_type_node)) return unsignedp ? unsigned_long_type_node : long_type_node; + /* A 64-bit target with TImode requires 128-bit type definitions + for bitsizetype. */ + if (int128_integer_type_node + && bits == TYPE_PRECISION (int128_integer_type_node)) + return (unsignedp ? int128_unsigned_type_node + : int128_integer_type_node); return 0; }