From patchwork Thu Apr 5 02:56:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Schmidt X-Patchwork-Id: 150843 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A2B78B6FF7 for ; Thu, 5 Apr 2012 12:56:50 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1334199410; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:Message-ID:Subject:From:To: Cc:Date:Content-Type:Content-Transfer-Encoding:Mime-Version: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=lYIfQtWvT9nR7X6YljqG a2FrTm8=; b=URB2M0gUTFYZIzap3EZ3Rs1plRgaRF/gCF1FJs9b7izp0zoM4SZh 2yJYYtynrDWAfyMdW7X6KQSBGnXcKc3yXLNXyKUaH3pdcoTCjfN7dSFyjjU6Q1Xf kxeSAalxR8xlabZjBgKF9zCTZMy5WQRyyIrd0TAhiY5mv7R0Ifl8jHo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:Received:Message-ID:Subject:From:To:Cc:Date:Content-Type:Content-Transfer-Encoding:Mime-Version:X-Content-Scanned:x-cbid:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=LhTOUciCVX8M+S8GwmoZzPwLwa7uYp6s6GdhphJkn1h5CnUSvTL+kQK11Q0sPK 0w7JKl/Zsh0AVK58ABWmtZ/42984H9Ewj2tOA55V71e8nAl48uANVOKOT6FTip8M 3Ak4Vh4g4PGnebDOwnseAsTzKi4Cf/z9R6aI2ovg9nA7U=; Received: (qmail 26550 invoked by alias); 5 Apr 2012 02:56:46 -0000 Received: (qmail 26537 invoked by uid 22791); 5 Apr 2012 02:56:45 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e37.co.us.ibm.com (HELO e37.co.us.ibm.com) (32.97.110.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Apr 2012 02:56:32 +0000 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Apr 2012 20:56:31 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 4 Apr 2012 20:56:29 -0600 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 6B7B83E40036 for ; Wed, 4 Apr 2012 20:56:28 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q352uSu0190280 for ; Wed, 4 Apr 2012 20:56:28 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q352uRl2026375 for ; Wed, 4 Apr 2012 20:56:27 -0600 Received: from [9.49.138.10] (sig-9-49-138-10.mts.ibm.com [9.49.138.10]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q352uRhR026342; Wed, 4 Apr 2012 20:56:27 -0600 Message-ID: <1333594591.19102.40.camel@gnopaine> Subject: [PATCH] Fix PR52614 From: "William J. Schmidt" To: gcc-patches@gcc.gnu.org Cc: bergner@vnet.ibm.com Date: Wed, 04 Apr 2012 21:56:31 -0500 Mime-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12040502-7408-0000-0000-000003FB77E8 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org There seems to be tacit agreement that the vector tests should use -fno-common on all targets to avoid the recent spate of failures (see discussion in 52571 and 52603). This patch (proposed by Dominique D'Humieures) does just that. I agreed to shepherd the patch through. I've verified that it removes the failures for powerpc64-linux. Various others have verified for arm, sparc, and darwin. OK for trunk? Thanks, Bill gcc/testsuite: 2012-04-04 Bill Schmidt Dominique D'Humieures PR testsuite/52614 * gcc.dg/vect/vect.exp: Use -fno-common on all targets. * gcc.dg/vect/costmodel/ppc/ppc-costmodel-vect.exp: Likewise. Index: gcc/testsuite/gcc.dg/vect/costmodel/ppc/ppc-costmodel-vect.exp =================================================================== --- gcc/testsuite/gcc.dg/vect/costmodel/ppc/ppc-costmodel-vect.exp (revision 186108) +++ gcc/testsuite/gcc.dg/vect/costmodel/ppc/ppc-costmodel-vect.exp (working copy) @@ -34,7 +34,7 @@ if ![is-effective-target powerpc_altivec_ok] { set DEFAULT_VECTCFLAGS "" # These flags are used for all targets. -lappend DEFAULT_VECTCFLAGS "-O2" "-ftree-vectorize" "-fvect-cost-model" +lappend DEFAULT_VECTCFLAGS "-O2" "-ftree-vectorize" "-fvect-cost-model" "-fno-common" # If the target system supports vector instructions, the default action # for a test is 'run', otherwise it's 'compile'. Save current default. Index: gcc/testsuite/gcc.dg/vect/vect.exp =================================================================== --- gcc/testsuite/gcc.dg/vect/vect.exp (revision 186108) +++ gcc/testsuite/gcc.dg/vect/vect.exp (working copy) @@ -40,7 +40,7 @@ if ![check_vect_support_and_set_flags] { } # These flags are used for all targets. -lappend DEFAULT_VECTCFLAGS "-ftree-vectorize" "-fno-vect-cost-model" +lappend DEFAULT_VECTCFLAGS "-ftree-vectorize" "-fno-vect-cost-model" "-fno-common" # Initialize `dg'. dg-init