From patchwork Fri Feb 18 13:26:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Pero X-Patchwork-Id: 83590 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3F08FB70ED for ; Sat, 19 Feb 2011 00:26:37 +1100 (EST) Received: (qmail 31119 invoked by alias); 18 Feb 2011 13:26:18 -0000 Received: (qmail 31106 invoked by uid 22791); 18 Feb 2011 13:26:17 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 13:26:15 +0000 Received: from eggs.gnu.org ([140.186.70.92]:59444) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1PqQLd-0002z7-Gh for gcc-patches@gnu.org; Fri, 18 Feb 2011 08:26:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PqQLb-00019g-Gi for gcc-patches@gnu.org; Fri, 18 Feb 2011 08:26:12 -0500 Received: from smtp111.iad.emailsrvr.com ([207.97.245.111]:49536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PqQLb-00019Z-B8 for gcc-patches@gnu.org; Fri, 18 Feb 2011 08:26:11 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp41.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 7D8BE291507; Fri, 18 Feb 2011 08:26:10 -0500 (EST) Received: from dynamic5.wm-web.iad.mlsrvr.com (dynamic5.wm-web.iad1a.rsapps.net [192.168.2.146]) by smtp41.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 23E3329148B; Fri, 18 Feb 2011 08:26:10 -0500 (EST) Received: from meta-innovation.com (localhost [127.0.0.1]) by dynamic5.wm-web.iad.mlsrvr.com (Postfix) with ESMTP id 0A7EA8D0A86; Fri, 18 Feb 2011 08:26:10 -0500 (EST) Received: by www2.webmail.us (Authenticated sender: nicola.pero@meta-innovation.com, from: nicola.pero@meta-innovation.com) with HTTP; Fri, 18 Feb 2011 14:26:10 +0100 (CET) Date: Fri, 18 Feb 2011 14:26:10 +0100 (CET) Subject: Re: PATCH committed: 64-bit Apple Objective-C runtime support From: "Nicola Pero" To: "Jack Howarth" Cc: "Mike Stump" , gcc-patches@gnu.org, "GCC Development" MIME-Version: 1.0 X-Type: plain In-Reply-To: <20110218131055.GA22038@bromo.med.uc.edu> References: <1297987740.839215263@192.168.4.58> <2D7B48F6-1BAB-474A-8142-FCF5A3637C6E@comcast.net> <20110218131055.GA22038@bromo.med.uc.edu> Message-ID: <1298035570.039823109@192.168.4.58> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 207.97.245.111 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Jack, thanks for testing this out. You can xfail these. Iain sent me this morning an additional patch that xfails these; he must have forgotten to include it in the original one. I'll attach it. I can't commit now; if Mike or you have time, please do. I understand that the patch is pre-approved by Mike. Else, I'll commit it myself tonight (GMT). Apologies for the temporary noise on the m64 testsuite on Darwin. Thanks -----Original Message----- From: "Jack Howarth" Sent: Friday, 18 February, 2011 14:10 To: "Mike Stump" Cc: gcc-patches@gnu.org, "GCC Development" Subject: Re: PATCH committed: 64-bit Apple Objective-C runtime support On Thu, Feb 17, 2011 at 06:21:17PM -0800, Mike Stump wrote: > On Feb 17, 2011, at 4:09 PM, Nicola Pero wrote: > > This patch is not me - it's by Iain Sandoe. :-) > > Thanks for chipping in and helping out. I'm excited at having a Objective-C compiler that works again on darwin. > > That said, if people have any Objective-C codes, feel free to beat on them and let us know what you find. We're interested in regressions first and foremost, after that functionality on 64-bit darwin. We know about PCH not working well in some situations, so, be prepared to turn that off. Did Iain see these failures in his testing at -m64? FAIL: objc/execute/exceptions/foward-1.m execution, -O0 -fnext-runtime FAIL: objc/execute/exceptions/foward-1.m execution, -O1 -fnext-runtime FAIL: objc/execute/exceptions/foward-1.m execution, -O2 -fnext-runtime FAIL: objc/execute/exceptions/foward-1.m execution, -O3 -fomit-frame-pointer -fnext-runtime FAIL: objc/execute/exceptions/foward-1.m execution, -O3 -fomit-frame-pointer -funroll-loops -fnext-runtime FAIL: objc/execute/exceptions/foward-1.m execution, -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions -fnext-runtime FAIL: objc/execute/exceptions/foward-1.m execution, -O3 -g -fnext-runtime FAIL: objc/execute/exceptions/foward-1.m execution, -Os -fnext-runtime I am seeing those on x86_64-apple-darwin10. Jack Index: gcc/testsuite/objc/execute/exceptions/foward-1.x =================================================================== --- gcc/testsuite/objc/execute/exceptions/foward-1.x (revision 0) +++ gcc/testsuite/objc/execute/exceptions/foward-1.x (revision 0) @@ -0,0 +1,11 @@ +# XFAIL the run for m64 Darwin NeXT (seems to be a system runtime lib problem). +if { [istarget *-*-darwin*] && [check_effective_target_lp64] } { + set torture_eval_before_execute { + global compiler_conditional_xfail_data + set compiler_conditional_xfail_data { + "Target fails for fnext-runtime" "*-*-*" { "-fnext-runtime" } { "" } + } + } +} +# carry on... +return false