From patchwork Mon Aug 2 20:20:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Pop X-Patchwork-Id: 60630 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B5D27B70B8 for ; Tue, 3 Aug 2010 06:26:33 +1000 (EST) Received: (qmail 30030 invoked by alias); 2 Aug 2010 20:23:25 -0000 Received: (qmail 29957 invoked by uid 22791); 2 Aug 2010 20:23:24 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SARE_SUB_OBFU_Z, TW_SV, T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-gw0-f47.google.com (HELO mail-gw0-f47.google.com) (74.125.83.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Aug 2010 20:23:19 +0000 Received: by gwb15 with SMTP id 15so1552804gwb.20 for ; Mon, 02 Aug 2010 13:23:17 -0700 (PDT) Received: by 10.150.61.12 with SMTP id j12mr7592423yba.131.1280780597602; Mon, 02 Aug 2010 13:23:17 -0700 (PDT) Received: from napoca (cpe-70-120-196-107.austin.res.rr.com [70.120.196.107]) by mx.google.com with ESMTPS id q31sm5733822ybk.1.2010.08.02.13.23.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 02 Aug 2010 13:23:17 -0700 (PDT) Received: by napoca (sSMTP sendmail emulation); Mon, 02 Aug 2010 15:23:14 -0500 From: Sebastian Pop To: gcc-patches@gcc.gnu.org Cc: Tobias Grosser , gcc-graphite Subject: [PATCH 33/65] Fix flipped condition using mpz_sgn. Date: Mon, 2 Aug 2010 15:20:06 -0500 Message-Id: <1280780438-17543-34-git-send-email-sebpop@gmail.com> In-Reply-To: <1280780438-17543-1-git-send-email-sebpop@gmail.com> References: <1280780438-17543-1-git-send-email-sebpop@gmail.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org From: grosser 2010-07-15 Andreas Simbuerger * graphite-cloog-util.c (cloog_matrix_to_ppl_constraint): Fix flipped condition. * graphite-poly.c (psct_scattering_dim_for_loop_depth): Same. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/graphite@162207 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 7 +++++++ gcc/ChangeLog.graphite | 7 +++++++ gcc/graphite-cloog-util.c | 2 +- gcc/graphite-poly.c | 2 +- 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index b0f30f1..c93abbf 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,12 @@ 2010-08-02 Andreas Simbuerger + * graphite-cloog-util.c + (cloog_matrix_to_ppl_constraint): Fix flipped condition. + * graphite-poly.c + (psct_scattering_dim_for_loop_depth): Same. + +2010-08-02 Andreas Simbuerger + * graphite-cloog-util.h: Added cloog.h. * graphite-blocking.c: Removed cloog.h. * graphite-dependences.c: Same. diff --git a/gcc/ChangeLog.graphite b/gcc/ChangeLog.graphite index fa59c75..806d67e 100644 --- a/gcc/ChangeLog.graphite +++ b/gcc/ChangeLog.graphite @@ -1,3 +1,10 @@ +2010-07-15 Andreas Simbuerger + + * graphite-cloog-util.c + (cloog_matrix_to_ppl_constraint): Fix flipped condition. + * graphite-poly.c + (psct_scattering_dim_for_loop_depth): Same. + 2010-07-07 Sebastian Pop * gfortran.dg/graphite/id-20.f: New. diff --git a/gcc/graphite-cloog-util.c b/gcc/graphite-cloog-util.c index 21a7872..33ee5cf 100644 --- a/gcc/graphite-cloog-util.c +++ b/gcc/graphite-cloog-util.c @@ -187,7 +187,7 @@ cloog_matrix_to_ppl_constraint (CloogMatrix *matrix, int row) ppl_Linear_Expression_add_to_inhomogeneous (expr, coef); ppl_delete_Coefficient (coef); - if (mpz_sgn (matrix->p[row][0])) + if (mpz_sgn (matrix->p[row][0]) == 0) ppl_new_Constraint (&cstr, expr, PPL_CONSTRAINT_TYPE_EQUAL); else ppl_new_Constraint (&cstr, expr, PPL_CONSTRAINT_TYPE_GREATER_OR_EQUAL); diff --git a/gcc/graphite-poly.c b/gcc/graphite-poly.c index 67b9384..7d33aa8 100644 --- a/gcc/graphite-poly.c +++ b/gcc/graphite-poly.c @@ -1018,7 +1018,7 @@ psct_scattering_dim_for_loop_depth (poly_bb_p pbb, graphite_dim_t loop_depth) ppl_Linear_Expression_coefficient (expr, iter, coef); ppl_Coefficient_to_mpz_t (coef, val); - if (mpz_sgn (val)) + if (mpz_sgn (val) == 0) { ppl_delete_Linear_Expression (expr); continue;