From patchwork Sat Jul 10 05:30:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 58461 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4280CB6F0C for ; Sat, 10 Jul 2010 15:31:07 +1000 (EST) Received: (qmail 26605 invoked by alias); 10 Jul 2010 05:31:05 -0000 Received: (qmail 26592 invoked by uid 22791); 10 Jul 2010 05:31:04 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-fx0-f47.google.com (HELO mail-fx0-f47.google.com) (209.85.161.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Jul 2010 05:30:59 +0000 Received: by fxm12 with SMTP id 12so1872458fxm.20 for ; Fri, 09 Jul 2010 22:30:56 -0700 (PDT) Received: by 10.223.117.9 with SMTP id o9mr9138650faq.54.1278739856553; Fri, 09 Jul 2010 22:30:56 -0700 (PDT) Received: from [93.103.18.160] (93-103-18-160.static.t-2.net [93.103.18.160]) by mx.google.com with ESMTPS id 24sm3501889far.12.2010.07.09.22.30.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Jul 2010 22:30:54 -0700 (PDT) Subject: Re: [PATCH, i386]: Correct HAVE_AS_IX86_REP_LOCK_PREFIX configure test for Darwin From: Uros Bizjak To: Mike Stump Cc: gcc-patches@gcc.gnu.org, IainS In-Reply-To: References: Date: Sat, 10 Jul 2010 07:30:53 +0200 Message-ID: <1278739853.2459.0.camel@localhost> Mime-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Fri, 2010-07-09 at 16:50 -0700, Mike Stump wrote: > On Jul 9, 2010, at 9:08 AM, Uros Bizjak wrote: > > Attached patch fixes HAVE_AS_IX86_REP_LOCK_PREFIX configure test for > > Darwin and removes special handling from output_operand. > > ENOPATCH? Attached. Uros. --- trunk/gcc/configure.ac 2010/07/09 15:01:14 162000 +++ trunk/gcc/configure.ac 2010/07/09 16:02:58 162001 @@ -3327,6 +3327,7 @@ gcc_GAS_CHECK_FEATURE([rep and lock prefix], gcc_cv_as_ix86_rep_lock_prefix,,, [rep movsl + lock addl %edi, (%eax,%esi) lock orl $0, (%esp)]) AC_DEFINE_UNQUOTED(HAVE_AS_IX86_REP_LOCK_PREFIX, [`if test $gcc_cv_as_ix86_rep_lock_prefix = yes; then echo 1; else echo 0; fi`], --- trunk/gcc/configure 2010/07/09 15:01:14 162000 +++ trunk/gcc/configure 2010/07/09 16:02:58 162001 @@ -23337,6 +23337,7 @@ gcc_cv_as_ix86_rep_lock_prefix=no if test x$gcc_cv_as != x; then echo 'rep movsl + lock addl %edi, (%eax,%esi) lock orl $0, (%esp)' > conftest.s if { ac_try='$gcc_cv_as $gcc_cv_as_flags -o conftest.o conftest.s >&5' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 --- trunk/gcc/config/i386/i386.c 2010/07/09 15:01:14 162000 +++ trunk/gcc/config/i386/i386.c 2010/07/09 16:02:58 162001 @@ -12651,7 +12651,7 @@ return; case ';': -#if TARGET_MACHO || !HAVE_AS_IX86_REP_LOCK_PREFIX +#ifndef HAVE_AS_IX86_REP_LOCK_PREFIX fputs (";", file); #endif return;