From patchwork Fri Sep 30 14:31:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Sidwell X-Patchwork-Id: 677059 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3slv5s1vVYz9s4x for ; Sat, 1 Oct 2016 00:32:00 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=UgjaNsyj; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=vHlGAFzObXQNdjJeNIaVbYwzl5tQrio03YyzSen9/djM2nFb0J GZ3DVQzBRkG5/uX4IzX4kgta1ykWZH7sqoI0Rzwmglwgx/hgQTqRlmvr/1tvD/B3 L/it8BDZeIiC+GulHwtcY2PQdsUiDG5gulFPTuIsqr4NUHBslExJLvmyc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=8BUKRp+g/ciPbXNHssZgxs1d5Ws=; b=UgjaNsyjkdaImex9eNaS adKgLqL6TlIZj9Lmh3SnAZyDx90PRInbGCbrfYMbhf0nGRh2PB5Bm0LWjAA0zmvm QxOZSNTh4FiAk9EjhVhpMPerd3RMIccxnSOBzKN17k5E4WUaEei7Qa4sJXc2LlAx 6hTTLPr8BWqPh23CdG/53Dw= Received: (qmail 14121 invoked by alias); 30 Sep 2016 14:31:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 14101 invoked by uid 89); 30 Sep 2016 14:31:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS, URIBL_RED autolearn=no version=3.3.2 spammy=tiles, nathancodesourcerycom, nathan@codesourcery.com, sk:nathan X-HELO: mail-qk0-f178.google.com Received: from mail-qk0-f178.google.com (HELO mail-qk0-f178.google.com) (209.85.220.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Sep 2016 14:31:40 +0000 Received: by mail-qk0-f178.google.com with SMTP id z190so108192023qkc.3 for ; Fri, 30 Sep 2016 07:31:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version; bh=p2Y3sxa3cmaVFHWmZZLDlh68JfRyd3N8UDA8UtPW0w4=; b=R7FOdchrsv5Am7MZ1aJJsWNRBqCTOMS62i346TAgwP4NdCKVMiybSqCJiPHUl9/Okn ZUXcyy8u8EsD8RJKduy5nOtLX1GdWAU0yCF4sHyv4tKVO4uWeE93HkEkmb7UGHKQYi8h Ez0lle+fQOsrlN84f6Wp1LMNDE2Fwzl79p+Y/M7/Cp6kOD0Y/gqmUogwzfqDkI0rLMxc egCijeRlKzDSQIJhAvynGqWDu0QZ19gK258oLLU5TQGA8HapIaUxclMlS7SnpXnNCyR2 qRkBdL88cO8y2/2QOVAU8ZaaS9UsvorzUvNkaxuuExXoxZL08JIhUdDTunKR2FQTCJXQ 558Q== X-Gm-Message-State: AA6/9Rkz+VdZmeHJux1xVpVKPKgCX9Z9xi6Wwg6V1t6yk+ZatbD8XxXv/Cn30y6xU8DKnA== X-Received: by 10.55.116.134 with SMTP id p128mr7110388qkc.38.1475245898837; Fri, 30 Sep 2016 07:31:38 -0700 (PDT) Received: from ?IPv6:2601:181:c003:1930:3fe6:c217:b86a:6e86? ([2601:181:c003:1930:3fe6:c217:b86a:6e86]) by smtp.googlemail.com with ESMTPSA id b94sm1944463qkb.5.2016.09.30.07.31.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Sep 2016 07:31:38 -0700 (PDT) To: GCC Patches From: Nathan Sidwell Subject: [gomp4] remove some tile tests Message-ID: <04c29701-f193-0a0b-97f1-f192bb501126@acm.org> Date: Fri, 30 Sep 2016 10:31:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In implementing tile I discovered two existing runtime tile tests. These were only passing because tile was completely ignored. One of them exposes a latent bug in collapse, in my WIP, but I don't want to get distracted by that right now. Better to have tile tests test tile tiles. nathan 2016-09-30 Nathan Sidwell * testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.c: Remove tile test. * testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.h: Likewise. * testsuite/libgomp.oacc-fortran/kernels-loop-1.f90: Likewise. Index: testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.c =================================================================== --- testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.c (revision 240654) +++ testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.c (working copy) @@ -29,12 +29,10 @@ main () || test_none_auto () || test_none_independent () || test_none_seq () - || test_none_tile () || test_gangs_none () || test_gangs_auto () || test_gangs_independent () - || test_gangs_seq () - || test_gangs_tile ()) + || test_gangs_seq ()) abort (); return 0; } Index: testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.h =================================================================== --- testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.h (revision 240654) +++ testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.h (working copy) @@ -18,8 +18,3 @@ #include "parallel-loop-2.h" #undef S #undef N -#define S tile(*) -#define N(x) M(x, G, tile) -#include "parallel-loop-2.h" -#undef S -#undef N Index: testsuite/libgomp.oacc-fortran/kernels-loop-1.f90 =================================================================== --- testsuite/libgomp.oacc-fortran/kernels-loop-1.f90 (revision 240654) +++ testsuite/libgomp.oacc-fortran/kernels-loop-1.f90 (working copy) @@ -54,17 +54,6 @@ program loops call check (a, b, n) - ! PRESENT_OR_COPY - - !$acc kernels pcopy (a) - !$acc loop tile (*) - do i = 1, n - a(i) = i - end do - !$acc end kernels - - call check (a, b, n) - end program loops subroutine check (a, b, n)