Message ID | 03ab905d-d364-a3df-860e-94b47bba3910@acm.org |
---|---|
State | New |
Headers | show
Return-Path: <gcc-patches-return-438606-incoming=patchwork.ozlabs.org@gcc.gnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3swPbl5GrQz9ryr for <incoming@patchwork.ozlabs.org>; Fri, 14 Oct 2016 21:53:54 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=E63gw5yt; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=kWLm2d3w5PqTpLAnm UpnSHPEYbOWKroNex5CnlybnthTnAhzIMt2M0JjIeIbj7eUuPir1wplzkNEMYlrE 4w4ryW7fYEvzUek/QbfQ+a+AOaEvBCh4WU5syIgZtrlGibvesIFXgeF8YcbxMcQz WgZB1/psbUPtkV3dNyT1Te1qfA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=Kwo1khK7k2A7AfKy6LJtoeS Fxl4=; b=E63gw5yt1g96ZHuF9rEyFPbOcPJ6KqhB9cL9/ZniS3zhSz4LiL8qDkI 0sz6WEGG+TbuXB1KpLvjCr4uK7rv2YzejWtksz4PQPDc8bjD2el/uRvBnMG/LbJn Hu1THcwUTzfEP6e0uXvomoJa2gkh9QrDGR1zF6K+AN5wn/2F7BT4= Received: (qmail 56779 invoked by alias); 14 Oct 2016 10:53:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: <gcc-patches.gcc.gnu.org> List-Unsubscribe: <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org> List-Archive: <http://gcc.gnu.org/ml/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-help@gcc.gnu.org> Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 56728 invoked by uid 89); 14 Oct 2016 10:53:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=jenkins, 1277, 127, 7, darn X-HELO: mail-qk0-f169.google.com Received: from mail-qk0-f169.google.com (HELO mail-qk0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Oct 2016 10:52:52 +0000 Received: by mail-qk0-f169.google.com with SMTP id n189so140836525qke.0 for <gcc-patches@gcc.gnu.org>; Fri, 14 Oct 2016 03:52:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to; bh=7GOWT2F71Ac2K468ki2Ay3CJ5zEhJsquRG1mHkROPMY=; b=VNBctPWJcNLna9ws7jnDxez1uZI7LI6O11VIoTCI1Cu2YI2runzLpvOQXvTgnTx8ra LD8/n7APr7o6bTQkJ0Vd4f3Roy267pvzHC2gtFNSMKXKaaYmlyl/01VxBFw8DE2v70Es 2fbxnBQMDi+Ia+whRrvWvEa6GV4O6DTtBZI0O2aQ6COc5VINdBCiDWL9bYAmv75zR/PB riGIJLN/mpu9S92jkmmrCUmq/wxG5RjWmfxLz7wf1DI3vyIcbOMFuQ1yCWDjKs72M03n +ha4MfGv63hly2Qkwir1HAZIBg8Qh8FASig6PvDt6MVzWsGLAfdV+5UyAcBJVs7zeUmV kmuA== X-Gm-Message-State: AA6/9RnfE21cgUNkcr2J8JUaqpZgXEUxPP6VdSfbc8T1E3j0lIa/SYMvHufTyrWppVOwNQ== X-Received: by 10.55.7.210 with SMTP id 201mr13127620qkh.228.1476442371235; Fri, 14 Oct 2016 03:52:51 -0700 (PDT) Received: from ?IPv6:2601:181:c003:1930:eef4:bbff:fe2f:7216? ([2601:181:c003:1930:eef4:bbff:fe2f:7216]) by smtp.googlemail.com with ESMTPSA id v68sm7229869qkd.24.2016.10.14.03.52.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Oct 2016 03:52:50 -0700 (PDT) Subject: Re: Questionable code in gcov-io.c To: Andrew Pinski <pinskia@gmail.com> References: <20161012121001.GA27295@redhat.com> <5d4f3cdb-4698-f323-fe38-e2a80421034f@acm.org> <20161012134323.GC27295@redhat.com> <639591ca-c3ee-2c96-e185-78e04b869776@acm.org> <mvmk2ddtxpn.fsf@hawking.suse.de> <041f52bf-91e2-d98d-dcb5-d43635df7a55@acm.org> <CA+=Sn1=mVOaHM5VD7ZUV2jA0M4OpA45+YOJWRZ6pisDXOh4Bzw@mail.gmail.com> Cc: Andreas Schwab <schwab@suse.de>, Marek Polacek <polacek@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com> From: Nathan Sidwell <nathan@acm.org> Message-ID: <03ab905d-d364-a3df-860e-94b47bba3910@acm.org> Date: Fri, 14 Oct 2016 06:52:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <CA+=Sn1=mVOaHM5VD7ZUV2jA0M4OpA45+YOJWRZ6pisDXOh4Bzw@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------DBB7FE4B372D20A3CB0F35E0" |
2016-10-14 Nathan Sidwell <nathan@acm.org> * gcov-io.c (gcov_open): Deconstify 'mode'. Index: gcov-io.c =================================================================== --- gcov-io.c (revision 241153) +++ gcov-io.c (working copy) @@ -127,7 +127,7 @@ gcov_open (const char *name, int mode) #endif { #if IN_LIBGCOV - const int mode = 0; + int mode = 0; #endif #if GCOV_LOCKED struct flock s_flock;