Message ID | 022801da5206$69e5a4f0$3db0eed0$@nextmovesoftware.com |
---|---|
State | New |
Headers | show |
Series | [libatomic] PR other/113336: Fix libatomic testsuite regressions on ARM. | expand |
Though I'm not in a position to approve the patch, I'm happy to confirm the proposed changes look good to me. Thanks for the updated version, Victor On 1/28/24 16:24, Roger Sayle wrote: > > This patch is a revised version of the fix for PR other/113336. > > This patch has been tested on arm-linux-gnueabihf with --with-arch=armv6 > with make bootstrap and make -k check where it fixes all of the FAILs in > libatomic. Ok for mainline? > > > 2024-01-28 Roger Sayle <roger@nextmovesoftware.com> > Victor Do Nascimento <victor.donascimento@arm.com> > > libatomic/ChangeLog > PR other/113336 > * Makefile.am: Build tas_1_2_.o on ARCH_ARM_LINUX > * Makefile.in: Regenerate. > > Thanks in advance. > Roger > -- >
> -----Original Message----- > From: Victor Do Nascimento <victor.donascimento@arm.com> > Sent: Wednesday, February 14, 2024 5:06 PM > To: Roger Sayle <roger@nextmovesoftware.com>; gcc-patches@gcc.gnu.org; > Richard Earnshaw <Richard.Earnshaw@arm.com> > Subject: Re: [libatomic PATCH] PR other/113336: Fix libatomic testsuite > regressions on ARM. > > Though I'm not in a position to approve the patch, I'm happy to confirm > the proposed changes look good to me. > > Thanks for the updated version, > Victor > This is ok from me too. Thanks Victor for helping with the review. Kyrill > > On 1/28/24 16:24, Roger Sayle wrote: > > > > This patch is a revised version of the fix for PR other/113336. > > > > This patch has been tested on arm-linux-gnueabihf with --with-arch=armv6 > > with make bootstrap and make -k check where it fixes all of the FAILs in > > libatomic. Ok for mainline? > > > > > > 2024-01-28 Roger Sayle <roger@nextmovesoftware.com> > > Victor Do Nascimento <victor.donascimento@arm.com> > > > > libatomic/ChangeLog > > PR other/113336 > > * Makefile.am: Build tas_1_2_.o on ARCH_ARM_LINUX > > * Makefile.in: Regenerate. > > > > Thanks in advance. > > Roger > > -- > >
diff --git a/libatomic/Makefile.am b/libatomic/Makefile.am index cfad90124f9..eb04fa2fc60 100644 --- a/libatomic/Makefile.am +++ b/libatomic/Makefile.am @@ -139,6 +139,7 @@ if ARCH_ARM_LINUX IFUNC_OPTIONS = -march=armv7-a+fp -DHAVE_KERNEL64 libatomic_la_LIBADD += $(foreach s,$(SIZES),$(addsuffix _$(s)_1_.lo,$(SIZEOBJS))) libatomic_la_LIBADD += $(addsuffix _8_2_.lo,$(SIZEOBJS)) +libatomic_la_LIBADD += tas_1_2_.lo endif if ARCH_I386 IFUNC_OPTIONS = -march=i586