From patchwork Mon Aug 2 23:06:37 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Tytgat X-Patchwork-Id: 60691 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 21B251007D2 for ; Tue, 3 Aug 2010 09:01:35 +1000 (EST) Received: (qmail 29897 invoked by alias); 2 Aug 2010 23:01:33 -0000 Received: (qmail 29752 invoked by uid 22791); 2 Aug 2010 23:01:32 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, TW_YT X-Spam-Check-By: sourceware.org Received: from sif.is.scarlet.be (HELO sif.is.scarlet.be) (193.74.71.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Aug 2010 23:01:25 +0000 Received: from hobbes (ip-213-49-109-38.dsl.scarlet.be [213.49.109.38]) by sif.is.scarlet.be (8.14.2/8.14.2) with ESMTP id o72N1Jpx008113; Tue, 3 Aug 2010 01:01:20 +0200 Date: Tue, 03 Aug 2010 00:06:37 +0100 From: John Tytgat To: gcc-patches@gcc.gnu.org Cc: rearnsha@arm.com Subject: [PATCH, ARM]: Remove superfluous test in arm_override_options Message-ID: <0177b44051.Jo@hobbes.bass-software.com> X-Organization: BASS User-Agent: Messenger-Pro/2.62 (MsgServe/2.05) (RISC-OS/6.21) POPstar/2.05 MIME-Version: 1.0 X-DCC-scarlet.be-Metrics: sif 20001; Body=2 Fuz1=2 Fuz2=2 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org arm_override_options() unnecessarily tests twice on non-Thumb + interworking combination being selected. Also a small indentation fix can be done there. gcc/ John Tytgat * config/arm/arm.c (arm_override_options): Remove superfluous test. Fix indentation. Patch attached. Please check in after approval. John. Index: config/arm/arm.c =================================================================== --- config/arm/arm.c (revision 162830) +++ config/arm/arm.c (working copy) @@ -1527,7 +1527,7 @@ /* Callee super interworking implies thumb interworking. Adding this to the flags here simplifies the logic elsewhere. */ if (TARGET_THUMB && TARGET_CALLEE_INTERWORKING) - target_flags |= MASK_INTERWORK; + target_flags |= MASK_INTERWORK; /* TARGET_BACKTRACE calls leaf_function_p, which causes a crash if done from here where no function is being compiled currently. */ @@ -1537,9 +1537,6 @@ if (TARGET_ARM && TARGET_CALLEE_INTERWORKING) warning (0, "enabling callee interworking support is only meaningful when compiling for the Thumb"); - if (TARGET_ARM && TARGET_CALLER_INTERWORKING) - warning (0, "enabling caller interworking support is only meaningful when compiling for the Thumb"); - if (TARGET_APCS_STACK && !TARGET_APCS_FRAME) { warning (0, "-mapcs-stack-check incompatible with -mno-apcs-frame");