From patchwork Wed May 10 19:20:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 1779667 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nextmovesoftware.com header.i=@nextmovesoftware.com header.a=rsa-sha256 header.s=default header.b=l5YgqNPn; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QGlHk1sH5z214M for ; Thu, 11 May 2023 05:21:06 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 502CF3853548 for ; Wed, 10 May 2023 19:21:04 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 74146385703E for ; Wed, 10 May 2023 19:20:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74146385703E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kl260R1s8gr6AnP/+t30t/Uutx2BbxV98QxGepAt1BY=; b=l5YgqNPnNUYS+vygW6LN1DKMdE +wXiYLfCsmC0aX+QtT41Lctf+PAHHN2lhhh/F23/upx3oajov4DnxydJgvkM6tB9/g7V+mi3u38eU v37hIqtw0j8OF+NEehqZ53Fetqg6tGlkr6CvYHAWZArPXuFtRkshJ2XCxLPDrMS+zML0pmaGWCaa2 56t1+Ouarinq8QK6HLc2weFKsdsgkTfb1vJIdaLqzcB9E12ljSKq9bp9lqnt5xKKzw0eRuBrVHjkn X1rl3PndL8lCMEF22kjShUC1GOroral6jjpcXBF8rj3gOrIZiNIMQrXWjQLbFw3lZk0rVqf73GW5x hM3XY3Vg==; Received: from host86-169-41-81.range86-169.btcentralplus.com ([86.169.41.81]:49719 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pwpMP-0005n7-2i; Wed, 10 May 2023 15:20:26 -0400 From: "Roger Sayle" To: "'GCC Patches'" Cc: "'Uros Bizjak'" Subject: [x86_64 PATCH] Use [(const_int 0)] idiom consistently in i386.md Date: Wed, 10 May 2023 20:20:23 +0100 Message-ID: <000001d98374$7971dad0$6c559070$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdmDZZc7TjXldpnwT/y3sbB17Q/BhA== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MEDICAL_SUBJECT, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi Uros, This cleans up the use of [(clobber (const_int 0))] in the i386 backend. My apologies I must have copied this idiom from one of the other targets: aarch64.md, arm.md, thumb1.md, avr.md, or sparc.md. This patch has been tested on x86_64-pc-linux-gnu with make bootstrap and make -k check, both with and without --target_board=unix{-m32} with no new failures. Ok for mainline? 2023-05-10 Roger Sayle gcc/ChangeLog * config/i386/i386.md (*concat3_1): Use preferred [(const_int 0)] idiom, instead of [(clobber (const_int 0))]. (*concat3_2): Likewise. (*concat3_3): Likewise. (*concat3_4): Likewise. (*concat3_5): Likewise. (*concat3_6): Likewise. (*concat3_7): Likewise. Thanks, Roger diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index cf90867..f2dd67e 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -11584,7 +11584,7 @@ "INTVAL (operands[2]) == * BITS_PER_UNIT" "#" "&& reload_completed" - [(clobber (const_int 0))] + [(const_int 0)] { split_double_concat (mode, operands[0], operands[3], gen_lowpart (mode, operands[1])); @@ -11601,7 +11601,7 @@ "INTVAL (operands[3]) == * BITS_PER_UNIT" "#" "&& reload_completed" - [(clobber (const_int 0))] + [(const_int 0)] { split_double_concat (mode, operands[0], operands[1], gen_lowpart (mode, operands[2])); @@ -11620,7 +11620,7 @@ "INTVAL (operands[2]) == * BITS_PER_UNIT" "#" "&& reload_completed" - [(clobber (const_int 0))] + [(const_int 0)] { split_double_concat (mode, operands[0], operands[3], operands[1]); DONE; @@ -11638,7 +11638,7 @@ "INTVAL (operands[3]) == * BITS_PER_UNIT" "#" "&& reload_completed" - [(clobber (const_int 0))] + [(const_int 0)] { split_double_concat (mode, operands[0], operands[1], operands[2]); DONE; @@ -11665,7 +11665,7 @@ VOIDmode))" "#" "&& reload_completed" - [(clobber (const_int 0))] + [(const_int 0)] { rtx op3 = simplify_subreg (mode, operands[3], mode, 0); split_double_concat (mode, operands[0], op3, @@ -11697,7 +11697,7 @@ VOIDmode))" "#" "&& reload_completed" - [(clobber (const_int 0))] + [(const_int 0)] { rtx op3 = simplify_subreg (mode, operands[3], mode, 0); split_double_concat (mode, operands[0], op3, operands[1]); @@ -11723,7 +11723,7 @@ VOIDmode)" "#" "&& reload_completed" - [(clobber (const_int 0))] + [(const_int 0)] { rtx op2; if (mode == DImode)