From patchwork Tue Jun 29 14:50:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Brown X-Patchwork-Id: 1498392 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GDnVL0ccxz9sWG for ; Wed, 30 Jun 2021 00:51:20 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F049388C032 for ; Tue, 29 Jun 2021 14:51:18 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id D14223864813 for ; Tue, 29 Jun 2021 14:50:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D14223864813 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: M/GVGjMrgLAmCASdsr0jQ8nBQJwuem8Igl9axcuBdf6QPHJ6MYQVTK8MJMG/nmc7JVv0CRP3Q2 Qn5aDhruheKQpewWuEbkwD0vTlAqoxbMzv0BT2LXID30Zn3ihgse2qQ0+Cwn8340O0R2OQ/Dtr mWnwWuo6qQPvFTUaQXG4jDI6gcSGGYf78fBa+RVIt4/FkALVgp3zt9xAgbZQbRsbUGI0aCnao/ sTz7Fwl1oTq1bA2BMK5KWiOKzCd04PcKIG98I2vieYayzJqv6VfFOe6HeszlxtKIgSktY4uuP9 cUA= X-IronPort-AV: E=Sophos;i="5.83,309,1616486400"; d="scan'208";a="65377572" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 29 Jun 2021 06:50:52 -0800 IronPort-SDR: 9FQSorXBR3Yl/sxj5PUibhUkQPqNOY6F1/OY/F1IZ3UO+dKaFVFsyezXRyE81MyzVAUQfFhYEG 8pyxeDDzW7euDFKBqfXPVxfPWpF6Jr3vtsIFy9htKD+VllMXaHdtyCMqXI9FRjydgZfRNx9hF4 Bn6wxFxsfnF5ZEOnQyMhtWaZFnlMB2bPjb0sJd0z20Itft5s+vRB4Rl7jJQrNu7xonvjQAKY07 Um+yy73QHHPsD7iKzUVLC1Vxh5mDD26cC1iNeCj/kmMQ+cmAyFiwCTz6AUG0GwSkFL5VHarpGQ XAE= From: Julian Brown To: Subject: [PATCH 0/3] amdgcn: Integer multiplication improvements Date: Tue, 29 Jun 2021 07:50:37 -0700 Message-ID: X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Stubbs Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" These three patches replace the following one from the previously-posted series: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573161.html As suggested by Andrew Stubbs, I've changed the early lowering of DImode multiplication to a define_insn_and_split to keep the operation together until register-allocation time. This indeed seems to improve generated code. I also noticed that SImode multiplication can silently clobber SCC if the "s_mulk_i32" alternative is chosen, so I've done a drive-by fix for that too. Re-tested on GCN bare metal. Julian Julian Brown (3): amdgcn: Mark s_mulk_i32 as clobbering SCC amdgcn: Add [us]mulsi3_highpart SGPR alternatives amdgcn: Add [us]mulsid3/muldi3 patterns gcc/config/gcn/gcn.md | 161 +++++++++++++++++++++++++++++++++++++++--- 1 file changed, 153 insertions(+), 8 deletions(-)