From patchwork Thu Jun 4 13:40:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Brown X-Patchwork-Id: 1303551 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49d6PR589Bz9sSf for ; Thu, 4 Jun 2020 23:41:15 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 88A75388E817; Thu, 4 Jun 2020 13:41:13 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 5BC833840C33 for ; Thu, 4 Jun 2020 13:41:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5BC833840C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Julian_Brown@mentor.com IronPort-SDR: EEsN1WOmZFurzLrq1r0bhxTesg3ge1DAU8N0QNufQcj5g2Q+U7ZbIpGWKVXPmGktTvxFIdGuKx DkcOGMz9xUQYoSpW3FW/4eOJMENk2Yh5KD4XD+YwFyMhWm3FtCGkEp/KGN640rCo3PIltkBGy0 w3MFwQxyLkWnsPDgPJ0L3jHCjT7J++D80ZBq2B1GbdN/N142MKby8WWscPmZFvf2RCaewRGVfl v7A/Nmf4nZfWPZDRhZpJHws61Givc4CTd01GhnHqQJu8eCKi5rYlQFWl+QfQui7ngNr3mupbci TOw= X-IronPort-AV: E=Sophos;i="5.73,472,1583222400"; d="scan'208";a="49505640" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 04 Jun 2020 05:41:10 -0800 IronPort-SDR: Wq7opBfNTTLjxEtTW3XLI5nLWYmDv0LPdhIbD9ke3elmuF5aVEhOYyvNdwz0yZSOgc23s98jeR qEssxbx9JVfJ7A00c2bbxeZs/scoG3ynBXH4zN6TDX8ArrM403QPTE807OIiTSHz1vZrvbsSyC b5lRld1/bUxofcddaJRRu3ieVRPYOsodP7YS+g1vMfloyd9cLzpjrGK2N1CO47BaL9380cqTiI OGnyDGiOsHZA5D9d5lIJycWBfGTTadn8M9uXkJQuALCVlrLvyx+txlDkr9PrN25aMewtV/lKjE dgo= From: Julian Brown To: Subject: [PATCH 0/3] OpenACC "exit data" copyout, and Fortran derived-type members Date: Thu, 4 Jun 2020 06:40:52 -0700 Message-ID: X-Mailer: git-send-email 2.23.0 In-Reply-To: <87ftbw9kqh.fsf@euler.schwinge.homeip.net> References: <87ftbw9kqh.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catherine_Moore@mentor.com, Tobias Burnus , Thomas Schwinge Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" This is a split version of the patch previously posted here: https://gcc.gnu.org/legacy-ml/gcc-patches/2020-01/msg00512.html There were actually a couple of different issues addressed by that patch, and Thomas raised another (or so). This separated-out version should be more-obviously safe (in terms of maintaining backwards compatibility, where that makes sense). Further commentary on individual patches. Tested (as a series) with offloading to NVPTX. OK? Julian Julian Brown (3): OpenACC "exit data" copyout for struct members Strip GOMP_MAP_STRUCT from OpenACC exit data mappings Fortran derived-type mapping fix gcc/fortran/trans-openmp.c | 4 +- gcc/gimplify.c | 3 +- .../goacc/struct-enter-exit-data-1.c | 35 +++++++++++++++ .../gfortran.dg/goacc/mapping-tests-3.f90 | 15 +++++++ .../gfortran.dg/goacc/mapping-tests-4.f90 | 17 +++++++ libgomp/oacc-mem.c | 32 -------------- .../struct-copyout-1.c | 38 ++++++++++++++++ .../struct-copyout-2.c | 44 +++++++++++++++++++ 8 files changed, 153 insertions(+), 35 deletions(-) create mode 100644 gcc/testsuite/c-c++-common/goacc/struct-enter-exit-data-1.c create mode 100644 gcc/testsuite/gfortran.dg/goacc/mapping-tests-3.f90 create mode 100644 gcc/testsuite/gfortran.dg/goacc/mapping-tests-4.f90 create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/struct-copyout-1.c create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/struct-copyout-2.c