From patchwork Fri Feb 28 01:17:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 1246240 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-520281-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=uDqHUxS6; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=iUIeFane; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48TBVj5n92z9sNg for ; Fri, 28 Feb 2020 12:18:04 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=s+kHy8TZVCP3slSyesRkz3GpCe+qea4gaHe5mdo/9GrYVJJ+OD ZmqwtlmuBeGLwLrg7AKXUAcz3Krfi8P+j8N5WrhhqfVQnmJFpFK7V71gbaEapn+S DuE26JohU04LbhnvMCGmgOjg6igc/NAb7S3sgr/JEHEifZ2f7/4hDA1Fg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=abYRjhN2iZqfxIrIycfpdy5BUv8=; b=uDqHUxS6mMJy9+GqWbsJ 1BwT44ODMLtW/PMy/9XjEm+4CZZ8xK1T+d+6YO0L5fakXlbLQoZgc4hprExwE+8+ zfSzXuM0Cw/NfnjjJdNTRX/4jZEVUa5vH6F8V1QEeS+0EbY+q4zsBGUQ9LHAagLh Dqg//Ec4RIK3zFV+l51OYoU= Received: (qmail 31357 invoked by alias); 28 Feb 2020 01:17:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31349 invoked by uid 89); 28 Feb 2020 01:17:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL, BAYES_00, KAM_SHORT autolearn=ham version=3.3.1 spammy=wiring, H*Ad:U*cltang, Mike, Verified X-HELO: esa5.hgst.iphmx.com Received: from esa5.hgst.iphmx.com (HELO esa5.hgst.iphmx.com) (216.71.153.144) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 01:17:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1582852675; x=1614388675; h=date:from:to:cc:subject:message-id:mime-version; bh=yhOLe8cuODIzGhWbC2FQf4ef+9ARG6Gg5cJ65FnZqlY=; b=iUIeFaneMzNxdyECix8TMsvu15WNLRSLyFpgjeeRUMEmJMOEveRROUNX JJEAndpHvTpz8jd/MXR8fZyFgcAu9bZuTE2tejweM3u62mkzgB8aVWHxt lWXhWIYNzdix0bSMIbQURo0OQWTs9uLKs6CAAas+JW2D+yAJe93tHR7uW FtvFBJ/PmCR+FakmLCn3q9i0OE2P4gZ0nqJGg5rJgQNu+CTYjpjgSySL8 HSWyCWO0iBVJ6R99lNTot6jff/OwowfVvBh5vvAvZ+im9zoD93+RjLHhY T+h3KJ7dHI1Z/UgDu/4Fm9EJY2OY81u6n8JwPuaMr5Bn/KN8Gkjpuvz/n Q==; IronPort-SDR: /IEUkF/yFnSh6v3gJtONAGJ/Yty6nYZg5hzycB25gOOH0+ZIQSLsI97U2RZHYoP2OyVknUAhwX InGfyw3fHWDpEUkhzOCYXhVpCS52GsFF5yS28SUkOQ2KGsaBfPp4Gl34YXAQwm8kuQaBaoaNvo 5YAAa5Oco1T2rvd8+xsxfGX/WqJB2xL33oVneYSSwctUTbvAfjKNfTv1qcD+qj6rrKvh3FL/+c C/tvCwmeMQvVX9ay53U115Fxmoi0HQ4nmu9NQpR0GL+cOEvznzoVO4K7QPqeUZDtsgAAioQuyt VSE= Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2020 09:17:36 +0800 IronPort-SDR: K3dY2GQYqXcBg74smhOnZuUwcPH8svRgMYGoOE8+6SiIKliChBGrGNb2f9s8bKfY8PQla+U/4q gROgZiWaC5DVBsSPT9EWhlG4bs3rbKwmW4ztAndAKLXjMEhbGe+Lp8FKfqRYCokGE7818YJh9s GOB2yqkjcmDn+JKMQfyPa2j8agDIEH+RIbSqlfJIGUUwVr8gFISrHNB2YeASjMORNcfwltkZor bu0XTR0eJM7JP5O7o5N9KW107Uop/keH4hZoTyM6c0WLKSbZ2WaCt7FKu6alcVwLxxjKNq235H pPgVBbi8frmcbSZ3N/hsnsXo Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 17:09:58 -0800 IronPort-SDR: GKqnTuPZlGFVdSePVuKIuQZp2pfaWotHHhd1YExeUt+FaxOv99Sc6ukeaOSBCNxLAgxr8EtSFN UX2dQzwiMdFwzqqqgKXVjTHJZMfFhmbeCbE7bMv0BjYPNS6xwkqQ4ZfEJX5sl2fpvZGhG1LkLO IO53nRcZsk/GrDbQcGK0DhnM1N/rNKZUSdpL5Iu7E+eVCeFkockngYh19J6oCdG5DvaFUEFem8 L+lWlwxJ7UHz3cNiGrJ4bhyxr/tXk+1FKu+2mnwApNx56eIPIpwHvjwtntL1VAZTvK8n/RSj52 wHs= WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 17:17:34 -0800 Date: Fri, 28 Feb 2020 01:17:30 +0000 (GMT) From: "Maciej W. Rozycki" To: gcc-patches@gcc.gnu.org cc: Julian Brown , Tobias Burnus , Jeff Law , Thomas Schwinge , Mike Stump , Chung-Lin Tang , Ian Lance Taylor Subject: [PATCH v3 0/4] Fix library testsuite compilation for build sysroot Message-ID: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Hi, This is v3 of patch series, originally posted here: and then reposted as v2 here: meant to address a problem with the testsuite compiler being set up across libatomic, libffi, libgo, libgomp with no correlation whatsoever to the target compiler being used in GCC compilation. Consequently there in no arrangement made to set up the compilation sysroot according to the build sysroot specified for GCC compilation, causing a catastrophic failure across the testsuites affected from the inability to link executables. There were concerns raised by Julian and Chung-Lin about the libgomp change in v1 where an issue triggered in their standalone test environment and the wrong compiler executable was chosen. To address this issue in v2 I proposed to use the `--tool_exec' option to `runtest' to choose the compiler, however Mike expressed concerns about this approach causing troubles where `runtest' is invoked standalone rather than via `make'. I have outlined yet another (third) approach in: and I have since realised that the generated `libgomp/testsuite/libgomp-test-support.exp' configuration file is not used with the usual automake's mechanism defined to supply cnofiguration files to DejaGNU. Consequently this v3 of the series implements my third approach and I am fairly sure (and certainly do hope) it will satisfy everyone involved. This goes back to v1 for most of the matter and brings back the use of GCC_UNDER_TEST (or GOC_UNDER_TEST) supplied via `site.exp' to choose the compiler to use for testing. However for consistency the file to keep this setting is in v3 called `*-site-extra.exp' rather than `*-test-support.exp'. For 1/4 (libatomic) and 2/4 (libffi) this is the only change made compared to v1, and v1 series has already been approved by Mike here: and Jeff here: These two patches were uncontroversial and the file name change can be considered trivial, so I am going to apply v3 of these patches shortly unless I hear objections. For 3/4 (libgo), where v1 has been already applied, v3 renames `libgo-site-extra.exp' to `libgo-test-support.exp' and also brings support for the `--tool_exec' option to `runtest', to keep testsuite things consistent across top-level target libraries. I'm leaving it up to Ian to decide if he wants things arranged like this in libgo. For 4/4 (libgomp) some Makefile infrastructure changes are required along the lines of 1/4 and 2/4 to wire in `libgomp-site-extra.exp'; for these I request explicit approval before I push them. Verified with a cross-compiler configured for the `riscv-linux-gnu' target and the `x86_64-linux-gnu' host and using RISC-V/Linux QEMU in the user emulation mode as the target board. Also no change in results with `x86_64-linux-gnu' native regression testing. See individual change descriptions for details. I'm assuming Ian will take care of the 3/4 libgo change; any objections about 1/4 and 2/4, and OK to apply 4/4 to the GCC repo? Finally, apologies for the confusion my earlier oversight with `libgomp/testsuite/libgomp-test-support.exp' wiring may have caused. Maciej