From patchwork Thu Feb 13 23:36:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 1237808 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-519516-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha1 header.s=default header.b=rvXHlLBt; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=ebKyy6lW; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48JXw818jmz9s29 for ; Fri, 14 Feb 2020 10:36:37 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=xUZU3YprVrbV7j0jt2uwgVP9xe6pPsA7O/pzHJnpvO5Bksat80 0rN7ExPuV6aji/9MW4c+NyryVOk97g2wezLodRlws3I0OuDY3ih1EDLa89utkkjq XeWmcfPvg4Pqc0dw934AtCdmlsvxrpwyhcecXk6w2Vjjb9RznE93IXONU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=gH500ftT/B1Y8KdajC7R+HXe3dY=; b=rvXHlLBtKp70wmfvX89O QU9nVHduc8hU6US90zpqv2IinjbRSyBGofOJRBdLVDQMdVe+bkuopOPT+OpGRTuX G6Q0yYW/hWukjUbLn5xbY1Puue8aHi7cUzKxscdZ+14uxSMuU/X3Qp+H2y0fliUr 4oQtcO7hCExaTZNw3Dse6ds= Received: (qmail 114857 invoked by alias); 13 Feb 2020 23:36:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 114848 invoked by uid 89); 13 Feb 2020 23:36:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL, BAYES_00, KAM_SHORT autolearn=ham version=3.3.1 spammy=2019-11, 201911, find_gcc, HX-Languages-Length:2953 X-HELO: esa4.hgst.iphmx.com Received: from esa4.hgst.iphmx.com (HELO esa4.hgst.iphmx.com) (216.71.154.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 23:36:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1581636988; x=1613172988; h=date:from:to:cc:subject:message-id:mime-version; bh=ucgfrVkJMkoe404Ss1iJKXj00/ZLhGFFSfgsQXX+mGs=; b=ebKyy6lW8nSoBNA9u0BieokvPTbT7NV1JF04w8vUkhAvQUZPPnGrl461 Fvf7gAppcUYaAqmwQa6n9mpI7oaqG9JMWSlGaUIaLxvSWYHx7s14gci1H 9HmO1mm6vS50XoCqsE0znMcOwCCv35hfDE/Afy52MVXeUQOVmAn93M0b2 wONtw3gas5CcpEwskBMqGXEkFFYcq3T6np8S/SC/vdiFfDO5P4iQJmZ5h 9x553uQlAuFS09YUXx3Q4SGAovchl9KWlOaXtV4udFgLWp2n70gI0C5Tb EQt1po26m4nfcZXvK0nXkTyAvApBUZ0kvgbyzgfUxU3yIV9ujNIOUO+uK A==; IronPort-SDR: IdRG9EeBCs0jwwAT+J42O/3NQqwLmVEsQ5yaqSce0sH9AZ/jIz1ea9WuFTbLyuLfL/Oe8GdufF Sr5L0Qv+JHI+RcbvqXbCDR6exm8d7kXHwEhd48i6bqleS5t/O5eNctULyQUcaUgYfyN1yfMS7m 2JyhYLwah4k19uxLNou3BnafgfnVOSa5r2xDbkhXxDYN/yoUzdsiyMwCMrnHRzrQfL3oFooAxU FtrKPj6Ybslw1P0JBV00f/PrcukwvRHob4tTvAXUKnqkizacTNu/bjRmc9rpJ6Gu/9RatnozTj h+Y= Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 14 Feb 2020 07:36:16 +0800 IronPort-SDR: GVB9Ng7btGWEzjsfBtGpeXIJo92P0G64nWk0YBuU/kbks8uBmVe0cMQCk24NbapSq03UYa2E4Z g+MGvuHkMcH3BUPaA53m3ITNBQlziTLmIPDtz/wBHC3PAKcaRGWDKu4k6Cs8KSP+fEtfM6ueIn fWqfEGq1OF8xyU4u/jS4jxHHtgh6ZUmD0cy2DvaeJ4zFRhr2n/+5HSdW8syUuCtDTEukQrarMi Pj1m6yipqj9nSuzZ6sraFl/g8+Jd1aEzaL7kveLVzzqvjg2qAEOeErem0Wz1HEDcdzGLl0n+GB flYKn/kPOx9yQSGTzHt4/IJE Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 15:29:02 -0800 IronPort-SDR: JGolRp5qXESwzKQBZTmlICJDzNJvq31BLGYmy1jNa+wphn4a76AkWOoi9hA9mFsbNEW+ON0W39 vNwnUYqs+srmqvdKGcBP57YEuBdyRpU4YNL0M4o5cNS/9KQOUmHvQFHoVeobfjY60/MUeDh2Ar eOwv2bmqdf5rNsM1E6Ay0tMZSdvyK5UIoanzM2MEdsomPvT7qrIuZ4KBTNbteFX1JxSEqp5187 hpoyWAfZL92JbINpzYqeN2Afm78CtwUsRoTP7QM40zaeZ9wkcKBliziVfbFpZCOHntFvcgkYNY gtE= WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 15:36:15 -0800 Date: Thu, 13 Feb 2020 23:36:09 +0000 (GMT) From: "Maciej W. Rozycki" To: gcc-patches@gcc.gnu.org cc: Julian Brown , Tobias Burnus , Jeff Law , Thomas Schwinge , Mike Stump , Chung-Lin Tang , Ian Lance Taylor Subject: [PATCH v2 0/4] Fix library testsuite compilation for build sysroot Message-ID: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Hi, This is v2 of patch series, originally posted here: meant to address a problem with the testsuite compiler being set up across libatomic, libffi, libgo, libgomp with no correlation whatsoever to the target compiler being used in GCC compilation. Consequently there in no arrangement made to set up the compilation sysroot according to the build sysroot specified for GCC compilation, causing a catastrophic failure across the testsuites affected from the inability to link executables. Julian reported an issue triggered in his standalone test environment by the original version of the libgomp part of this patch series, which is one of the two patches from the series that have been already applied. The cause has been the newly-added definition of GCC_UNDER_TEST embedded in the generated libgomp/testsuite/libgomp-test-support.exp configuration file, which is used in Julian's setup which also relies on the invocation of `[find_gcc]' to locate the correct compiler to use. This invocation is unsuitable for in-tree testing as we want to use exactly the same compiler invocation, as recorded in $(CC), as used to build the library. So I have worked with Chung-Lin on a replacement version, which would work with such standalone testing while still satisfying the original requirement to use $(CC). In the end I have decided to use the documented `--tool_exec' option to `runtest' to contain the change within the testsuite's Makefile and its `check' goal, which is inherent to the build tree and as such not supposed to be used in standalone testing, like with `contrib/test_installed'. I am quite sure the problem is specific to libgomp only, as it's the only of the four libraries handled that had a preexisting *-test-support.exp test configuration file, and the remaining three only got one with the changes from the series. However to keep things consistent across the tree I propose to use the `--tool_exec' option for all four libraries. This in particular means reverting the whole of the libgomp change as well as a part of the libgo change, both already applied, in addition to making further adjustments. For libatomic and libffi this updated proposal merely replaces the original one. Verified with a cross-compiler configured for the `riscv-linux-gnu' target and the `x86_64-linux-gnu' host and using RISC-V/Linux QEMU in the user emulation mode as the target board. Also no change in results with `x86_64-linux-gnu' native regression testing. See individual change descriptions for details. I'm assuming Ian will take care of the 3/4 libgo change; OK to apply the remaining ones to the GCC repo? Maciej