From patchwork Thu Jul 18 05:29:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Meissner X-Patchwork-Id: 1961897 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=dCoohPpf; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WPhG02R8dz1xrQ for ; Thu, 18 Jul 2024 15:30:00 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A5E8385E839 for ; Thu, 18 Jul 2024 05:29:58 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 08FE83858433 for ; Thu, 18 Jul 2024 05:29:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08FE83858433 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08FE83858433 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721280580; cv=none; b=jgL51kCFXzTkXnXOOFRORfivnLyTTE3DuA/Dh3PQ9nw8x7Vve84wdWy3gYuw6jWJPft0JOgaIzbCuzzbeBzil8bDuf8t1DRJuMj9BmPSmA9EATY5i515U5stz9QnjkWJuVLm1+cz+011xaRksSWpV/Yir+iOeUA7H+BY/GJfK0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721280580; c=relaxed/simple; bh=0paS4/oE8il8KKITQ3hrfuinN9iQGGCiSzEESSm05rs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=vOSnPgzcbz24c3qeF9kDBnN5egGU7f1KrBJsxGDBRyaX+GB3Wc2mQPgb4MgabLfUIJFKtWBShYsDVn4KqR2jl7TzR+iFymboAexSghvgDfQIlTWGunGl4/nNCYERQ5GfD3zlJaMqHOl3bqmVgLQvqZk4/AW70ulugkwlK5+r2Gk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46I5S0DQ013715; Thu, 18 Jul 2024 05:29:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:subject:message-id:mime-version:content-type; s=pp1; bh=BsEdeKmtnhlViLzF/WWKD4lu5OZiVCuIIB9UlYQO8SA=; b=dCoohPpfEraN QuuAgsj7jOugf86ofARs3QQCVWfcod54elgX1WmJ8EWmf+vaO2eWP7wc+oFLij3I aXcPeYdoBFATF/Ud70ByhMYnP6YDkWsDVDJi/jXkw9oOUNv1JcrPeL3M5emKRZW7 wkYhDy20t/Osqyaxx/fah6FmDz6E281AhqXksWAqisX+WsBVgFFhADf4E5VslxDO ameaPVUDW8oc9L1nCoCyIyXqE1avQLg8E8/TIZLzFu3Z6g8G6h50oAxbtzNzVsaS jFHSKfaU4u5lKe39+rquzJ7qKAe8uD9BB2TRZ6FUwNPwgiVe3ECYVV8H0M6cjOOl 7jXv2jeobg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40eev9a174-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2024 05:29:37 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 46I5Tbsa015776; Thu, 18 Jul 2024 05:29:37 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40eev9a171-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2024 05:29:36 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 46I1NDdl000487; Thu, 18 Jul 2024 05:29:35 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 40dwkk7yx5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2024 05:29:35 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 46I5TWrS28377734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Jul 2024 05:29:34 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B217458067; Thu, 18 Jul 2024 05:29:32 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E45558055; Thu, 18 Jul 2024 05:29:32 +0000 (GMT) Received: from cowardly-lion.the-meissners.org (unknown [9.61.122.31]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Thu, 18 Jul 2024 05:29:31 +0000 (GMT) Date: Thu, 18 Jul 2024 01:29:30 -0400 From: Michael Meissner To: gcc-patches@gcc.gnu.org, Michael Meissner , Segher Boessenkool , "Kewen.Lin" , David Edelsohn , Peter Bergner Subject: [PATCH 0/2] PR target/113652, Fix failed bootstrap on ppc unrecognized opcode: `lfiwzx' with -mcpu=7450 Message-ID: Mail-Followup-To: Michael Meissner , gcc-patches@gcc.gnu.org, Segher Boessenkool , "Kewen.Lin" , David Edelsohn , Peter Bergner MIME-Version: 1.0 Content-Disposition: inline X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: TUVtsZipCTmZO7vAATbJz97Lu7FXYii5 X-Proofpoint-GUID: CZn501uzOfVccUJgIbQJqb_5BK-mK99y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-18_02,2024-07-17_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 mlxlogscore=604 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407180035 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Currently, we add -mvsx when building the float128 support in libgcc. This allows us to build the float128 support on a big endian system where the default cpu is power4. While the libgcc support can be built, given there is no glibc support for float128 available. However, adding -mvsx and building the libgcc float128 support causes problems if you set the default cpu to something like a 7540, which does not have VSX support. The assembler complains that when the code does a ".machine 7450", you cannot use VSX instructions. There are two patches in this set: In the first patch, the float128 libgcc support is only built if the default compiler has VSX support. If somebody wants to enable the glibc support for big endian, they would need to set the base cpu to power8 to enable building the libgcc float128 libraries. In the second patch, I adjusted the compiler tests so that they would only run the float128 tests when the compiler enables float128. I removed setting options for enabling the VSX instruction set (-mvsx), enabling float128 support in the compiler (-mfloat128), and enabling float128 hardware support (-mfloat128-hardware), even if -mcpu=power9 was used. I built little endian compilers and there were no regressions. I built big endian compilers with the --with-cpu=power5 configure option, and I verified that none of the float128 support functions are built. I also built big endian compilers on a power9 with the --with-cpu=native configure option, and I verified that the float128 support functions were built, since the default compiler used the VSX instruction set. I verified that on both sets of big endian builds, that all of the float128 tests were skipped, since there is no support for float128 in glibc and the GCC compiler does not enable float128 on those systems. Can I check these patches into the trunk assuming the original bugzilla author says they fix the problem?