| Message ID | DBBPR83MB0613E6D85CDE663E0B7A57C8F89E2@DBBPR83MB0613.EURPRD83.prod.outlook.com |
|---|---|
| Headers | show |
| Series | SMALL code model fixes, optimization fixes, LTO and minimal C++ enablement | expand |
Evgeny Karpov <Evgeny.Karpov@microsoft.com> writes: > Hello, > > Thank you for reviewing v1! > > v2 Changes: > - Add extra comments and extend patch descriptions. > - Extract libstdc++ changes to a separate patch. > - Minor style refactoring based on the reviews. > - Unify mingw_pe_declare_type for functions and objects. Thanks for the update. Aside from the points raised in the discussion about patches 5, 6, and 9 (and taking into account what you said about patch 7), the series looks good. Thanks, Richard > > Regards, > Evgeny > > Evgeny Karpov (9): > Support weak references > aarch64: Add debugging information > aarch64: Add minimal C++ support > aarch64: Exclude symbols using GOT from code models > aarch64: Multiple adjustments to support the SMALL code model > correctly > aarch64: Use symbols without offset to prevent relocation issues > aarch64: Disable the anchors > Add LTO support > aarch64: Handle alignment when it is bigger than BIGGEST_ALIGNMENT > > gcc/config.gcc | 1 + > gcc/config/aarch64/aarch64-coff.h | 32 +++++++------- > gcc/config/aarch64/aarch64.cc | 43 ++++++++++++++++--- > gcc/config/aarch64/cygming.h | 69 +++++++++++++++++++++++++++++-- > gcc/config/i386/cygming.h | 16 +++---- > gcc/config/i386/i386-protos.h | 2 - > gcc/config/mingw/winnt-dll.cc | 4 +- > gcc/config/mingw/winnt.cc | 33 ++++++++++----- > gcc/config/mingw/winnt.h | 7 ++-- > libiberty/simple-object-coff.c | 4 +- > 10 files changed, 158 insertions(+), 53 deletions(-)
Thursday, September 19 Richard Sandiford <richard.sandiford@arm.com> wrote: > > Thanks for the update. Aside from the points raised in the discussion > about patches 5, 6, and 9 (and taking into account what you said about > patch 7), the series looks good. Thank you for the review Richard. Patch 5 has been changed to "," HOST_WIDE_INT_PRINT_UNSIGNED "\n", Patch 6 has been updated here https://gcc.gnu.org/pipermail/gcc-patches/2024-October/665979.html Patch 7 will be dropped. Patch 9 will be dropped if there is still not enough clarity on how it works. https://gcc.gnu.org/pipermail/gcc-patches/2024-October/666699.html If there are no more comments, the next patch series version v3 will be prepared soon. Regards, Evgeny
Hello, Thank you for reviewing v1! v2 Changes: - Add extra comments and extend patch descriptions. - Extract libstdc++ changes to a separate patch. - Minor style refactoring based on the reviews. - Unify mingw_pe_declare_type for functions and objects. Regards, Evgeny Evgeny Karpov (9): Support weak references aarch64: Add debugging information aarch64: Add minimal C++ support aarch64: Exclude symbols using GOT from code models aarch64: Multiple adjustments to support the SMALL code model correctly aarch64: Use symbols without offset to prevent relocation issues aarch64: Disable the anchors Add LTO support aarch64: Handle alignment when it is bigger than BIGGEST_ALIGNMENT gcc/config.gcc | 1 + gcc/config/aarch64/aarch64-coff.h | 32 +++++++------- gcc/config/aarch64/aarch64.cc | 43 ++++++++++++++++--- gcc/config/aarch64/cygming.h | 69 +++++++++++++++++++++++++++++-- gcc/config/i386/cygming.h | 16 +++---- gcc/config/i386/i386-protos.h | 2 - gcc/config/mingw/winnt-dll.cc | 4 +- gcc/config/mingw/winnt.cc | 33 ++++++++++----- gcc/config/mingw/winnt.h | 7 ++-- libiberty/simple-object-coff.c | 4 +- 10 files changed, 158 insertions(+), 53 deletions(-)