From patchwork Fri Oct 23 19:07:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 535197 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 856AA1416DF for ; Sat, 24 Oct 2015 06:07:28 +1100 (AEDT) Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t9NJ7L1A000623 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Oct 2015 19:07:21 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t9NJ7LBG031423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Oct 2015 19:07:21 GMT Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1ZphgP-0001LM-KZ; Fri, 23 Oct 2015 12:07:21 -0700 Received: from aserv0021.oracle.com ([141.146.126.233]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1ZphgN-0001L6-TF for fedfs-utils-devel@oss.oracle.com; Fri, 23 Oct 2015 12:07:19 -0700 Received: from aserp1020.oracle.com (aserp1020.oracle.com [141.146.126.67]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t9NJ7JLO031323 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 23 Oct 2015 19:07:19 GMT Received: from userp2040.oracle.com (userp2040.oracle.com [156.151.31.90]) by aserp1020.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t9NJ7JFR009734 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 23 Oct 2015 19:07:19 GMT Authentication-Results: aserp1020.oracle.com; dkim=pass reason="2048-bit key" header.d=gmail.com header.i=@gmail.com header.b=CR1ojo1y Received: from pps.filterd (userp2040.oracle.com [127.0.0.1]) by userp2040.oracle.com (8.15.0.59/8.15.0.59) with SMTP id t9NJ42DC004846 for ; Fri, 23 Oct 2015 19:07:19 GMT Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com [209.85.213.182]) by userp2040.oracle.com with ESMTP id 1xqquxdvp5-1 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 23 Oct 2015 19:07:18 +0000 Received: by igbkq10 with SMTP id kq10so40815667igb.0 for ; Fri, 23 Oct 2015 12:07:18 -0700 (PDT) X-Received: by 10.50.47.81 with SMTP id b17mr6191338ign.39.1445627238154; Fri, 23 Oct 2015 12:07:18 -0700 (PDT) Received: from seurat.1015granger.net ([2604:8800:100:81fc:20c:29ff:fe44:ec31]) by smtp.gmail.com with ESMTPSA id l198sm569841iol.37.2015.10.23.12.07.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Oct 2015 12:07:17 -0700 (PDT) From: Chuck Lever To: fedfs-utils-devel@oss.oracle.com Date: Fri, 23 Oct 2015 12:07:17 -0700 Message-ID: <20151023190717.101462.35738.stgit@seurat.1015granger.net> In-Reply-To: <20151023190357.101462.95038.stgit@seurat.1015granger.net> References: <20151023190357.101462.95038.stgit@seurat.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 redirect=_spf.google.com X-ServerName: mail-ig0-f182.google.com X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7963 signatures=670651 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=15 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1510230319 Subject: [fedfs-utils] [PATCH 2/6] fedfsc: Remove vestigial dash switches for position arguments X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: aserv0021.oracle.com [141.146.126.233] Commit 54713f0416e6 missed a couple of places where dash switches were replaced with the use of positional command line arguments. Coverity: 126105 Fixes: 54713f0416e6 ("fedfsc: Specify manadatory arguments . . .") Signed-off-by: Chuck Lever --- doc/man/fedfs-lookup-replication.8.in | 5 ----- src/fedfsc/fedfs-lookup-replication.c | 4 ---- 2 files changed, 9 deletions(-) diff --git a/doc/man/fedfs-lookup-replication.8.in b/doc/man/fedfs-lookup-replication.8.in index 710e257..0cc3482 100644 --- a/doc/man/fedfs-lookup-replication.8.in +++ b/doc/man/fedfs-lookup-replication.8.in @@ -124,11 +124,6 @@ If this option is not specified, the default value is See .BR rpc (3t) for details. -.IP "\fB\-p, \-\-path=\fIpathname\fP" -Specifies the location on the remote server where the target FedFS replication -resides. -This pathname is relative to the remote server's physical root directory, -not the remote server's NFS pseudoroot. .IP "\fB\-t, \-\-resolvetype=\fItype\fP" Specifies the desired type of resolution. Valid values for .I type diff --git a/src/fedfsc/fedfs-lookup-replication.c b/src/fedfsc/fedfs-lookup-replication.c index c6f0b2c..c8a1ebf 100644 --- a/src/fedfsc/fedfs-lookup-replication.c +++ b/src/fedfsc/fedfs-lookup-replication.c @@ -282,7 +282,6 @@ main(int argc, char **argv) nettype = "netpath"; security = "unix"; resolvetype = "none"; - path = NULL; while ((arg = getopt_long(argc, argv, fedfs_lookup_replication_opts, fedfs_lookup_replication_longopts, NULL)) != -1) { switch (arg) { @@ -295,9 +294,6 @@ main(int argc, char **argv) case 'n': nettype = optarg; break; - case 'p': - path = optarg; - break; case 's': security = optarg; break;