From patchwork Wed Jul 8 18:26:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 493083 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DCC471402B7 for ; Thu, 9 Jul 2015 04:27:02 +1000 (AEST) Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t68IQxDg005114 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Jul 2015 18:26:59 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t68IQwH1006905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 8 Jul 2015 18:26:59 GMT Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1ZCu3e-00067H-QH; Wed, 08 Jul 2015 11:26:58 -0700 Received: from aserv0022.oracle.com ([141.146.126.234]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1ZCu3d-000678-6H for fedfs-utils-devel@oss.oracle.com; Wed, 08 Jul 2015 11:26:57 -0700 Received: from aserp1020.oracle.com (aserp1020.oracle.com [141.146.126.67]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t68IQvVs032379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Jul 2015 18:26:57 GMT Received: from userp2040.oracle.com (userp2040.oracle.com [156.151.31.90]) by aserp1020.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t68IQurh014358 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 8 Jul 2015 18:26:56 GMT Authentication-Results: aserp1020.oracle.com; dkim=pass reason="2048-bit key" header.d=gmail.com header.i=@gmail.com header.b=NTs5RIC4 Received: from pps.filterd (userp2040.oracle.com [127.0.0.1]) by userp2040.oracle.com (8.14.7/8.14.7) with SMTP id t68IQRMG036767 for ; Wed, 8 Jul 2015 18:26:56 GMT Received: from mail-qg0-f44.google.com (mail-qg0-f44.google.com [209.85.192.44]) by userp2040.oracle.com with ESMTP id 1vh3ufk4n1-1 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2015 18:26:56 +0000 Received: by qgep37 with SMTP id p37so12064814qge.1 for ; Wed, 08 Jul 2015 11:26:55 -0700 (PDT) X-Received: by 10.140.237.147 with SMTP id i141mr19489016qhc.25.1436380015182; Wed, 08 Jul 2015 11:26:55 -0700 (PDT) Received: from seurat.1015granger.net ([2604:8800:100:81fc:20c:29ff:fe44:ec31]) by smtp.gmail.com with ESMTPSA id z81sm1572034qkg.44.2015.07.08.11.26.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2015 11:26:54 -0700 (PDT) From: Chuck Lever To: fedfs-utils-devel@oss.oracle.com Date: Wed, 08 Jul 2015 11:26:53 -0700 Message-ID: <20150708182653.24274.82058.stgit@seurat.1015granger.net> In-Reply-To: <20150708182053.24274.13851.stgit@seurat.1015granger.net> References: <20150708182053.24274.13851.stgit@seurat.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-ServerName: mail-qg0-f44.google.com X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7856 signatures=670602 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=1 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1506180000 definitions=main-1507080276 Subject: [fedfs-utils] [PATCH 06/11] fedfsd: Report legal but non-existent path during lookup-junction X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: userv0021.oracle.com [156.151.31.71] FEDFS_LOOKUP_JUNCTION reports FEDFS_ERR_INVAL if the specified path doesn't exist. INVAL is a little broad: it could mean, for example, that any one of the arguments is incorrect. RFC 7533 does not have a "does not exist" error code. But it does allow FEDFS_LOOKUP_JUNCTION to return FEDFS_ERR_NOTJUNCT. That seems closer in spirit than FEDFS_ERR_INVAL. XXX: I need to check FEDFS_CREATE_JUNCTION and FEDFS_DELETE_JUNCTION with crazy pathnames as well. Signed-off-by: Chuck Lever --- src/fedfsd/svc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/fedfsd/svc.c b/src/fedfsd/svc.c index c02daad..9198c69 100644 --- a/src/fedfsd/svc.c +++ b/src/fedfsd/svc.c @@ -888,9 +888,11 @@ fedfsd_svc_lookup_junction_1(SVCXPRT *xprt) case FEDFS_ERR_EXIST: break; case FEDFS_OK: - case FEDFS_ERR_NOTJUNCT: result.status = FEDFS_ERR_INVAL; goto out; + case FEDFS_ERR_INVAL: + result.status = FEDFS_ERR_NOTJUNCT; + goto out; default: goto out; }