@@ -236,10 +236,11 @@ main(int argc, char **argv)
fedfs_create_junction_usage(progname);
}
break;
+ case '?':
+ fedfs_create_junction_usage(progname);
default:
fprintf(stderr, "Invalid command line "
"argument: %c\n", (char)arg);
- case '?':
fedfs_create_junction_usage(progname);
}
}
@@ -233,10 +233,11 @@ main(int argc, char **argv)
fedfs_create_replication_usage(progname);
}
break;
+ case '?':
+ fedfs_create_replication_usage(progname);
default:
fprintf(stderr, "Invalid command line "
"argument: %c\n", (char)arg);
- case '?':
fedfs_create_replication_usage(progname);
}
}
@@ -184,9 +184,10 @@ main(int argc, char **argv)
case 'h':
hostname = optarg;
break;
+ case '?':
+ fedfs_delete_junction_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_delete_junction_usage(progname);
}
}
@@ -187,9 +187,10 @@ main(int argc, char **argv)
case 'p':
path = optarg;
break;
+ case '?':
+ fedfs_delete_replication_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_delete_replication_usage(progname);
}
}
@@ -232,9 +232,10 @@ main(int argc, char **argv)
fedfs_get_limited_nsdb_params_usage(progname);
}
break;
+ case '?':
+ fedfs_get_limited_nsdb_params_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_get_limited_nsdb_params_usage(progname);
}
}
@@ -249,9 +249,10 @@ main(int argc, char **argv)
fedfs_get_nsdb_params_usage(progname);
}
break;
+ case '?':
+ fedfs_get_nsdb_params_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_get_nsdb_params_usage(progname);
}
}
@@ -394,9 +394,10 @@ main(int argc, char **argv)
case 't':
resolvetype = optarg;
break;
+ case '?':
+ fedfs_lookup_junction_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_lookup_junction_usage(progname);
}
}
@@ -399,9 +399,10 @@ main(int argc, char **argv)
case 't':
resolvetype = optarg;
break;
+ case '?':
+ fedfs_lookup_replication_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_lookup_replication_usage(progname);
}
}
@@ -162,9 +162,10 @@ main(int argc, char **argv)
case 'n':
nettype = optarg;
break;
+ case '?':
+ fedfs_null_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_null_usage(progname);
}
}
@@ -250,9 +250,10 @@ main(int argc, char **argv)
fedfs_set_nsdb_params_usage(progname);
}
break;
+ case '?':
+ fedfs_set_nsdb_params_usage(progname);
default:
fprintf(stderr, "Invalid command line argument: %c\n", (char)arg);
- case '?':
fedfs_set_nsdb_params_usage(progname);
}
}
Avoid using fallthrough logic in switch statements. Fixes: 0520ee7207f9ba027c845cb33606a3c901ecd811 Signed-off-by: Chuck Lever <chuck.lever@oracle.com> --- src/fedfsc/fedfs-create-junction.c | 3 ++- src/fedfsc/fedfs-create-replication.c | 3 ++- src/fedfsc/fedfs-delete-junction.c | 3 ++- src/fedfsc/fedfs-delete-replication.c | 3 ++- src/fedfsc/fedfs-get-limited-nsdb-params.c | 3 ++- src/fedfsc/fedfs-get-nsdb-params.c | 3 ++- src/fedfsc/fedfs-lookup-junction.c | 3 ++- src/fedfsc/fedfs-lookup-replication.c | 3 ++- src/fedfsc/fedfs-null.c | 3 ++- src/fedfsc/fedfs-set-nsdb-params.c | 3 ++- 10 files changed, 20 insertions(+), 10 deletions(-)