From patchwork Mon May 19 16:39:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 350322 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 814D9140091 for ; Tue, 20 May 2014 02:40:01 +1000 (EST) Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4JGdw0o025703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 May 2014 16:39:58 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4JGdvJa007752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 May 2014 16:39:57 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1WmQbV-0000ZN-Kv; Mon, 19 May 2014 09:39:57 -0700 Received: from ucsinet21.oracle.com ([156.151.31.93]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1WmQbI-0000Yp-1l for fedfs-utils-devel@oss.oracle.com; Mon, 19 May 2014 09:39:44 -0700 Received: from aserp1020.oracle.com (aserp1020.oracle.com [141.146.126.67]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4JGdhAO027521 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 19 May 2014 16:39:43 GMT Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com [209.85.213.173]) by aserp1020.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4JGdgB9009880 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Mon, 19 May 2014 16:39:42 GMT Authentication-Results: aserp1020.oracle.com; dkim=pass reason="2048-bit key" header.d=gmail.com header.i=@gmail.com header.b=vuyrSxvO Received: by mail-ig0-f173.google.com with SMTP id hn18so3709800igb.12 for ; Mon, 19 May 2014 09:39:42 -0700 (PDT) X-Received: by 10.42.68.18 with SMTP id v18mr33302923ici.1.1400517582208; Mon, 19 May 2014 09:39:42 -0700 (PDT) Received: from seurat.1015granger.net ([2604:8800:100:81fc:20c:29ff:fe44:ec31]) by mx.google.com with ESMTPSA id o9sm22076584igj.20.2014.05.19.09.39.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 May 2014 09:39:41 -0700 (PDT) To: fedfs-utils-devel@oss.oracle.com From: Chuck Lever Date: Mon, 19 May 2014 12:39:41 -0400 Message-ID: <20140519163941.13956.59256.stgit@seurat.1015granger.net> In-Reply-To: <20140519163049.13956.70350.stgit@seurat.1015granger.net> References: <20140519163049.13956.70350.stgit@seurat.1015granger.net> User-Agent: StGit/0.16 MIME-Version: 1.0 X-Flow-Control-Info: class=Pass-to-MM reputation=ipRisk-All ip=209.85.213.173 ct-class=R5 ct-vol1=-94 ct-vol2=8 ct-vol3=7 ct-risk=46 ct-spam1=73 ct-spam2=7 ct-bulk=6 rcpts=1 size=2441 X-Sendmail-CM-Score: 0.00% X-Sendmail-CM-Analysis: v=2.1 cv=c5eSH3Nl c=1 sm=1 tr=0 a=xirCh7c50ffSVxvOkzx0UA==:117 a=dzsqy3y4QnMA:10 a=CLk7wanp9uoA:10 a=dPGociXpb70A:10 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=yPCof4ZbAAAA:8 a=Lb1rMZzfAAAA:8 a=1XWaLZrsAAAA:8 a=4u2_Q07lnU6xslDlJk0A:9 a=QEXdDO 2ut3YA:10 a=7DSvI1NPTFQA:10 X-Sendmail-CT-RefID: str=0001.0A090206.537A33CF.0041, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-Sendmail-CT-Classification: not spam Subject: [fedfs-utils] [PATCH 2/3] build: Coverity support X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet21.oracle.com [141.146.126.237] The new "covbuild" top-level make target builds the contents of the cov_int/ directory, which is intermediate output that is fed to Coverity Scan for analysis. Signed-off-by: Chuck Lever --- .gitignore | 1 + Makefile.am | 13 ++++++++++++- doc/CheckInTests | 13 +++++++------ 3 files changed, 20 insertions(+), 7 deletions(-) diff --git a/.gitignore b/.gitignore index 0c09a4e4c725..12ffd96dfb12 100644 --- a/.gitignore +++ b/.gitignore @@ -77,3 +77,4 @@ depcomp .libs/ .stgit* py-compile +cov-int/ diff --git a/Makefile.am b/Makefile.am index 046280199e10..6bb1e2816f85 100644 --- a/Makefile.am +++ b/Makefile.am @@ -35,10 +35,21 @@ DISTCLEANFILES = Makefile.in ChangeLog fedfs-utils*.tar.gz ChangeLog: git log > ChangeLog -clean-local: doxyclean +clean-local: doxyclean covclean dist-hook: ChangeLog +# Coverity-related targets + +.PHONY: covbuild covclean + +covbuild: + cov-build --dir cov-int make + tar czvf /tmp/fedfs-utils-cov-int.tgz cov-int + +covclean: + $(RM) -rf cov-int + # Doxygen-related targets .PHONY: doxy doxyclean diff --git a/doc/CheckInTests b/doc/CheckInTests index 8375861f41d7..9336a436b989 100644 --- a/doc/CheckInTests +++ b/doc/CheckInTests @@ -92,11 +92,13 @@ bisecting to be useful. 3. "make -s -j3" must complete without error or new compiler or sparse warnings 4. "make doxy" must complete with no errors or warnings - 5. "make distcheck" must complete without error - 6. "make distclean" must complete without error - 7. "git status" must produce no output on a clean tree - 8. "git clean -d -f -x" does not break anything - 9. "git log -p" shows no new white space damage + 5. "make covbuild" must complete with at least 85% compilation + units ready for analysis + 6. "make distcheck" must complete without error + 7. "make distclean" must complete without error + 8. "git status" must produce no output on a clean tree + 9. "git clean -d -f -x" does not break anything +10. "git log -p" shows no new white space damage To preserve bisectability, the tree MUST build after each commit. @@ -112,7 +114,6 @@ At some point, we'd like: 1. Automated checking of coding style and white space 2. Automated fortify or splint testing during check-in 3. Automated unit tests - 4. Regular runs against coverity Per-release