From patchwork Sun May 11 21:29:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 347838 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3D0CC140083 for ; Mon, 12 May 2014 07:32:34 +1000 (EST) Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4BLWUT0029808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 11 May 2014 21:32:31 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4BLWUs6006392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 May 2014 21:32:30 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1WjbJB-0004Bj-7Y; Sun, 11 May 2014 14:29:21 -0700 Received: from ucsinet21.oracle.com ([156.151.31.93]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1WjbJ5-0004BD-V3 for fedfs-utils-devel@oss.oracle.com; Sun, 11 May 2014 14:29:16 -0700 Received: from userp1030.oracle.com (userp1030.oracle.com [156.151.31.80]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4BLTFS1029958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 11 May 2014 21:29:15 GMT Received: from mail-ie0-f169.google.com (mail-ie0-f169.google.com [209.85.223.169]) by userp1030.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4BLTE5L017618 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Sun, 11 May 2014 21:29:15 GMT Authentication-Results: userp1030.oracle.com; dkim=pass reason="2048-bit key" header.d=gmail.com header.i=@gmail.com header.b=XuhjAFKq Received: by mail-ie0-f169.google.com with SMTP id lx4so558126iec.28 for ; Sun, 11 May 2014 14:29:14 -0700 (PDT) X-Received: by 10.50.73.232 with SMTP id o8mr35217548igv.1.1399843754024; Sun, 11 May 2014 14:29:14 -0700 (PDT) Received: from seurat.1015granger.net ([2604:8800:100:81fc:20c:29ff:fe44:ec31]) by mx.google.com with ESMTPSA id kw1sm16903030igb.4.2014.05.11.14.29.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 May 2014 14:29:13 -0700 (PDT) To: fedfs-utils-devel@oss.oracle.com From: Chuck Lever Date: Sun, 11 May 2014 17:29:13 -0400 Message-ID: <20140511212913.13852.23621.stgit@seurat.1015granger.net> In-Reply-To: <20140511212416.13852.92639.stgit@seurat.1015granger.net> References: <20140511212416.13852.92639.stgit@seurat.1015granger.net> User-Agent: StGit/0.16 MIME-Version: 1.0 X-Flow-Control-Info: class=Pass-to-MM reputation=ipRisk-All ip=209.85.223.169 ct-class=R5 ct-vol1=-98 ct-vol2=8 ct-vol3=7 ct-risk=49 ct-spam1=77 ct-spam2=7 ct-bulk=6 rcpts=1 size=701 X-Sendmail-CM-Score: 0.00% X-Sendmail-CM-Analysis: v=2.1 cv=CYoxutbl c=1 sm=1 tr=0 a=23R3eXx4oBzumtq0w9zhZQ==:117 a=dzsqy3y4QnMA:10 a=6e-6WpLs9SAA:10 a=dPGociXpb70A:10 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=yPCof4ZbAAAA:8 a=Lb1rMZzfAAAA:8 a=1XWaLZrsAAAA:8 a=LyRhMQ_NyS6s5zSyctsA:9 a=QEXdDO 2ut3YA:10 a=7DSvI1NPTFQA:10 X-Sendmail-CT-RefID: str=0001.0A090209.536FEBAB.002C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-Sendmail-CT-Classification: not spam Subject: [fedfs-utils] [PATCH 08/17] nfsref: Fix memory leak in nfsref_add_build_fsl() X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet21.oracle.com [141.146.126.237] Fixes: 538e6282ff68e838763bc30aeeae41c5ec309ca9 Signed-off-by: Chuck Lever --- src/nfsref/add.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/nfsref/add.c b/src/nfsref/add.c index 7999e0f..52974c9 100644 --- a/src/nfsref/add.c +++ b/src/nfsref/add.c @@ -374,8 +374,10 @@ nfsref_add_build_fsl(const char *fsn_uuid, const char *server, strncpy(new->fl_fsnuuid, fsn_uuid, sizeof(new->fl_fsnuuid)); retval = nfsref_add_nfs_fsl_defaults(server, rootpath, &new->fl_u.fl_nfsfsl); - if (retval != FEDFS_OK) + if (retval != FEDFS_OK) { + nsdb_free_fedfs_fsl(new); return retval; + } *fsl = new; return FEDFS_OK;