From patchwork Tue Nov 6 17:33:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 197515 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "userp1040.oracle.com", Issuer "VeriSign Class 3 International Server CA - G3" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 273C22C00AE for ; Wed, 7 Nov 2012 04:33:35 +1100 (EST) Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qA6HXWHZ022403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 6 Nov 2012 17:33:33 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qA6HXVtd026382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 6 Nov 2012 17:33:32 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1TVn1n-0007JC-UB; Tue, 06 Nov 2012 09:33:31 -0800 Received: from acsinet21.oracle.com ([141.146.126.237]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1TVn1X-0007IW-4g for fedfs-utils-devel@oss.oracle.com; Tue, 06 Nov 2012 09:33:15 -0800 Received: from acsinet12.oracle.com (acsinet12.oracle.com [141.146.126.234]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qA6HXEON018827 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 6 Nov 2012 17:33:15 GMT Received: from mail-da0-f43.google.com (mail-da0-f43.google.com [209.85.210.43]) by acsinet12.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qA6HX5rs001957 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Tue, 6 Nov 2012 17:33:14 GMT Received: by mail-da0-f43.google.com with SMTP id u36so279048dak.2 for ; Tue, 06 Nov 2012 09:33:14 -0800 (PST) Received: by 10.68.137.228 with SMTP id ql4mr5295278pbb.125.1352223194131; Tue, 06 Nov 2012 09:33:14 -0800 (PST) Received: from seurat.1015granger.net ([2001:df8:0:64:20c:29ff:fe93:815b]) by mx.google.com with ESMTPS id sz6sm12636625pbc.52.2012.11.06.09.33.12 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Nov 2012 09:33:13 -0800 (PST) From: Chuck Lever To: fedfs-utils-devel@oss.oracle.com Date: Tue, 06 Nov 2012 12:33:11 -0500 Message-ID: <20121106173311.26310.78312.stgit@seurat.1015granger.net> In-Reply-To: <20121106172934.26310.10982.stgit@seurat.1015granger.net> References: <20121106172934.26310.10982.stgit@seurat.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Flow-Control-Info: class=Default reputation=ipRepBelow100 ip=209.85.210.43 ct-class=R5 ct-vol1=-96 ct-vol2=8 ct-vol3=7 ct-risk=54 ct-spam1=87 ct-spam2=7 ct-bulk=2 rcpts=1 size=1744 X-MM-CT-Classification: not spam X-MM-CT-RefID: str=0001.0A020202.509949DA.0147,ss=1,re=0.000,fgs=0 Subject: [fedfs-utils] [PATCH 02/11] CheckInTests: More clean up X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet22.oracle.com [141.146.126.238] Using the "-j" option on make should always work. A multi-threaded build is a good check that our Makefile dependencies are more or less correct. In addition, clean up the requirements around ./configure, and add a "make distclean" requirement. Signed-off-by: Chuck Lever --- doc/CheckInTests | 17 ++++++++++------- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/CheckInTests b/doc/CheckInTests index 37bc2ef..8a9043b 100644 --- a/doc/CheckInTests +++ b/doc/CheckInTests @@ -86,14 +86,17 @@ Per-commit acceptance tests This is basic stuff that's easy to run, and should be working for bisecting to be useful. - 1. "autogen.sh" and "configure" must run without error - 2. "CC=cgcc ./configure --enable-silent-rules; make -s" must complete - without error, and without new compiler or sparse warnings - 3. "make doxy" must complete with no errors or warnings - 4. "make distcheck" must complete without error - 5. "git status" must produce no output on a clean tree - 6. "git log -p" shows no new white space damage + 1. "autogen.sh" must run without error + 2. "CC=cgcc ./configure --enable-silent-rules --exec=/usr" must + complete successfully + 3. "make -s -j3" must complete without error or new compiler + or sparse warnings + 4. "make doxy" must complete with no errors or warnings + 5. "make distcheck" must complete without error + 6. "make distclean" must complete without error 7. "git clean -d -f -x" does not break anything + 8. "git status" must produce no output on a clean tree + 9. "git log -p" shows no new white space damage To preserve bisectability, the tree MUST build after each commit.