| Message ID | e987b0beabba169577c8923557690984f226b29b.1725518229.git.zhoubinbin@loongson.cn |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ASoC: Some issues about loongson i2s | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Sep 05, 2024 at 03:02:14PM +0800, Binbin Zhou wrote: > Add Everest Semiconductor ES8316 low power audio CODEC binding with DT > schema format using json-schema. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > .../bindings/sound/everest,es8323.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/everest,es8323.yaml > > diff --git a/Documentation/devicetree/bindings/sound/everest,es8323.yaml b/Documentation/devicetree/bindings/sound/everest,es8323.yaml > new file mode 100644 > index 000000000000..0450d0f49d03 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/everest,es8323.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/everest,es8323.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Everest ES8323 audio CODECs > + > +maintainers: > + - Binbin Zhou <zhoubinbin@loongson.cn> > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: everest,es8323 > + > + reg: > + maxItems: 1 > + > + clocks: > + description: clock for master clock (MCLK) > + maxItems: 1 > + > + clock-names: > + const: mclk > + > + '#sound-dai-cells': > + const: 0 No audio-graph-port? Are you sure? It looks exactly like everest,es8316... > + > +required: > + - compatible > + - reg > + - '#sound-dai-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + codec@10 { > + compatible = "everest,es8323"; > + reg = <0x10>; > + #sound-dai-cells = <0>; Make the example complete. Assuming this binding stays... Best regards, Krzysztof
Hi Krzysztof: Thanks for your review. On Fri, Sep 6, 2024 at 4:21 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Thu, Sep 05, 2024 at 03:02:14PM +0800, Binbin Zhou wrote: > > Add Everest Semiconductor ES8316 low power audio CODEC binding with DT > > schema format using json-schema. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > --- > > .../bindings/sound/everest,es8323.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/everest,es8323.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/everest,es8323.yaml b/Documentation/devicetree/bindings/sound/everest,es8323.yaml > > new file mode 100644 > > index 000000000000..0450d0f49d03 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/everest,es8323.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/everest,es8323.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Everest ES8323 audio CODECs > > + > > +maintainers: > > + - Binbin Zhou <zhoubinbin@loongson.cn> > > + > > +allOf: > > + - $ref: dai-common.yaml# > > + > > +properties: > > + compatible: > > + const: everest,es8323 > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + description: clock for master clock (MCLK) > > + maxItems: 1 > > + > > + clock-names: > > + const: mclk > > + > > + '#sound-dai-cells': > > + const: 0 > > No audio-graph-port? Are you sure? It looks exactly like > everest,es8316... I checked and they are indeed very similar and it seems I just need to add to everest,es8316.yaml instead of a new file. Thanks. Binbin > > > + > > +required: > > + - compatible > > + - reg > > + - '#sound-dai-cells' > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + codec@10 { > > + compatible = "everest,es8323"; > > + reg = <0x10>; > > + #sound-dai-cells = <0>; > > Make the example complete. Assuming this binding stays... > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/sound/everest,es8323.yaml b/Documentation/devicetree/bindings/sound/everest,es8323.yaml new file mode 100644 index 000000000000..0450d0f49d03 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/everest,es8323.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/everest,es8323.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Everest ES8323 audio CODECs + +maintainers: + - Binbin Zhou <zhoubinbin@loongson.cn> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: everest,es8323 + + reg: + maxItems: 1 + + clocks: + description: clock for master clock (MCLK) + maxItems: 1 + + clock-names: + const: mclk + + '#sound-dai-cells': + const: 0 + +required: + - compatible + - reg + - '#sound-dai-cells' + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + codec@10 { + compatible = "everest,es8323"; + reg = <0x10>; + #sound-dai-cells = <0>; + }; + };
Add Everest Semiconductor ES8316 low power audio CODEC binding with DT schema format using json-schema. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- .../bindings/sound/everest,es8323.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/everest,es8323.yaml