| Message ID | dc6621dd09b4710c66140b830d0b345682c7b707.1698717154.git.zhoubinbin@loongson.cn |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: interrupt-controller: Fix some loongson,liointc warnings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Oct 31, 2023 at 10:36:36AM +0800, Binbin Zhou wrote: > Since the 'loongson,parent_int_map' attribute naming is non-standard, we > should use 'loongson,parent-int-map' instead. > Also, 'loongson,parent_int_map' should be marked as deprecated. While yes, '-' is preferred over '_', I don't think it is worth carrying support (here and in the kernel) for both. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > --- > .../interrupt-controller/loongson,liointc.yaml | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-)
On Tue, Oct 31, 2023 at 11:50 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Oct 31, 2023 at 10:36:36AM +0800, Binbin Zhou wrote: > > Since the 'loongson,parent_int_map' attribute naming is non-standard, we > > should use 'loongson,parent-int-map' instead. > > Also, 'loongson,parent_int_map' should be marked as deprecated. > > While yes, '-' is preferred over '_', I don't think it is worth carrying > support (here and in the kernel) for both. Hi Rob: We try to keep it compatible as the MIPS Loongson has been using this property for a long time. Krzysztof also thinks it is required. Thanks. Binbin > > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > --- > > .../interrupt-controller/loongson,liointc.yaml | 15 +++++++++++---- > > 1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml index 00b570c82903..0d9511b8a792 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml @@ -55,6 +55,7 @@ properties: const: 2 loongson,parent_int_map: + deprecated: true description: | This property points how the children interrupts will be mapped into CPU interrupt lines. Each cell refers to a parent interrupt line from 0 to 3 @@ -65,14 +66,21 @@ properties: minItems: 4 maxItems: 4 + loongson,parent-int-map: + description: | + Exactly the same as 'loongson,parent_int_map', we just replaced the + unstandardized use of underscores. + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 4 + maxItems: 4 + required: - compatible - reg - interrupts - interrupt-controller - '#interrupt-cells' - - loongson,parent_int_map - + - loongson,parent-int-map unevaluatedProperties: false @@ -109,11 +117,10 @@ examples: interrupts = <2>, <3>; interrupt-names = "int0", "int1"; - loongson,parent_int_map = <0xf0ffffff>, /* int0 */ + loongson,parent-int-map = <0xf0ffffff>, /* int0 */ <0x0f000000>, /* int1 */ <0x00000000>, /* int2 */ <0x00000000>; /* int3 */ - }; ...
Since the 'loongson,parent_int_map' attribute naming is non-standard, we should use 'loongson,parent-int-map' instead. Also, 'loongson,parent_int_map' should be marked as deprecated. Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> --- .../interrupt-controller/loongson,liointc.yaml | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)