| Message ID | 87tti5s81m.wl-kuninori.morimoto.gx@renesas.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ASoC: simple-card / audio-graph: | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Fri, Jun 07, 2024 at 04:15:01AM +0000, Kuninori Morimoto wrote: > Some Sound Card might need special trigger ordering which is based on > CPU/Codec connection. It is already supported on ASoC, but Simple Audio > Card / Audio Graph Card still not support it. Let's support it. I have no idea what trigger order means reading this patch. > > Cc: Maxim Kochetkov <fido_max@inbox.ru> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../devicetree/bindings/sound/audio-graph-port.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml > index 28b27e7e45de6..d1cbfc5edd3ac 100644 > --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml > +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml > @@ -25,6 +25,15 @@ definitions: > capture-only: > description: port connection used only for capture > $ref: /schemas/types.yaml#/definitions/flag > + link-trigger-order: > + description: trigger order for both start/stop > + $ref: /schemas/types.yaml#/definitions/uint32-array > + link-trigger-order-start: > + description: trigger order for start > + $ref: /schemas/types.yaml#/definitions/uint32-array > + link-trigger-order-stop: > + description: trigger order for stop > + $ref: /schemas/types.yaml#/definitions/uint32-array constraints? These are just definitions. Where are the properties defined? > > endpoint-base: > allOf: > -- > 2.43.0 >
Hi Rob > > Some Sound Card might need special trigger ordering which is based on > > CPU/Codec connection. It is already supported on ASoC, but Simple Audio > > Card / Audio Graph Card still not support it. Let's support it. > > I have no idea what trigger order means reading this patch. Sound Card need to consider/adjust HW control ordering by the combination of CPU vs Codec. It is called as trigger in this patch. I will update git-log to more understandable it. Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 28b27e7e45de6..d1cbfc5edd3ac 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -25,6 +25,15 @@ definitions: capture-only: description: port connection used only for capture $ref: /schemas/types.yaml#/definitions/flag + link-trigger-order: + description: trigger order for both start/stop + $ref: /schemas/types.yaml#/definitions/uint32-array + link-trigger-order-start: + description: trigger order for start + $ref: /schemas/types.yaml#/definitions/uint32-array + link-trigger-order-stop: + description: trigger order for stop + $ref: /schemas/types.yaml#/definitions/uint32-array endpoint-base: allOf:
Some Sound Card might need special trigger ordering which is based on CPU/Codec connection. It is already supported on ASoC, but Simple Audio Card / Audio Graph Card still not support it. Let's support it. Cc: Maxim Kochetkov <fido_max@inbox.ru> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- .../devicetree/bindings/sound/audio-graph-port.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)