Message ID | 871qhgo91l.wl-kuninori.morimoto.gx@renesas.com |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | None | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On Mon, Jul 10, 2023 at 10:21:58AM +0900, Kuninori Morimoto wrote: > To enable multi Component support, "multi ports" is needed for Audio Graph > Card/Card2, and "multi rcar_sound,dai" is needed for Simple Audio Card. > This patch enable these. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > .../bindings/sound/renesas,rsnd.yaml | 24 ++++++++++++------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > index d9808b130e8d..13a5a0a10fe6 100644 > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml > @@ -91,6 +91,12 @@ properties: > it must be 1 if your system has audio_clkout0/1/2/3 > enum: [0, 1] > > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > clock-frequency: > description: for audio_clkout0/1/2/3 > > @@ -117,13 +123,7 @@ properties: > description: List of necessary clock names. > # details are defined below > > - ports: > - $ref: audio-graph-port.yaml#/definitions/port-base > - unevaluatedProperties: false > - patternProperties: > - '^port(@[0-9a-f]+)?$': > - $ref: "#/definitions/port-def" > - > + # ports is below > port: > $ref: "#/definitions/port-def" > > @@ -242,8 +242,9 @@ properties: > - interrupts > additionalProperties: false > > +patternProperties: > # For DAI base > - rcar_sound,dai: > + 'rcar_sound,dai(@[0-9a-f]+)?$': With a unit-address you need a 'reg' property. > description: DAI subnode. > type: object > patternProperties: > @@ -263,6 +264,13 @@ properties: > - capture > additionalProperties: false > > + 'ports(@[0-9a-f]+)?$': Multiple 'ports' nodes is not valid. Here too would need a 'reg' property. Did you test any of this because that would be a dtc warning. > + $ref: audio-graph-port.yaml#/definitions/port-base > + unevaluatedProperties: false > + patternProperties: > + '^port(@[0-9a-f]+)?$': > + $ref: "#/definitions/port-def" > + > required: > - compatible > - reg > -- > 2.25.1 >
Hi Rob Thank you for reviewing > > +patternProperties: > > # For DAI base > > - rcar_sound,dai: > > + 'rcar_sound,dai(@[0-9a-f]+)?$': > > With a unit-address you need a 'reg' property. (snip) > Here too would need a 'reg' property. Did you test any of this because > that would be a dtc warning. I don't remember detail, but some reviewer indicated that it is not needed, because we have default "reg" property somewhere/somehow. Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index d9808b130e8d..13a5a0a10fe6 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -91,6 +91,12 @@ properties: it must be 1 if your system has audio_clkout0/1/2/3 enum: [0, 1] + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + clock-frequency: description: for audio_clkout0/1/2/3 @@ -117,13 +123,7 @@ properties: description: List of necessary clock names. # details are defined below - ports: - $ref: audio-graph-port.yaml#/definitions/port-base - unevaluatedProperties: false - patternProperties: - '^port(@[0-9a-f]+)?$': - $ref: "#/definitions/port-def" - + # ports is below port: $ref: "#/definitions/port-def" @@ -242,8 +242,9 @@ properties: - interrupts additionalProperties: false +patternProperties: # For DAI base - rcar_sound,dai: + 'rcar_sound,dai(@[0-9a-f]+)?$': description: DAI subnode. type: object patternProperties: @@ -263,6 +264,13 @@ properties: - capture additionalProperties: false + 'ports(@[0-9a-f]+)?$': + $ref: audio-graph-port.yaml#/definitions/port-base + unevaluatedProperties: false + patternProperties: + '^port(@[0-9a-f]+)?$': + $ref: "#/definitions/port-def" + required: - compatible - reg
To enable multi Component support, "multi ports" is needed for Audio Graph Card/Card2, and "multi rcar_sound,dai" is needed for Simple Audio Card. This patch enable these. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- .../bindings/sound/renesas,rsnd.yaml | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-)