| Message ID | 4afe5640926fac3698abb323cb7be01f32b30ab7.1516239813.git.thinhn@synopsys.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | usb: dwc3: Add new updates for DWC_usb31 | expand |
On Wed, Jan 17, 2018 at 05:57:15PM -0800, Thinh Nguyen wrote: > DWC_usb31 periodic transfer at 48K+ bytes per interval may need > modification to the TX/RX packet threshold to achieve optimal result. > Add properties to make it configurable. > > Cc: John Youn <johnyoun@synopsys.com> > Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > index 52fb41046b34..a532fa6bf884 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -55,6 +55,10 @@ Optional properties: > - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ > register for post-silicon frame length adjustment when the > fladj_30mhz_sdbnd signal is invalid or incorrect. > + - snps,rx-thr-num-pkt-prd: periodic ESS RX packet threshold count. > + - snps,rx-max-burst-prd: Max periodic ESS RX burst size. > + - snps,tx-thr-num-pkt-prd: periodic ESS TX packet threshold count. > + - snps,tx-max-burst-prd: Max periodic ESS TX burst size. What are the defaults if not set? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 1/29/2018 10:46 AM, Rob Herring wrote: > On Wed, Jan 17, 2018 at 05:57:15PM -0800, Thinh Nguyen wrote: >> DWC_usb31 periodic transfer at 48K+ bytes per interval may need >> modification to the TX/RX packet threshold to achieve optimal result. >> Add properties to make it configurable. >> >> Cc: John Youn <johnyoun@synopsys.com> >> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt >> index 52fb41046b34..a532fa6bf884 100644 >> --- a/Documentation/devicetree/bindings/usb/dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt >> @@ -55,6 +55,10 @@ Optional properties: >> - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ >> register for post-silicon frame length adjustment when the >> fladj_30mhz_sdbnd signal is invalid or incorrect. >> + - snps,rx-thr-num-pkt-prd: periodic ESS RX packet threshold count. >> + - snps,rx-max-burst-prd: Max periodic ESS RX burst size. >> + - snps,tx-thr-num-pkt-prd: periodic ESS TX packet threshold count. >> + - snps,tx-max-burst-prd: Max periodic ESS TX burst size. > > What are the defaults if not set? > By default, periodic ESS TX and RX threshold are not enabled. To enable TX or RX threshold, both packet threshold count and max burst size must be set to a non-zero value. Unfortunately, I did not document it in this file after I made a change to remove the enabling of TX/RX threshold property. I can update this patch series with this information. Thanks. BR, Thinh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt index 52fb41046b34..a532fa6bf884 100644 --- a/Documentation/devicetree/bindings/usb/dwc3.txt +++ b/Documentation/devicetree/bindings/usb/dwc3.txt @@ -55,6 +55,10 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,rx-thr-num-pkt-prd: periodic ESS RX packet threshold count. + - snps,rx-max-burst-prd: Max periodic ESS RX burst size. + - snps,tx-thr-num-pkt-prd: periodic ESS TX packet threshold count. + - snps,tx-max-burst-prd: Max periodic ESS TX burst size. - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.
DWC_usb31 periodic transfer at 48K+ bytes per interval may need modification to the TX/RX packet threshold to achieve optimal result. Add properties to make it configurable. Cc: John Youn <johnyoun@synopsys.com> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> --- Documentation/devicetree/bindings/usb/dwc3.txt | 4 ++++ 1 file changed, 4 insertions(+)