| Message ID | 48055c01f7da7ba4e1592090d3bfedb0ac321bb0.1726142726.git.michal.simek@amd.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: serial: rs485: Fix rs485-rts-delay property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 27 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, Sep 12, 2024 at 02:05:28PM +0200, Michal Simek wrote: > Code expects array only with 2 items which should be checked. > But also item checking is not working as it should likely because of > incorrect items description. > > Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema") > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > .../devicetree/bindings/serial/rs485.yaml | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml > index 9418fd66a8e9..fa9ad68ed24b 100644 > --- a/Documentation/devicetree/bindings/serial/rs485.yaml > +++ b/Documentation/devicetree/bindings/serial/rs485.yaml > @@ -17,17 +17,17 @@ properties: > rs485-rts-delay: > description: prop-encoded-array <a b> > $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 2 > items: > - items: > - - description: Delay between rts signal and beginning of data sent in > - milliseconds. It corresponds to the delay before sending data. > - default: 0 > - maximum: 100 > - - description: Delay between end of data sent and rts signal in milliseconds. > - It corresponds to the delay after sending data and actual release > - of the line. > - default: 0 > - maximum: 100 > + - description: Delay between rts signal and beginning of data sent in > + milliseconds. It corresponds to the delay before sending data. > + default: 0 > + maximum: 50 > + - description: Delay between end of data sent and rts signal in milliseconds. > + It corresponds to the delay after sending data and actual release > + of the line. > + default: 0 > + maximum: 100 > > rs485-rts-active-high: > description: drive RTS high when sending (this is the default). > -- > 2.43.0 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
On Thu, 12 Sep 2024 14:05:28 +0200, Michal Simek wrote: > Code expects array only with 2 items which should be checked. > But also item checking is not working as it should likely because of > incorrect items description. > > Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema") > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > .../devicetree/bindings/serial/rs485.yaml | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/rs485.yaml: properties:rs485-rts-delay: {'description': 'prop-encoded-array <a b>', '$ref': '/schemas/types.yaml#/definitions/uint32-array', 'maxItems': 2, 'items': [{'description': 'Delay between rts signal and beginning of data sent in milliseconds. It corresponds to the delay before sending data.', 'default': 0, 'maximum': 50}, {'description': 'Delay between end of data sent and rts signal in milliseconds. It corresponds to the delay after sending data and actual release of the line.', 'default': 0, 'maximum': 100}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/48055c01f7da7ba4e1592090d3bfedb0ac321bb0.1726142726.git.michal.simek@amd.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml index 9418fd66a8e9..fa9ad68ed24b 100644 --- a/Documentation/devicetree/bindings/serial/rs485.yaml +++ b/Documentation/devicetree/bindings/serial/rs485.yaml @@ -17,17 +17,17 @@ properties: rs485-rts-delay: description: prop-encoded-array <a b> $ref: /schemas/types.yaml#/definitions/uint32-array + maxItems: 2 items: - items: - - description: Delay between rts signal and beginning of data sent in - milliseconds. It corresponds to the delay before sending data. - default: 0 - maximum: 100 - - description: Delay between end of data sent and rts signal in milliseconds. - It corresponds to the delay after sending data and actual release - of the line. - default: 0 - maximum: 100 + - description: Delay between rts signal and beginning of data sent in + milliseconds. It corresponds to the delay before sending data. + default: 0 + maximum: 50 + - description: Delay between end of data sent and rts signal in milliseconds. + It corresponds to the delay after sending data and actual release + of the line. + default: 0 + maximum: 100 rs485-rts-active-high: description: drive RTS high when sending (this is the default).
Code expects array only with 2 items which should be checked. But also item checking is not working as it should likely because of incorrect items description. Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema") Signed-off-by: Michal Simek <michal.simek@amd.com> --- .../devicetree/bindings/serial/rs485.yaml | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)