From patchwork Thu Oct 15 22:39:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 530963 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 018EA140E3A for ; Fri, 16 Oct 2015 09:39:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbbJOWjs (ORCPT ); Thu, 15 Oct 2015 18:39:48 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:36598 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbbJOWjr (ORCPT ); Thu, 15 Oct 2015 18:39:47 -0400 Received: by lbcao8 with SMTP id ao8so85946065lbc.3 for ; Thu, 15 Oct 2015 15:39:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=612eUSh98slQobXK0pMSFkuZyIoWp38SLWF7ihqOIAY=; b=bAghsMITz1eQxU5RhGUHavvdMFyRdzdAU9pJd2jByEemOxjeMp68UxpPxSvHrX8jDO 7e1kBLd1TfIsVuD2C57tL0bFEip9Ss1HNKJwLFPD31t1Jdm2e6Q0TT6ukWcjG0JS1DaG me4VU23qjzQymC/qJ/4K8DMA/cnCqw+c1fH1JkPcg8L7kGgK42T/sojBu+Wbkra/3usT o5cT9bgAKHDTuzc3Uc7EFh8BIe0EG5o3wFIvHudi3Ru+EPxGMwOLD3x27XBXxHgZkypl cyKIdH/QVdqPxUYooFwz9g2kT0HCvBwntf6HnH36xgV/ywycB5F5ZCRZ2ifa6Stwa2cC i49w== X-Gm-Message-State: ALoCoQlC9Ob8rTyCFx/3Q/RD7v3FEs/pcbyEWhRLewN0i4Ih5+SAT+66GjNOpcWrwZioujkf2+0X X-Received: by 10.112.169.98 with SMTP id ad2mr6032696lbc.2.1444948786054; Thu, 15 Oct 2015 15:39:46 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp83-237-249-221.pppoe.mtu-net.ru. [83.237.249.221]) by smtp.gmail.com with ESMTPSA id p133sm2388328lfp.16.2015.10.15.15.39.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2015 15:39:44 -0700 (PDT) From: Sergei Shtylyov To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org Cc: linux-sh@vger.kernel.org Subject: [PATCH v3] DT: mmc: sh_mmcif: fix "compatible" property text Date: Fri, 16 Oct 2015 01:39:39 +0300 Message-ID: <2188985.g7lrY44qCa@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.9 (Linux/4.1.8-100.fc21.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <201404250239.39150.sergei.shtylyov@cogentembedded.com> References: <201404250239.39150.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value. Fixes: b4c27763d749 ("mmc: sh_mmcif: Document DT bindings") Signed-off-by: Sergei Shtylyov Acked-by: Geert Uytterhoeven --- The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' or 'next' branches. Changes in version 3: - reworded the "compatible" property description to look like the majority of the Renesas bindings. Changes in version 2: - kept the SoC specific "compatible" property values mandatory and made the generic string a fallback. Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt =================================================================== --- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt @@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties: -- compatible: must contain one of the following +- compatible: should be "renesas,mmcif-", "renesas,sh-mmcif" as a + fallback. Examples with are: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF - clocks: reference to the functional clock