| Message ID | 20241104092220.2268805-1-naresh.solanki@9elements.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v6,1/2] dt-bindings: arm: aspeed: add IBM SBP1 board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, 04 Nov 2024 14:52:14 +0530, Naresh Solanki wrote: > Document the new compatibles used on IBM SBP1. > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > Changes in V4: > - Retain Acked-by from v2. > - Fix alphabetic order > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-sbp1.dtb' for 20241104092220.2268805-1-naresh.solanki@9elements.com: arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: timer: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/timer/arm,arch_timer.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /sdram@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2600-sdram-edac', 'syscon'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: bus@1e600000: compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long from schema $id: http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: syscon@1e6e2000: 'smp-memram@180' does not match any of the regexes: '^interrupt-controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-9a-f]+)?$', '^silicon-id@[0-9a-f]+$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/syscon@1e6e2000/smp-memram@180: failed to match any schema with compatible: ['aspeed,ast2600-smpmem'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@560: failed to match any schema with compatible: ['aspeed,ast2600-scu-ic0'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@570: failed to match any schema with compatible: ['aspeed,ast2600-scu-ic1'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2600-gfx', 'syscon'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9100: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: crypto@1e6fa000: 'aspeed,ahbc' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/crypto/aspeed,ast2600-acry.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/video@1e700000: failed to match any schema with compatible: ['aspeed,ast2600-video-engine'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000: sdhci@1e740100:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long from schema $id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000: sdhci@1e740200:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long from schema $id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/sdc@1e740000/sdhci@1e740100: failed to match any schema with compatible: ['aspeed,ast2600-sdhci', 'sdhci'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/sdc@1e740000/sdhci@1e740200: failed to match any schema with compatible: ['aspeed,ast2600-sdhci', 'sdhci'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2600-timer'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000: lpc-snoop@80: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000: reg-io-width: 4 is not of type 'object' from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@24: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@28: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@2c: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@114: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2600-lhc'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/lpc@1e789000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2600-ibt-bmc'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/bus@1e78a000/i2c@280/bmc-slave@10: failed to match any schema with compatible: ['ipmb-dev'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b000: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long from schema $id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e790000/fsi@1e79b000: failed to match any schema with compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b100: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long from schema $id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e790000/fsi@1e79b100: failed to match any schema with compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e790000/dma-controller@1e79e000: failed to match any schema with compatible: ['aspeed,ast2600-udma']
On Mon, Nov 04, 2024 at 08:39:21AM -0600, Rob Herring (Arm) wrote: > > On Mon, 04 Nov 2024 14:52:14 +0530, Naresh Solanki wrote: > > Document the new compatibles used on IBM SBP1. > > > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > Changes in V4: > > - Retain Acked-by from v2. > > - Fix alphabetic order > > --- > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-sbp1.dtb' for 20241104092220.2268805-1-naresh.solanki@9elements.com: Really? This many warnings on a v6? > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: timer: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/timer/arm,arch_timer.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /sdram@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2600-sdram-edac', 'syscon'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: bus@1e600000: compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long > from schema $id: http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: syscon@1e6e2000: 'smp-memram@180' does not match any of the regexes: '^interrupt-controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-9a-f]+)?$', '^silicon-id@[0-9a-f]+$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/syscon@1e6e2000/smp-memram@180: failed to match any schema with compatible: ['aspeed,ast2600-smpmem'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@560: failed to match any schema with compatible: ['aspeed,ast2600-scu-ic0'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@570: failed to match any schema with compatible: ['aspeed,ast2600-scu-ic1'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e6e0000/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2600-gfx', 'syscon'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9100: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: crypto@1e6fa000: 'aspeed,ahbc' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/crypto/aspeed,ast2600-acry.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/video@1e700000: failed to match any schema with compatible: ['aspeed,ast2600-video-engine'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000: sdhci@1e740100:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long > from schema $id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000: sdhci@1e740200:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long > from schema $id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/sdc@1e740000/sdhci@1e740100: failed to match any schema with compatible: ['aspeed,ast2600-sdhci', 'sdhci'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/sdc@1e740000/sdhci@1e740200: failed to match any schema with compatible: ['aspeed,ast2600-sdhci', 'sdhci'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2600-timer'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000: lpc-snoop@80: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000: reg-io-width: 4 is not of type 'object' > from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@24: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@28: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@2c: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@114: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2600-lhc'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/lpc@1e789000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2600-ibt-bmc'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e780000/bus@1e78a000/i2c@280/bmc-slave@10: failed to match any schema with compatible: ['ipmb-dev'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b000: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long > from schema $id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e790000/fsi@1e79b000: failed to match any schema with compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b100: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long > from schema $id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e790000/fsi@1e79b100: failed to match any schema with compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /ahb/apb@1e790000/dma-controller@1e79e000: failed to match any schema with compatible: ['aspeed,ast2600-udma'] > > > > >
Hi Conor, On Mon, 2024-11-04 at 18:49 +0000, Conor Dooley wrote: > On Mon, Nov 04, 2024 at 08:39:21AM -0600, Rob Herring (Arm) wrote: > > > > On Mon, 04 Nov 2024 14:52:14 +0530, Naresh Solanki wrote: > > > Document the new compatibles used on IBM SBP1. > > > > > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > --- > > > Changes in V4: > > > - Retain Acked-by from v2. > > > - Fix alphabetic order > > > --- > > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in > > this > > series. > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the > > warnings > > are fixed by another series. Ultimately, it is up to the platform > > maintainer whether these warnings are acceptable or not. No need to > > reply > > unless the platform maintainer has comments. > > > > If you already ran DT checks and didn't see these error(s), then > > make sure dt-schema is up to date: > > > > pip3 install dtschema --upgrade > > > > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm- > > sbp1.dtb' for > > 20241104092220.2268805-1-naresh.solanki@9elements.com: > > Really? This many warnings on a v6? > I understand that it's surprising and disappointing, however these warnings are from the Aspeed DTSIs and not directly from the proposed DTS. Many are an artefact of history, and I'm (slowly) working to clean them up. Recently I haven't had any time to dedicate to that effort, and as I'm somewhat responsible for the state of things, I'm not prepared to block other people's patches and push my own responsibilities onto them. I've been replying to those proposing new Aspeed-based devicetrees to separate the warnings they're introducing from the warnings that already exist, and requiring them to fix the issues they're responsible for. I hope that I'll have time to continue to improve the situation, as this is obviously a tedious task for me too. Andrew > > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: timer: 'clocks' > > does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/timer/arm,arch_timer.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: /sdram@1e6e0000: > > failed to match any schema with compatible: ['aspeed,ast2600-sdram- > > edac', 'syscon'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: bus@1e600000: > > compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long > > from schema $id: > > http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: syscon@1e6e2000: > > 'smp-memram@180' does not match any of the regexes: '^interrupt- > > controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0- > > 9a-f]+)?$', '^silicon-id@[0-9a-f]+$', 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e6e0000/syscon@1e6e2000/smp-memram@180: failed to match > > any schema with compatible: ['aspeed,ast2600-smpmem'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@560: failed > > to match any schema with compatible: ['aspeed,ast2600-scu-ic0'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e6e0000/syscon@1e6e2000/interrupt-controller@570: failed > > to match any schema with compatible: ['aspeed,ast2600-scu-ic1'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e6e0000/display@1e6e6000: failed to match any schema with > > compatible: ['aspeed,ast2600-gfx', 'syscon'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9000: > > 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: adc@1e6e9100: > > 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: crypto@1e6fa000: > > 'aspeed,ahbc' does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/crypto/aspeed,ast2600-acry.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/video@1e700000: failed to match any schema with compatible: > > ['aspeed,ast2600-video-engine'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000: > > sdhci@1e740100:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too > > long > > from schema $id: > > http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: sdc@1e740000: > > sdhci@1e740200:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too > > long > > from schema $id: > > http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/sdc@1e740000/sdhci@1e740100: failed to match any schema with > > compatible: ['aspeed,ast2600-sdhci', 'sdhci'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/sdc@1e740000/sdhci@1e740200: failed to match any schema with > > compatible: ['aspeed,ast2600-sdhci', 'sdhci'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e780000/timer@1e782000: failed to match any schema with > > compatible: ['aspeed,ast2600-timer'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000: > > lpc-snoop@80: 'clocks' does not match any of the regexes: 'pinctrl- > > [0-9]+' > > from schema $id: > > http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: lpc@1e789000: > > reg-io-width: 4 is not of type 'object' > > from schema $id: > > http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@24: 'clocks' > > does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@28: 'clocks' > > does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@2c: 'clocks' > > does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: kcs@114: 'clocks' > > does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: > > http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e780000/lpc@1e789000/lhc@a0: failed to match any schema > > with compatible: ['aspeed,ast2600-lhc'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e780000/lpc@1e789000/ibt@140: failed to match any schema > > with compatible: ['aspeed,ast2600-ibt-bmc'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e780000/bus@1e78a000/i2c@280/bmc-slave@10: failed to > > match any schema with compatible: ['ipmb-dev'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b000: > > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long > > from schema $id: > > http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e790000/fsi@1e79b000: failed to match any schema with > > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: fsi@1e79b100: > > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long > > from schema $id: > > http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml# > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e790000/fsi@1e79b100: failed to match any schema with > > compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: > > /ahb/apb@1e790000/dma-controller@1e79e000: failed to match any > > schema with compatible: ['aspeed,ast2600-udma'] > > > > > > > > > >
On Mon, 2024-11-04 at 14:52 +0530, Naresh Solanki wrote: > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > Add a device tree for IBM sbp1 BMC board which is based on AST2600 > SOC. > > sbp1 baseboard has: > - support for up to four Sapphire Rapids sockets having 16 DIMMS > each. > - 240 core/480 threads at maximum > - 32x CPU PCIe slots > - 2x M.2 PCH PCIe slots > - Dual 200Gbit/s NIC > - SPI TPM > > Added the following: > - Indication LEDs > - I2C mux & GPIO controller, pin assignments, > - Thermister, > - Voltage regulator > - EEPROM/VPD > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > > --- > Changes in V6: > - Verified all regulators warning resolved. How did you verify this? Testing the patches locally, I see: +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# From a spot check, the warnings seem legitimate. Did you send the right patches? Andrew
Hi Andrew, On Tue, 5 Nov 2024 at 06:03, Andrew Jeffery <andrew@codeconstruct.com.au> wrote: > > On Mon, 2024-11-04 at 14:52 +0530, Naresh Solanki wrote: > > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > > > Add a device tree for IBM sbp1 BMC board which is based on AST2600 > > SOC. > > > > sbp1 baseboard has: > > - support for up to four Sapphire Rapids sockets having 16 DIMMS > > each. > > - 240 core/480 threads at maximum > > - 32x CPU PCIe slots > > - 2x M.2 PCH PCIe slots > > - Dual 200Gbit/s NIC > > - SPI TPM > > > > Added the following: > > - Indication LEDs > > - I2C mux & GPIO controller, pin assignments, > > - Thermister, > > - Voltage regulator > > - EEPROM/VPD > > > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > > > > --- > > Changes in V6: > > - Verified all regulators warning resolved. > > How did you verify this? Testing the patches locally, I see: > > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > + from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > From a spot check, the warnings seem legitimate. Did you send the right > patches? Just checked again. They are resolved. But I guess the dtbinding patch for the above warning are merged in hwmon-next branch & not in dt/next Regards, Naresh > > Andrew
On 11/4/24 20:10, Naresh Solanki wrote: [ ... ] >> From a spot check, the warnings seem legitimate. Did you send the right >> patches? > Just checked again. They are resolved. But I guess the dtbinding patch > for the above warning are merged in hwmon-next branch & not in dt/next > Did I apply some patches which should have been applied elsewhere ? If so, please let me know, and I'll drop them. Guenter
Hi Andrew, Guenter, @Andrew Shall I resend this patch series along with dependent dt-binding patches ? On Tue, 5 Nov 2024 at 21:17, Guenter Roeck <linux@roeck-us.net> wrote: > > On 11/4/24 20:10, Naresh Solanki wrote: > [ ... ] > > >> From a spot check, the warnings seem legitimate. Did you send the right > >> patches? > > Just checked again. They are resolved. But I guess the dtbinding patch > > for the above warning are merged in hwmon-next branch & not in dt/next > > > > Did I apply some patches which should have been applied elsewhere ? I think it should be fine. Regards, Naresh > > If so, please let me know, and I'll drop them. > > Guenter >
On Tue, Nov 05, 2024 at 10:39:34AM +1030, Andrew Jeffery wrote: > Hi Conor, > > On Mon, 2024-11-04 at 18:49 +0000, Conor Dooley wrote: > > On Mon, Nov 04, 2024 at 08:39:21AM -0600, Rob Herring (Arm) wrote: > > > > > > On Mon, 04 Nov 2024 14:52:14 +0530, Naresh Solanki wrote: > > > > Document the new compatibles used on IBM SBP1. > > > > > > > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > --- > > > > Changes in V4: > > > > - Retain Acked-by from v2. > > > > - Fix alphabetic order > > > > --- > > > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in > > > this > > > series. > > > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the > > > warnings > > > are fixed by another series. Ultimately, it is up to the platform > > > maintainer whether these warnings are acceptable or not. No need to > > > reply > > > unless the platform maintainer has comments. > > > > > > If you already ran DT checks and didn't see these error(s), then > > > make sure dt-schema is up to date: > > > > > > pip3 install dtschema --upgrade > > > > > > > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm- > > > sbp1.dtb' for > > > 20241104092220.2268805-1-naresh.solanki@9elements.com: > > > > Really? This many warnings on a v6? > > > > I understand that it's surprising and disappointing, however these > warnings are from the Aspeed DTSIs and not directly from the proposed > DTS. Many are an artefact of history, and I'm (slowly) working to clean > them up. Recently I haven't had any time to dedicate to that effort, > and as I'm somewhat responsible for the state of things, I'm not > prepared to block other people's patches and push my own > responsibilities onto them. Ah, you see that's where I would say "no new warnings" and get the submitter to fix them ;) And were I the submitter, I'd want to resolve the warnings rather than run into issues down the road when things get "fixed"/documented. But I guess that's why I have the schmucks task of reviewing bindings innit.. > I've been replying to those proposing new Aspeed-based devicetrees to > separate the warnings they're introducing from the warnings that > already exist, and requiring them to fix the issues they're responsible > for. I hope that I'll have time to continue to improve the situation, > as this is obviously a tedious task for me too. Well, it is your platform and if you're confident that these nodes are correct despite the warnings, who am I to stop you!
On Tue, 2024-11-05 at 07:47 -0800, Guenter Roeck wrote: > On 11/4/24 20:10, Naresh Solanki wrote: > [ ... ] > > > > From a spot check, the warnings seem legitimate. Did you send > > > the right > > > patches? > > Just checked again. They are resolved. But I guess the dtbinding > > patch > > for the above warning are merged in hwmon-next branch & not in > > dt/next > > > > Did I apply some patches which should have been applied elsewhere ? > > If so, please let me know, and I'll drop them. No need to drop anything for now: It was just that bindings for some hwmon devices defined in hwmon-next are used in Naresh's devicetree here. Merging hwmon-next and applying his patches resolves my concerns. Unless anyone feels otherwise, I expect we can can carry on independently with the understanding it will be resolved in the same way at the next rc1 (barring any other concerns with Naresh's patches). Andrew
On Tue, 2024-11-05 at 18:53 +0000, Conor Dooley wrote: > On Tue, Nov 05, 2024 at 10:39:34AM +1030, Andrew Jeffery wrote: > > Hi Conor, > > > > On Mon, 2024-11-04 at 18:49 +0000, Conor Dooley wrote: > > > On Mon, Nov 04, 2024 at 08:39:21AM -0600, Rob Herring (Arm) > > > wrote: > > > > > > > > On Mon, 04 Nov 2024 14:52:14 +0530, Naresh Solanki wrote: > > > > > Document the new compatibles used on IBM SBP1. > > > > > > > > > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > --- > > > > > Changes in V4: > > > > > - Retain Acked-by from v2. > > > > > - Fix alphabetic order > > > > > --- > > > > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 > > > > > + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > > My bot found new DTB warnings on the .dts files added or > > > > changed in > > > > this > > > > series. > > > > > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the > > > > warnings > > > > are fixed by another series. Ultimately, it is up to the > > > > platform > > > > maintainer whether these warnings are acceptable or not. No > > > > need to > > > > reply > > > > unless the platform maintainer has comments. > > > > > > > > If you already ran DT checks and didn't see these error(s), > > > > then > > > > make sure dt-schema is up to date: > > > > > > > > pip3 install dtschema --upgrade > > > > > > > > > > > > New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm- > > > > sbp1.dtb' for > > > > 20241104092220.2268805-1-naresh.solanki@9elements.com: > > > > > > Really? This many warnings on a v6? > > > > > > > I understand that it's surprising and disappointing, however these > > warnings are from the Aspeed DTSIs and not directly from the > > proposed > > DTS. Many are an artefact of history, and I'm (slowly) working to > > clean > > them up. Recently I haven't had any time to dedicate to that > > effort, > > and as I'm somewhat responsible for the state of things, I'm not > > prepared to block other people's patches and push my own > > responsibilities onto them. > > Ah, you see that's where I would say "no new warnings" and get the > submitter to fix them ;) And were I the submitter, I'd want to > resolve > the warnings rather than run into issues down the road when things > get > "fixed"/documented.But I guess that's why I have the schmucks task of > reviewing bindings innit.. I have to manage that in tension with my concern of people simply not upstreaming their devicetrees in response. I'd prefer to have them merged upstream than to encourage more forks in this corner of the world. If people would like to take the initiative and do the binding conversions, corrections and devicetree fixes themselves, I'll definitely review them. > > > I've been replying to those proposing new Aspeed-based devicetrees > > to > > separate the warnings they're introducing from the warnings that > > already exist, and requiring them to fix the issues they're > > responsible > > for. I hope that I'll have time to continue to improve the > > situation, > > as this is obviously a tedious task for me too. > > Well, it is your platform and if you're confident that these nodes > are > correct despite the warnings, who am I to stop you! I think where things stand currently is a bit fuzzier than anyone would like. The nodes are not incorrect to the point of being non-functional with respect to their intent, but clearly they're not so correct that they do not have room for improvement. Andrew
On Mon, 04 Nov 2024 14:52:14 +0530, Naresh Solanki wrote: > Document the new compatibles used on IBM SBP1. > > Thanks, I've applied this to be picked up through the BMC tree. -- Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 2f92b8ab08fa..c79c74ab3d78 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -91,6 +91,7 @@ properties: - ibm,everest-bmc - ibm,fuji-bmc - ibm,rainier-bmc + - ibm,sbp1-bmc - ibm,system1-bmc - ibm,tacoma-bmc - inventec,starscream-bmc