| Message ID | 20241031-tcan-wkrqv-v1-2-823dbd12fe4a@geanix.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | can: tcan4x5x: add option for selecting nWKRQ voltage | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On Thu, Oct 31, 2024 at 02:24:22PM +0100, Sean Nyekjaer wrote: > nWKRQ supports an output voltage of either the internal reference voltage > (3.6V) or the reference voltage of the digital interface 0 - 6V. > Add the devicetree option ti,nwkrq-voltage-sel to be able to select > between them. > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > --- Please convert the bindings first to DT schema and only then add new properties. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt index 20c0572c9853424e1d104cbf75d02094a54836c3..f6f8b9e44c0c8dab09a0b7e3bc17d4230fcefab7 100644 --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt @@ -23,6 +23,12 @@ required property details. Optional properties: - reset-gpios: Hardwired output GPIO. If not defined then software reset. + - ti,nwkrq-voltage-sel: nWKRQ Pin GPO buffer voltage rail configuration. + The option of this properties will tell which + voltage rail is used for the nWKRQ Pin. + Valid values are 0 and 1. + 0: Internal voltage rail + 1: VIO voltage rail - device-state-gpios: Input GPIO that indicates if the device is in a sleep state or if the device is active. Not available with tcan4552/4553. @@ -44,5 +50,6 @@ tcan4x5x: tcan4x5x@0 { device-state-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; device-wake-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>; + ti,nwkrq-voltage-sel = /bits/ 8 <0>; wakeup-source; };
nWKRQ supports an output voltage of either the internal reference voltage (3.6V) or the reference voltage of the digital interface 0 - 6V. Add the devicetree option ti,nwkrq-voltage-sel to be able to select between them. Signed-off-by: Sean Nyekjaer <sean@geanix.com> --- Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 7 +++++++ 1 file changed, 7 insertions(+)