diff mbox series

[2/3] dt-bindings: arm: rockchip: add Banana Pi BPI-P2 Pro board

Message ID 20241028213314.476776-3-dmt.yashin@gmail.com
State Superseded
Headers show
Series arm64: dts: rockchip: add Banana Pi BPI-P2 Pro board | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Dmitry Yashin Oct. 28, 2024, 9:33 p.m. UTC
Banana Pi BPI-P2 Pro is the SBC made by Shenzhen SINOVOIP based on
Rockchip RK3308.

Banana Pi BPI-P2 Pro features:
- Rockchip RK3308B-S
- DDR3 512 MB
- eMMC 8 GB
- 100M lan + onboard PoE
- 40 pin and 12 pin headers
- AP6256 BT + WIFI
- TF card slot
- 2x USB 2.0 (Type-C OTG and Type-A)
- Headphone jack

Add devicetree binding for Banana Pi BPI-P2 Pro.

Signed-off-by: Dmitry Yashin <dmt.yashin@gmail.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Heiko Stübner Oct. 29, 2024, 5:57 a.m. UTC | #1
Am Montag, 28. Oktober 2024, 22:33:13 CET schrieb Dmitry Yashin:
> Banana Pi BPI-P2 Pro is the SBC made by Shenzhen SINOVOIP based on
> Rockchip RK3308.
> 
> Banana Pi BPI-P2 Pro features:
> - Rockchip RK3308B-S
> - DDR3 512 MB
> - eMMC 8 GB
> - 100M lan + onboard PoE
> - 40 pin and 12 pin headers
> - AP6256 BT + WIFI
> - TF card slot
> - 2x USB 2.0 (Type-C OTG and Type-A)
> - Headphone jack
> 
> Add devicetree binding for Banana Pi BPI-P2 Pro.
> 
> Signed-off-by: Dmitry Yashin <dmt.yashin@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1e3eceb266b7..0c85c15d5c04 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1104,6 +1104,11 @@ properties:
>            - const: rockchip,rk3568-evb1-v10
>            - const: rockchip,rk3568
>  
> +      - description: Sinovoip RK3308 Banana Pi BPI-P2 Pro

isn't BPI the short form of Banana Pi?
So the naming is sort of double and I'd expect it to be
    Sinovoip RK3308 BanaPi P2 Pro
similar to how the R2 below does is?


Heiko

> +        items:
> +          - const: sinovoip,rk3308-bpi-p2pro
> +          - const: rockchip,rk3308
> +
>        - description: Sinovoip RK3568 Banana Pi R2 Pro
>          items:
>            - const: sinovoip,rk3568-bpi-r2pro
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 1e3eceb266b7..0c85c15d5c04 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -1104,6 +1104,11 @@  properties:
           - const: rockchip,rk3568-evb1-v10
           - const: rockchip,rk3568
 
+      - description: Sinovoip RK3308 Banana Pi BPI-P2 Pro
+        items:
+          - const: sinovoip,rk3308-bpi-p2pro
+          - const: rockchip,rk3308
+
       - description: Sinovoip RK3568 Banana Pi R2 Pro
         items:
           - const: sinovoip,rk3568-bpi-r2pro