diff mbox series

[v4,net-next,01/13] dt-bindings: net: add compatible string for i.MX95 EMDIO

Message ID 20241022055223.382277-2-wei.fang@nxp.com
State Not Applicable
Headers show
Series add basic support for i.MX95 NETC | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Wei Fang Oct. 22, 2024, 5:52 a.m. UTC 
The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
ID and device ID have also changed, so add the new compatible strings
for i.MX95 EMDIO.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
---
v2: remove "nxp,netc-emdio" compatible string.
v3: no changes
v4: no changes
---
 .../devicetree/bindings/net/fsl,enetc-mdio.yaml       | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Vladimir Oltean Oct. 24, 2024, 2:06 p.m. UTC | #1 
On Tue, Oct 22, 2024 at 01:52:11PM +0800, Wei Fang wrote:
> The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
> ID and device ID have also changed, so add the new compatible strings
> for i.MX95 EMDIO.
> 
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Vladimir Oltean Oct. 24, 2024, 2:16 p.m. UTC | #2 
On Thu, Oct 24, 2024 at 05:06:23PM +0300, Vladimir Oltean wrote:
> On Tue, Oct 22, 2024 at 01:52:11PM +0800, Wei Fang wrote:
> > The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
> > ID and device ID have also changed, so add the new compatible strings
> > for i.MX95 EMDIO.
> > 
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Sorry, the v4 thread popped up in the top of my email client list due to
the unfinished dt-bindings discussion, I meant to post the tag on v5
(which I now see that it shouldn't have been posted until said discussion
had settled).
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
index c1dd6aa04321..71c43ece8295 100644
--- a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
@@ -20,10 +20,13 @@  maintainers:
 
 properties:
   compatible:
-    items:
-      - enum:
-          - pci1957,ee01
-      - const: fsl,enetc-mdio
+    oneOf:
+      - items:
+          - enum:
+              - pci1957,ee01
+          - const: fsl,enetc-mdio
+      - items:
+          - const: pci1131,ee00
 
   reg:
     maxItems: 1