| Message ID | 20241011063112.19087-3-quic_qqzhou@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for APPS SMMU on QCS615 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 11/10/2024 08:31, Qingqing Zhou wrote: > Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function > is required by multiple functions including USB/UFS/Ethernet. Do not explain what SMMU is, because it is obvious, but explain how this hardware differs from everything existing. > > Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com> > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index 92d350b8e01a..9e62c2cdda08 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -36,6 +36,7 @@ properties: > items: > - enum: > - qcom,qcm2290-smmu-500 > + - qcom,qcs615-smmu-500 This is incomplete? No clocks? No power-domains? Best regards, Krzysztof
在 10/11/2024 2:48 PM, Krzysztof Kozlowski 写道: > On 11/10/2024 08:31, Qingqing Zhou wrote: >> Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function >> is required by multiple functions including USB/UFS/Ethernet. > > Do not explain what SMMU is, because it is obvious, but explain how this > hardware differs from everything existing. OK, will improve the comments in next patch version. > >> >> Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com> >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 92d350b8e01a..9e62c2cdda08 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -36,6 +36,7 @@ properties: >> items: >> - enum: >> - qcom,qcm2290-smmu-500 >> + - qcom,qcs615-smmu-500 > > This is incomplete? No clocks? No power-domains? This is APPS SMMU, no clocks and no power-domains are needed for DT. > > Best regards, > Krzysztof >
On 14/10/2024 05:09, Qingqing Zhou wrote: >>> --- >>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> index 92d350b8e01a..9e62c2cdda08 100644 >>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>> @@ -36,6 +36,7 @@ properties: >>> items: >>> - enum: >>> - qcom,qcm2290-smmu-500 >>> + - qcom,qcs615-smmu-500 >> >> This is incomplete? No clocks? No power-domains? > This is APPS SMMU, no clocks and no power-domains are needed for DT. Then express it in the binding. Best regards, Krzysztof
在 10/14/2024 2:52 PM, Krzysztof Kozlowski 写道: > On 14/10/2024 05:09, Qingqing Zhou wrote: >>>> --- >>>> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> index 92d350b8e01a..9e62c2cdda08 100644 >>>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >>>> @@ -36,6 +36,7 @@ properties: >>>> items: >>>> - enum: >>>> - qcom,qcm2290-smmu-500 >>>> + - qcom,qcs615-smmu-500 >>> >>> This is incomplete? No clocks? No power-domains? >> This is APPS SMMU, no clocks and no power-domains are needed for DT. > > Then express it in the binding. OK, will add this in next patch version. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml index 92d350b8e01a..9e62c2cdda08 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml @@ -36,6 +36,7 @@ properties: items: - enum: - qcom,qcm2290-smmu-500 + - qcom,qcs615-smmu-500 - qcom,qcs8300-smmu-500 - qcom,qdu1000-smmu-500 - qcom,sa8255p-smmu-500
Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function is required by multiple functions including USB/UFS/Ethernet. Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com> --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + 1 file changed, 1 insertion(+)