diff mbox series

[v6,1/7] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string

Message ID 20240926195700.2823751-1-marex@denx.de
State Not Applicable
Headers show
Series [v6,1/7] dt-bindings: wireless: wilc1000: Document WILC3000 compatible string | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Marek Vasut Sept. 26, 2024, 7:55 p.m. UTC 
Document compatible string for the WILC3000 chip. The chip is similar
to WILC1000, except that the register layout is slightly different and
it does not support WPA3/SAE.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Adham Abozaeid <adham.abozaeid@microchip.com>
Cc: Ajay Singh <ajay.kathat@microchip.com>
Cc: Alexis Lothoré <alexis.lothore@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
---
V2: - Use WILC1000 as fallback compatible string for WILC3000
V3: - Swap the wilc1000/wilc3000 compatible order
V4: - Add RB from Krzysztof
V5: No change
V6: - Rebase on next-20240926
---
 .../bindings/net/wireless/microchip,wilc1000.yaml           | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Alexis Lothoré Oct. 3, 2024, 8:04 a.m. UTC | #1 
Hello Marek,

On 9/26/24 21:55, Marek Vasut wrote:
> Do not use wilc_get_chipid() outside of wlan.c . Instead, call
> wilc_get_chipid() right after the SDIO/SPI interface has been
> initialized to cache the device chipid, and then use the cached
> chipid throughout the driver. Make wilc_get_chipid() return a
> proper return value instead of a chipid.

This new update now makes the commit message wrong, wilc_get_chipid is used in
files other than wlan.c (and this change goal is now rather to get the chip id
early enough to register wiphy with correct info)

> Signed-off-by: Marek Vasut <marex@denx.de>

With the point above fixed:

Reviewed-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Marek Vasut Oct. 3, 2024, 11:26 a.m. UTC | #2 
On 10/3/24 10:04 AM, Alexis Lothoré wrote:
> Hello Marek,

Hi,

> On 9/26/24 21:55, Marek Vasut wrote:
>> Do not use wilc_get_chipid() outside of wlan.c . Instead, call
>> wilc_get_chipid() right after the SDIO/SPI interface has been
>> initialized to cache the device chipid, and then use the cached
>> chipid throughout the driver. Make wilc_get_chipid() return a
>> proper return value instead of a chipid.
> 
> This new update now makes the commit message wrong, wilc_get_chipid is used in
> files other than wlan.c (and this change goal is now rather to get the chip id
> early enough to register wiphy with correct info)
> 
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> With the point above fixed:
> 
> Reviewed-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Fixed in V7, thanks !
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
index 2460ccc082371..5d40f22765bb6 100644
--- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
@@ -16,7 +16,11 @@  description:
 
 properties:
   compatible:
-    const: microchip,wilc1000
+    oneOf:
+      - items:
+          - const: microchip,wilc3000
+          - const: microchip,wilc1000
+      - const: microchip,wilc1000
 
   reg: true