| Message ID | 20240909-sparx5-lan969x-serdes-driver-v2-8-d695bcb57b84@microchip.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | phy: sparx5-serdes: add support for lan969x serdes driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Mon, Sep 09, 2024 at 05:14:48PM +0200, Daniel Machon wrote: > Lan969x is going to reuse the existing Sparx5 SERDES driver - document > that by adding compatible strings for the different SKU's that we > support, and a short description of the SERDES types and data rates > supported. > > Signed-off-by: Daniel Machon <daniel.machon@microchip.com> > Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com> > --- > .../bindings/phy/microchip,sparx5-serdes.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml b/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml > index bdbdb3bbddbe..fa0b02916dac 100644 > --- a/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml > +++ b/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml > @@ -8,6 +8,7 @@ title: Microchip Sparx5 Serdes controller > > maintainers: > - Steen Hegelund <steen.hegelund@microchip.com> > + - Daniel Machon <daniel.machon@microchip.com> > > description: | > The Sparx5 SERDES interfaces share the same basic functionality, but > @@ -62,12 +63,26 @@ description: | > * 10.3125 Gbps (10GBASE-R/10GBASE-KR/USXGMII) > * 25.78125 Gbps (25GBASE-KR/25GBASE-CR/25GBASE-SR/25GBASE-LR/25GBASE-ER) > > + lan969x has ten SERDES10G interfaces that share the same features, operating > + modes and data rates as the equivalent Sparx5 SERDES10G interfaces. > + > properties: > $nodename: > pattern: "^serdes@[0-9a-f]+$" > > compatible: > - const: microchip,sparx5-serdes > + oneOf: > + - enum: > + - microchip,sparx5-serdes > + - microchip,lan9691-serdes > + - items: > + - enum: > + - microchip,lan9698-serdes > + - microchip,lan9696-serdes > + - microchip,lan9694-serdes > + - microchip,lan9693-serdes > + - microchip,lan9692-serdes If there is going to be a new version, keep rather increasing/growing alphanumerical order, but no need to resend just for this. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
> > maintainers: > > - Steen Hegelund <steen.hegelund@microchip.com> > > + - Daniel Machon <daniel.machon@microchip.com> > > > > description: | > > The Sparx5 SERDES interfaces share the same basic functionality, but > > @@ -62,12 +63,26 @@ description: | > > * 10.3125 Gbps (10GBASE-R/10GBASE-KR/USXGMII) > > * 25.78125 Gbps (25GBASE-KR/25GBASE-CR/25GBASE-SR/25GBASE-LR/25GBASE-ER) > > > > + lan969x has ten SERDES10G interfaces that share the same features, operating > > + modes and data rates as the equivalent Sparx5 SERDES10G interfaces. > > + > > properties: > > $nodename: > > pattern: "^serdes@[0-9a-f]+$" > > > > compatible: > > - const: microchip,sparx5-serdes > > + oneOf: > > + - enum: > > + - microchip,sparx5-serdes > > + - microchip,lan9691-serdes > > + - items: > > + - enum: > > + - microchip,lan9698-serdes > > + - microchip,lan9696-serdes > > + - microchip,lan9694-serdes > > + - microchip,lan9693-serdes > > + - microchip,lan9692-serdes > > If there is going to be a new version, keep rather increasing/growing > alphanumerical order, but no need to resend just for this. Ack. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Thanks for reviewing! /Daniel
diff --git a/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml b/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml index bdbdb3bbddbe..fa0b02916dac 100644 --- a/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml +++ b/Documentation/devicetree/bindings/phy/microchip,sparx5-serdes.yaml @@ -8,6 +8,7 @@ title: Microchip Sparx5 Serdes controller maintainers: - Steen Hegelund <steen.hegelund@microchip.com> + - Daniel Machon <daniel.machon@microchip.com> description: | The Sparx5 SERDES interfaces share the same basic functionality, but @@ -62,12 +63,26 @@ description: | * 10.3125 Gbps (10GBASE-R/10GBASE-KR/USXGMII) * 25.78125 Gbps (25GBASE-KR/25GBASE-CR/25GBASE-SR/25GBASE-LR/25GBASE-ER) + lan969x has ten SERDES10G interfaces that share the same features, operating + modes and data rates as the equivalent Sparx5 SERDES10G interfaces. + properties: $nodename: pattern: "^serdes@[0-9a-f]+$" compatible: - const: microchip,sparx5-serdes + oneOf: + - enum: + - microchip,sparx5-serdes + - microchip,lan9691-serdes + - items: + - enum: + - microchip,lan9698-serdes + - microchip,lan9696-serdes + - microchip,lan9694-serdes + - microchip,lan9693-serdes + - microchip,lan9692-serdes + - const: microchip,lan9691-serdes reg: minItems: 1