| Message ID | 20240908010205.863701-1-quic_nkela@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3] dt-bindings: arm: GIC: add ESPI and EPPI specifiers | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On Sat, Sep 07, 2024 at 06:02:05PM -0700, Nikunj Kela wrote: > Add interrupt specifier for extended SPI and extended PPI interrupts. Are extended SPI and PPI a GIC defined thing? What version of GIC? Yes, I think I already asked these questions, but I only remember what you put into the commit message. > > Qualcomm SA8255p platform uses extended SPI for SCMI 'a2p' doorbells. > > Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> > --- > > Changes in v3: > - Removed the patch from original series[1] > > Changes in v2: > - Modified subject line and description > - Added EPPI macro > > [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/ > --- > include/dt-bindings/interrupt-controller/arm-gic.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/interrupt-controller/arm-gic.h b/include/dt-bindings/interrupt-controller/arm-gic.h > index 35b6f69b7db6..887f53363e8a 100644 > --- a/include/dt-bindings/interrupt-controller/arm-gic.h > +++ b/include/dt-bindings/interrupt-controller/arm-gic.h > @@ -12,6 +12,8 @@ > > #define GIC_SPI 0 > #define GIC_PPI 1 > +#define GIC_ESPI 2 > +#define GIC_EPPI 3 > > /* > * Interrupt specifier cell 2. > -- > 2.34.1 >
On 9/9/2024 8:54 AM, Rob Herring wrote: > On Sat, Sep 07, 2024 at 06:02:05PM -0700, Nikunj Kela wrote: >> Add interrupt specifier for extended SPI and extended PPI interrupts. > Are extended SPI and PPI a GIC defined thing? What version of GIC? > > Yes, I think I already asked these questions, but I only remember what > you put into the commit message. Got it, let me add those details in the commit description. Thanks > >> Qualcomm SA8255p platform uses extended SPI for SCMI 'a2p' doorbells. >> >> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> >> --- >> >> Changes in v3: >> - Removed the patch from original series[1] >> >> Changes in v2: >> - Modified subject line and description >> - Added EPPI macro >> >> [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/ >> --- >> include/dt-bindings/interrupt-controller/arm-gic.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/dt-bindings/interrupt-controller/arm-gic.h b/include/dt-bindings/interrupt-controller/arm-gic.h >> index 35b6f69b7db6..887f53363e8a 100644 >> --- a/include/dt-bindings/interrupt-controller/arm-gic.h >> +++ b/include/dt-bindings/interrupt-controller/arm-gic.h >> @@ -12,6 +12,8 @@ >> >> #define GIC_SPI 0 >> #define GIC_PPI 1 >> +#define GIC_ESPI 2 >> +#define GIC_EPPI 3 >> >> /* >> * Interrupt specifier cell 2. >> -- >> 2.34.1 >>
diff --git a/include/dt-bindings/interrupt-controller/arm-gic.h b/include/dt-bindings/interrupt-controller/arm-gic.h index 35b6f69b7db6..887f53363e8a 100644 --- a/include/dt-bindings/interrupt-controller/arm-gic.h +++ b/include/dt-bindings/interrupt-controller/arm-gic.h @@ -12,6 +12,8 @@ #define GIC_SPI 0 #define GIC_PPI 1 +#define GIC_ESPI 2 +#define GIC_EPPI 3 /* * Interrupt specifier cell 2.
Add interrupt specifier for extended SPI and extended PPI interrupts. Qualcomm SA8255p platform uses extended SPI for SCMI 'a2p' doorbells. Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> --- Changes in v3: - Removed the patch from original series[1] Changes in v2: - Modified subject line and description - Added EPPI macro [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/ --- include/dt-bindings/interrupt-controller/arm-gic.h | 2 ++ 1 file changed, 2 insertions(+)