| Message ID | 20240905200218.3810712-1-quic_nkela@quicinc.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v3] dt-bindings: pinctrl: Add SA8255p TLMM | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Sep 05, 2024 at 01:02:18PM -0700, Nikunj Kela wrote: > Add compatible for TLMM block representing support on SA8255p. > > SA8255p uses the same TLMM block as SA8775p however the ownership > of pins are split between Firmware VM and Linux VM on SA8255p. For > example, pins used by UART are owned and configured by Firmware VM > while pins used by ethernet are owned and configured by Linux VM. > Therefore, adding a sa8255p specific compatible to mark the difference. > > Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> > --- > > Changes in v3: > - Removed the patch from original series[1] > - Fixed mising spaces schema errors > > Changes in v2: > - Modified subject line > - Fixed schema to include fallback > > [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/ > --- > .../devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > index e9abbf2c0689..749dbc563ac5 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml > @@ -17,7 +17,13 @@ allOf: > > properties: > compatible: > - const: qcom,sa8775p-tlmm > + oneOf: > + - items: > + - enum: > + - qcom,sa8255p-tlmm > + - const: qcom,sa8775p-tlmm > + - items: No need to add items here, there were not present before. Anyway, Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Sep 5, 2024 at 10:02 PM Nikunj Kela <quic_nkela@quicinc.com> wrote: > Add compatible for TLMM block representing support on SA8255p. > > SA8255p uses the same TLMM block as SA8775p however the ownership > of pins are split between Firmware VM and Linux VM on SA8255p. For > example, pins used by UART are owned and configured by Firmware VM > while pins used by ethernet are owned and configured by Linux VM. > Therefore, adding a sa8255p specific compatible to mark the difference. > > Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> Patch applied! Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml index e9abbf2c0689..749dbc563ac5 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml @@ -17,7 +17,13 @@ allOf: properties: compatible: - const: qcom,sa8775p-tlmm + oneOf: + - items: + - enum: + - qcom,sa8255p-tlmm + - const: qcom,sa8775p-tlmm + - items: + - const: qcom,sa8775p-tlmm reg: maxItems: 1
Add compatible for TLMM block representing support on SA8255p. SA8255p uses the same TLMM block as SA8775p however the ownership of pins are split between Firmware VM and Linux VM on SA8255p. For example, pins used by UART are owned and configured by Firmware VM while pins used by ethernet are owned and configured by Linux VM. Therefore, adding a sa8255p specific compatible to mark the difference. Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> --- Changes in v3: - Removed the patch from original series[1] - Fixed mising spaces schema errors Changes in v2: - Modified subject line - Fixed schema to include fallback [1]: https://lore.kernel.org/all/20240903220240.2594102-1-quic_nkela@quicinc.com/ --- .../devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)