| Message ID | 20240905164142.3475873-2-vladimir.zapolskiy@linaro.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | media: dt-bindings: media: camss: Fix interrupt types | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 46 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Thu, Sep 05, 2024 at 07:41:37PM +0300, Vladimir Zapolskiy wrote: > The expected type of all CAMSS interrupts is edge rising, fix it in > the documented example from CAMSS device tree bindings for sc8280xp. > > Fixes: bc5191e5799e ("media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding") > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- > .../bindings/media/qcom,sc8280xp-camss.yaml | 40 +++++++++---------- > 1 file changed, 20 insertions(+), 20 deletions(-) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Sep 05, 2024 at 07:41:37PM +0300, Vladimir Zapolskiy wrote: > The expected type of all CAMSS interrupts is edge rising, fix it in > the documented example from CAMSS device tree bindings for sc8280xp. Subject: drop duplicated media. One media is enough (the first). Best regards, Krzysztof
Hi Krzysztof, On 9/6/24 13:31, Krzysztof Kozlowski wrote: > On Thu, Sep 05, 2024 at 07:41:37PM +0300, Vladimir Zapolskiy wrote: >> The expected type of all CAMSS interrupts is edge rising, fix it in >> the documented example from CAMSS device tree bindings for sc8280xp. > > Subject: drop duplicated media. One media is enough (the first). > thank you for review, here I've attemted to follow the established practice. % git log -n 500 --oneline Documentation/devicetree/bindings/media/ | grep "media:.*media:" | wc -l 166 So 1/3 of relevant commits to the folder have the duplicated "media:" in the subject, the reason is not totally clear to me, thus I've just inflowed into the same. -- Best wishes, Vladimir
On 06/09/2024 13:06, Vladimir Zapolskiy wrote: > Hi Krzysztof, > > On 9/6/24 13:31, Krzysztof Kozlowski wrote: >> On Thu, Sep 05, 2024 at 07:41:37PM +0300, Vladimir Zapolskiy wrote: >>> The expected type of all CAMSS interrupts is edge rising, fix it in >>> the documented example from CAMSS device tree bindings for sc8280xp. >> >> Subject: drop duplicated media. One media is enough (the first). >> > > thank you for review, here I've attemted to follow the established practice. > > % git log -n 500 --oneline Documentation/devicetree/bindings/media/ | grep "media:.*media:" | wc -l > 166 > > So 1/3 of relevant commits to the folder have the duplicated "media:" > in the subject, the reason is not totally clear to me, thus I've just > inflowed into the same. People like to repeat same mistakes, but just because 166 times someone did a mistake, is not a reason to do the same. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml index c0bc31709873..9936f0132417 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml @@ -328,26 +328,26 @@ examples: vdda-phy-supply = <&vreg_l6d>; vdda-pll-supply = <&vreg_l4d>; - interrupts = <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 468 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 469 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 477 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 478 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 640 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 758 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 759 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 760 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 761 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 762 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 764 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 464 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 466 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 640 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 641 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 762 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 764 IRQ_TYPE_EDGE_RISING>; interrupt-names = "csid1_lite", "vfe_lite1",
The expected type of all CAMSS interrupts is edge rising, fix it in the documented example from CAMSS device tree bindings for sc8280xp. Fixes: bc5191e5799e ("media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding") Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> --- .../bindings/media/qcom,sc8280xp-camss.yaml | 40 +++++++++---------- 1 file changed, 20 insertions(+), 20 deletions(-)