| Message ID | 20240905114754.519609-2-jacky_chou@aspeedtech.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | net: mdio: Add ASPEED AST2700 MDIO compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 05/09/2024 13:47, Jacky Chou wrote: > Add a new compatible for ASPEED AST2700 MDIO. You have entire commit msg to explain the differences of the hardware, including whether they are or are not compatible. > > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> > --- > .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > index d6ef468495c5..6dadca099875 100644 > --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml > @@ -19,7 +19,9 @@ allOf: > > properties: > compatible: > - const: aspeed,ast2600-mdio > + enum: > + - aspeed,ast2600-mdio > + - aspeed,ast2700-mdio Your driver says something else... Best regards, Krzysztof
On 05/09/2024 13:47, Jacky Chou wrote: > Add a new compatible for ASPEED AST2700 MDIO. > > Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> A nit, subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml index d6ef468495c5..6dadca099875 100644 --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml @@ -19,7 +19,9 @@ allOf: properties: compatible: - const: aspeed,ast2600-mdio + enum: + - aspeed,ast2600-mdio + - aspeed,ast2700-mdio reg: maxItems: 1
Add a new compatible for ASPEED AST2700 MDIO. Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> --- .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)